Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130200
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: [PHP-DEV] [RFC] [VOTE] Prefix and Suffix Functions
Date: Fri, 27 Feb 2026 22:28:00 +0100
References: <CABVsipj6sbpDN1qycfkiSKyS1QZcCr2b5yW-tFcTOQy8Ju3jkg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
In-Reply-To: <CABVsipj6sbpDN1qycfkiSKyS1QZcCr2b5yW-tFcTOQy8Ju3jkg@mail.gmail.com>
Message-ID: <C53435AF-7947-4654-BA5E-0CC4996BE7B5@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 27.02.2026 um 14:31 schrieb Barel <barel.barelon@gmail.com>:
> This is to announce the opening of the vote for the Prefix and Suffix =
Functions RFC
>=20
> RFC: https://wiki.php.net/rfc/prefix_suffix_functions
> Discussion thread: https://news-web.php.net/php.internals/129842

My reason to vote no was that
a) it is sort of a matrix of functions (prefix|suffix x =
ensure|remove|replace) a doing something very similar
b) there are several downsides to these specific implementations

The downsides I see at a first glance:
- case sensitive: str_suffix_replace(".jpeg", ".jpg", $filename) does =
not work with "Image.JPEG"
- *_ensure doesn't handle multiples: str_suffix_ensure($path, '/') does =
not handle "/api//"

This leads me to the conclusion that I'd probably stick to the =
old-school use of preg_replace which handles *all* the things these =
functions try to solve.
And while I agree that regular expressions are a bit harder to read they =
(to me) are simple enough while not having these downsides.

E.g. I would rewrite
	$file =3D str_suffix_replace('.jpeg', '.jpg', $file);
as
	$file =3D preg_replace('#\.jpeg$#i', '.jpg', $file);	# Case =
insentive, easily extended also handle jpe and jfif

And instead of
	$path =3D str_suffix_ensure($path, '/');
I would write
	$path1 =3D preg_replace('#/*$#', '/', $path, 1);	# Ensure =
one single slashes at the end
or maybe even
	$path =3D preg_replace('#/+#', '/', "$path/");	# Also =
normalizes all multiple slashes in the path

Side-note: Regular expressions handle all the stuff described in the =
Future Scope section.

Some people like long and descriptive special functions for (depending =
on the context) common cases but I realized that I often prefer being =
able to reuse powerful functionality instead of having to guess if a =
specialized function might exists even with modern dev environments make =
finding the right function easier. YMMV.

Regards,
- Chris