Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130198
Precedence: list
MIME-Version: 1.0
References: <CABVsipj6sbpDN1qycfkiSKyS1QZcCr2b5yW-tFcTOQy8Ju3jkg@mail.gmail.com>
 <AM8P250MB017021F68305D9C0D262AB0BE273A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <09e17a8d-5d40-4b69-bd3f-3e73a7b998b6@app.fastmail.com> <AM8P250MB0170D91016175ADDBBEDC211E273A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <CAPyj-LCM3QG_EBOEku-68MO_b-_8BDPPwzBxdn=CdcOsQXTo9w@mail.gmail.com>
In-Reply-To: <CAPyj-LCM3QG_EBOEku-68MO_b-_8BDPPwzBxdn=CdcOsQXTo9w@mail.gmail.com>
Date: Fri, 27 Feb 2026 16:55:37 +0000
Message-ID: <CAGBsUrc1szngT-bU3gyEVBkYO-8iO2UOgTEr9z98+fgzXK3avg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Prefix and Suffix Functions
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tekiela246@gmail.com (Kamil Tekiela)

On Fri, 27 Feb 2026 at 16:48, Ilija Tovilo <tovilo.ilija@gmail.com> wrote:
>
> On Fri, Feb 27, 2026 at 5:42=E2=80=AFPM Bob Weinand <bobwei9@hotmail.com>=
 wrote:
> >
> > Hey Larry,
> >
> > On 27.2.2026 17:32:47, Larry Garfield wrote:
> > > Though I would also question why so many people are voting for $subje=
ct-last for the secondary vote.
> >
> > The two-argument variants are consistent with e.g. addcslashes (one
> > subject operated on with an argument) - so that's perfectly consistent.
> >
> > Then for replacing, you want consistency with str_replace, and
> > preg_replace and such.
>
> Maybe consistently inconsistent. ;) In my opinion, it's much better to
> not keep repeating the same mistake, pick a standard and stick with
> it. Subject-first always works. I wouldn't think many people want to
> internalize the placement of the subject based on the kind of string
> replacement function.
>
> Ilija

I think $subject should be first because these functions align with
other str_prefix_* functions. If the names were inverted, i.e.
str_ensure_prefix, then I would vote for $subject to be last because
str_replace and str_replace_suffix are more aligned.