Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130167
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAEO8w0GJXTVyH_nwK8nGQGdJcNNkGOPMnYDVrcsNGrm4A@mail.gmail.com>
 <CAEKnhAE5iG6VfgS6=+FrpbDN5T-7iOA7j0gN9n-pr0HmBe=3EA@mail.gmail.com> <36066994-5b15-4b96-88db-47ab4bf92376@varteg.nz>
In-Reply-To: <36066994-5b15-4b96-88db-47ab4bf92376@varteg.nz>
Date: Wed, 25 Feb 2026 13:37:47 +0100
Message-ID: <CAEKnhAHUFL224T_8Xh5DPb09dK-r6eQ9V3944nVJXhz0MAYpUA@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] Stream Error Handling Improvements
To: Morgan <weedpacket@varteg.nz>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000002cb700064ba54627"
From: bukka@php.net (Jakub Zelenka)

--0000000000002cb700064ba54627
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Dec 30, 2025 at 12:25=E2=80=AFAM Morgan <weedpacket@varteg.nz> wrot=
e:

> On 2025-12-30 07:52, Jakub Zelenka wrote:
> >
> >   Hi, I just published version 2.0 which is a significant redesign
> > including:
> >
> > - Introducing ... StreamErrorCode
> > enums.... The
> > code is backed (int) because I need to keep the number to easily match
> > the category and simplify the mapping. I think that in this case a
> > backed enum is better.
> >
>
> Just spitballing here, but perhaps a StreamErrorCategory enum? The Code
> could have a method/property that matches it to the corresponding
> Category; categorising errors of different kinds can be done by
> branching on the Category, rather than (possibly multiple) is*Error()
> tests.
>

This is an interesting idea but it wouldn't work because some categories
are overlapping. So is*Error functions seem better fit here.

Kind regards,

Jakub

--0000000000002cb700064ba54627
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Dec 30, 2025 at 12:2=
5=E2=80=AFAM Morgan &lt;<a href=3D"mailto:weedpacket@varteg.nz">weedpacket@=
varteg.nz</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">On 2025-12-30 07:52, Jakub Zelenka wrote:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0Hi, I just published version 2.0 which is a significant re=
design <br>
&gt; including:<br>
&gt; <br>
&gt; - Introducing ... StreamErrorCode <br>
&gt; enums.... The <br>
&gt; code is backed (int) because I need to keep the number to easily match=
 <br>
&gt; the category and simplify the mapping. I think that in this case a <br=
>
&gt; backed enum is better.<br>
&gt; <br>
<br>
Just spitballing here, but perhaps a StreamErrorCategory enum? The Code <br=
>
could have a method/property that matches it to the corresponding <br>
Category; categorising errors of different kinds can be done by <br>
branching on the Category, rather than (possibly multiple) is*Error() tests=
.<br></blockquote><div><br></div><div>This is an interesting idea but it wo=
uldn&#39;t work because some categories are overlapping. So is*Error functi=
ons seem better fit here.</div><div><br></div><div>Kind regards,</div><div>=
<br></div><div>Jakub</div></div></div>

--0000000000002cb700064ba54627--