Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130158
Precedence: list
MIME-Version: 1.0
References: <CAOWwgp=JtbTSVCv9z=QGx9yS=8G72L-hcAjcOj33eEMLB0zfvg@mail.gmail.com>
 <CADyq6sJMXmDixLPO91P5d+5V28zhu0TVVfLxBKSUfF41JtYjkw@mail.gmail.com>
 <CAOWwgpnToAqGN=_bj9JB8gj-2PO9gqq2SgFYYg6LmPTSmCyQ=Q@mail.gmail.com>
 <4b74f9a1-96d2-4104-abdd-fe56c5e7016c@app.fastmail.com> <CAOWwgpnrnk-a6uczGnuE76rpd9mZvwXs=SHwuo+-4fWgLm9Jcg@mail.gmail.com>
 <585bfc82-a522-43ec-be42-b8945952fe8b@app.fastmail.com> <CAOWwgpn-agceHfEvRhyU0UEJCCif=6znH15=-m2B8ScEngUcEw@mail.gmail.com>
 <a5f91ba2-2fad-4e46-a4a7-a597972cf460@bastelstu.be> <CAOWwgpmCMJxcqsyc7WXc90M1fvUhY6_3aa8P63bNJMPLR=ke0Q@mail.gmail.com>
 <3cd0d869-5a5b-467c-8eb4-3f8647ba7aa7@bastelstu.be> <CAOWwgpm14su1A_pGFys29h0p+nzM6CLBWBYFSWLAjA2Gm93DNg@mail.gmail.com>
 <6def7a03-eba4-4289-ac4f-0881c5d4c092@bastelstu.be> <CAOWwgpmp7xhWCmm95f0C=mG1m71inOW4wV9R_yjHTOokVcTb2w@mail.gmail.com>
 <e70555fd-aca4-46cf-bfe1-e85c4191c38a@app.fastmail.com>
In-Reply-To: <e70555fd-aca4-46cf-bfe1-e85c4191c38a@app.fastmail.com>
Date: Tue, 24 Feb 2026 20:34:16 +0100
Message-ID: <CAOWwgp=UgTDqvxFh7z8xdwW7hkio_M8HDTk4Lz827mhiKt3SWg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Allow Reassignment of Promoted Readonly
 Properties in Constructor
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000cd21e9064b96f9a5"
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000cd21e9064b96f9a5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le mar. 24 f=C3=A9vr. 2026 =C3=A0 20:06, Larry Garfield <larry@garfieldtech=
.com> a
=C3=A9crit :

> On Mon, Feb 23, 2026, at 1:49 AM, Nicolas Grekas wrote:
> > Le dim. 22 f=C3=A9vr. 2026 =C3=A0 19:14, Tim D=C3=BCsterhus <tim@bastel=
stu.be> a =C3=A9crit
> :
> >> Hi
> >>
> >> On 2/19/26 10:49, Nicolas Grekas wrote:
> >> > Thanks, I've added new test cases to cover this.
> >> > I've also improved tests as suggested on the PR.
> >> > And finally I updated the implementation to reuse IS_PROP_REINITABLE
> >> > instead of adding new flags + use an approach that doesn't require
> walking
> >> > the call stack.
> >> > PR and RFC updated accordingly, all green.
> >>
> >> Thank you. The implementation looks much simpler now and the tests all
> >> make sense to me and I can't think of any other relevant =E2=80=9Cedge=
 case=E2=80=9D.
> >>
> >> I have one more comment regarding the RFC text, which should result in
> >> =E2=80=9Cminor=E2=80=9D changes as per the policy of making clarifying=
 changes:
> >>
> >> 1. =E2=80=9CSet in child before parent::__construct()=E2=80=9D also fa=
ils, since the
> >> property slot is not yet initialized:
> >>
> >> That explanation and example does not seem to be quite correct: It's
> not
> >> the `$this->x =3D 'C';` assignment that fails, it's the implicit CPP
> >> assignment when calling parent::__construct(). The explanation should
> be
> >> fixed and the `// Error: Cannot modify readonly property P::$x` commen=
t
> >> should be moved to the `parent::__construct()` call.
> >>
> >> The test in the implementation was already correct.
> >>
> >
> > Hi Tim,
> >
> > Good catch thanks, wording updated!
> > The RFC is ready then. Any other comments from anyone else?
> >
> > Nicolas
>
> Two minor non-substantive points.
>
> 1. The "supported operations" section all the way at the bottom seems
> redundant.  That was already specified earlier.
>
> 2. It could be helpful to include an example of using property hooks in
> the intro; there's an example of the other 2 options, but not of hooks,
> which are also mentioned as a not-always-ideal alternative.  (Let me know
> if you want help or suggestions with that example.)
>
> Otherwise, I'm happy with where this ended up.  Thanks!
>
>
Thanks for having a look!
Here is the update:
https://wiki.php.net/rfc/promoted_readonly_constructor_reassign?do=3Ddiff&r=
ev2%5B0%5D=3D1771797005&rev2%5B1%5D=3D1771961558&difftype=3Dsidebyside

Cheers,
Nicolas

--000000000000cd21e9064b96f9a5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">Le=C2=A0mar. 24=
 f=C3=A9vr. 2026 =C3=A0=C2=A020:06, Larry Garfield &lt;<a href=3D"mailto:la=
rry@garfieldtech.com">larry@garfieldtech.com</a>&gt; a =C3=A9crit=C2=A0:<br=
></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Feb 23, 20=
26, at 1:49 AM, Nicolas Grekas wrote:<br>
&gt; Le dim. 22 f=C3=A9vr. 2026 =C3=A0 19:14, Tim D=C3=BCsterhus &lt;<a hre=
f=3D"mailto:tim@bastelstu.be" target=3D"_blank">tim@bastelstu.be</a>&gt; a =
=C3=A9crit :<br>
&gt;&gt; Hi<br>
&gt;&gt; <br>
&gt;&gt; On 2/19/26 10:49, Nicolas Grekas wrote:<br>
&gt;&gt; &gt; Thanks, I&#39;ve added new test cases to cover this.<br>
&gt;&gt; &gt; I&#39;ve also improved tests as suggested on the PR.<br>
&gt;&gt; &gt; And finally I updated the implementation to reuse IS_PROP_REI=
NITABLE<br>
&gt;&gt; &gt; instead of adding new flags + use an approach that doesn&#39;=
t require walking<br>
&gt;&gt; &gt; the call stack.<br>
&gt;&gt; &gt; PR and RFC updated accordingly, all green.<br>
&gt;&gt; <br>
&gt;&gt; Thank you. The implementation looks much simpler now and the tests=
 all <br>
&gt;&gt; make sense to me and I can&#39;t think of any other relevant =E2=
=80=9Cedge case=E2=80=9D.<br>
&gt;&gt; <br>
&gt;&gt; I have one more comment regarding the RFC text, which should resul=
t in <br>
&gt;&gt; =E2=80=9Cminor=E2=80=9D changes as per the policy of making clarif=
ying changes:<br>
&gt;&gt; <br>
&gt;&gt; 1. =E2=80=9CSet in child before parent::__construct()=E2=80=9D als=
o fails, since the <br>
&gt;&gt; property slot is not yet initialized:<br>
&gt;&gt; <br>
&gt;&gt; That explanation and example does not seem to be quite correct: It=
&#39;s not <br>
&gt;&gt; the `$this-&gt;x =3D &#39;C&#39;;` assignment that fails, it&#39;s=
 the implicit CPP <br>
&gt;&gt; assignment when calling parent::__construct(). The explanation sho=
uld be <br>
&gt;&gt; fixed and the `// Error: Cannot modify readonly property P::$x` co=
mment <br>
&gt;&gt; should be moved to the `parent::__construct()` call.<br>
&gt;&gt; <br>
&gt;&gt; The test in the implementation was already correct.<br>
&gt;&gt; <br>
&gt;<br>
&gt; Hi Tim,<br>
&gt;<br>
&gt; Good catch thanks, wording updated!<br>
&gt; The RFC is ready then. Any other comments from anyone else?<br>
&gt;<br>
&gt; Nicolas<br>
<br>
Two minor non-substantive points.<br>
<br>
1. The &quot;supported operations&quot; section all the way at the bottom s=
eems redundant.=C2=A0 That was already specified earlier.<br>
<br>
2. It could be helpful to include an example of using property hooks in the=
 intro; there&#39;s an example of the other 2 options, but not of hooks, wh=
ich are also mentioned as a not-always-ideal alternative.=C2=A0 (Let me kno=
w if you want help or suggestions with that example.)<br>
<br>
Otherwise, I&#39;m happy with where this ended up.=C2=A0 Thanks!<br>
<br></blockquote><div><br></div><div>Thanks for having a look!</div><div>He=
re is the update:=C2=A0<a href=3D"https://wiki.php.net/rfc/promoted_readonl=
y_constructor_reassign?do=3Ddiff&amp;rev2%5B0%5D=3D1771797005&amp;rev2%5B1%=
5D=3D1771961558&amp;difftype=3Dsidebyside">https://wiki.php.net/rfc/promote=
d_readonly_constructor_reassign?do=3Ddiff&amp;rev2%5B0%5D=3D1771797005&amp;=
rev2%5B1%5D=3D1771961558&amp;difftype=3Dsidebyside</a></div><div><br></div>=
<div>Cheers,</div><div>Nicolas</div></div></div>

--000000000000cd21e9064b96f9a5--