Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130138
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: [PHP-DEV] [RFC] DocComments For Function Parameters
Date: Mon, 23 Feb 2026 18:32:29 +0100
References: <24229A82-F5BF-48F2-9E6C-FE45A99FB9E9@cschneid.com>
 <c8086cca-ada0-4f74-8f5c-bb4f1b60b723@bastelstu.be>
To: PHP internals list <internals@lists.php.net>
In-Reply-To: <c8086cca-ada0-4f74-8f5c-bb4f1b60b723@bastelstu.be>
Message-ID: <65C41C15-74C2-4A25-ABA7-056D612DF366@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 22.02.2026 um 18:52 schrieb Tim D=C3=BCsterhus <tim@bastelstu.be>:
> - Please add a link to the ML discussion to the =E2=80=9CReferences=E2=80=
=9D section: https://news-web.php.net/php.internals/130121
>=20
> - The ABI change is irrelevant: Extensions have to be recompiled for =
every PHP branch and new features may not ship with 3rd-digit versions =
anyways. Mentioning this is thus misleading at best (affecting =
=E2=80=9CBackwards incompatible changes=E2=80=9D, =E2=80=9CProposed PHP =
version=E2=80=9D, and =E2=80=9CRFC Impact=E2=80=9D).
>=20
> - In fact, there is not even an ABI change, because the new field is =
added at the end of the struct.
>=20
> - Within the =E2=80=9CEcosystem=E2=80=9D impact, you should probably =
mention that this might require adjustments to code style / formatting =
guidelines and autoformatters - or at the very least a decision needs to =
be made there.

Thanks for this feedback.
I changed the RFC accordingly and also added an implementation PR and a =
test and I would consider it ready.

RFC: https://wiki.php.net/rfc/parameter-doccomments
PR: https://github.com/php/php-src/pull/21279

Regards,
- Chris