Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:130062
Precedence: list
MIME-Version: 1.0
References: <CAFgk54k4NkUrUkMD=HE1TkowDJb55X9B7hcCa7vxGUbAfQhv8w@mail.gmail.com>
 <0ece40da-762a-4190-9cc8-23ff432fd441@bastelstu.be> <69867F01.2070107@adviesenzo.nl>
In-Reply-To: <69867F01.2070107@adviesenzo.nl>
Date: Mon, 9 Feb 2026 10:29:55 +0100
Message-ID: <CAFgk54=HNE1KcbDGPnb+emLSR25QVZnRNUkrgV_rgvK5P-qhkw@mail.gmail.com>
Subject: Re: [PHP-DEV] [IDEA for RFC] let the "new" operator fail when the
 __construct() function returns a value.
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: mirco.babin@gmail.com (Mirco Babin)

> FYI/Just in case anyone already wants to forbid this - there is a sniff
> available which will flag both constructors as well as destructors with
> a return type and/or when the function returns something:
> Universal.CodeAnalysis.ConstructorDestructorReturn
>
> Ref: https://github.com/PHPCSStandards/PHPCSExtra#universalcodeanalysisco=
nstructordestructorreturn-wrench-books

Thank you very much for this information. Using PHP Code Sniffer, we
identified two more return values from the __construct() functions.

Installing PHP Code Sniffer on Windows without using Composer is
cumbersome. For those who want to use the PHP Code Sniffer tool,
I've included installation instructions in the original issue, see:
https://github.com/php/php-src/issues/21090#issuecomment-3870404274

Kind regards,
Mirco Babin

Op za 7 feb 2026 om 00:56 schreef Juliette Reinders Folmer
<php-internals_nospam@adviesenzo.nl>:
>
> On 6-2-2026 20:59, Tim D=C3=BCsterhus wrote:
>
> On 2/2/26 19:00, Mirco Babin wrote:
>
> # RFC
>
> I've been asked to follow the RFC process. And I've been told that the
> rejected PHP RFC Make constructors and destructors return void
> ( https://wiki.php.net/rfc/make_ctor_ret_void ) rejects my proposal.
> However, my proposal is explicitly about the "new" operator and not
> about return types. It does, however, concern return values.
>
>
> Personally I find the fact that it's illegal to define a return type on `=
__construct()` to be a pretty good indication that the constructor is not m=
eant to be able to return anything. As such I'm a little surprised by the d=
isagreement in that RFC, though it should be noted that a majority was in f=
avor (just not a 2/3's majority).
>
>
> FYI/Just in case anyone already wants to forbid this - there is a sniff a=
vailable which will flag both constructors as well as destructors with a re=
turn type and/or when the function returns something: Universal.CodeAnalysi=
s.ConstructorDestructorReturn
>
> Ref: https://github.com/PHPCSStandards/PHPCSExtra#universalcodeanalysisco=
nstructordestructorreturn-wrench-books