Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129969
Precedence: list
MIME-Version: 1.0
References: <CAPyj-LC0fn2NvQEpebo6NbL5R8svZ8CmtHUhb5BkUE4W49eXzw@mail.gmail.com>
In-Reply-To: <CAPyj-LC0fn2NvQEpebo6NbL5R8svZ8CmtHUhb5BkUE4W49eXzw@mail.gmail.com>
Date: Sat, 31 Jan 2026 18:54:23 +0100
Message-ID: <CAPTD5yHO1kPo8Cn0WWRNhb9uzrpcy3pM24PfPLuq3nr96t-P6A@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] Closure optimizations
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006b78800649b2c8ba"
From: jorg.sowa@gmail.com (Jorg Sowa)

--0000000000006b78800649b2c8ba
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ilija,

Thank you for this improvement. If I understand correctly, one of the
predicted BC changes will fix one of the issues with unit test comparisons.

The sebastianbergmann/comparator library cannot compare closures, because
each closure is in fact a different instance. With your change, this might
be resolved for static closures. So I see this is in fact very beneficial
for the unit testing.

https://github.com/sebastianbergmann/comparator/issues/129

Kind regards,
Jorg


On Sat, Jan 31, 2026 at 12:41=E2=80=AFAM Ilija Tovilo <tovilo.ilija@gmail.c=
om>
wrote:

> Hi everyone
>
> A week ago, I sent an e-mail to internals regarding two closure
> optimizations with some subtle BC breaks. [1] While nobody objected, I
> decided to create a short RFC anyway to avoid any possible controversy
> due to the BC breaks. You can find it here:
>
> https://wiki.php.net/rfc/closure-optimizations
>
> Regards,
> Ilija
>
> [1] https://externals.io/message/129825
>

--0000000000006b78800649b2c8ba
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><div><div>Hi Ilija,=C2=A0<p>Thank yo=
u=20
for this improvement. If I understand correctly, one of the predicted BC
 changes will fix one of the issues with unit test comparisons.</p>
<p>The <code>sebastianbergmann/comparator</code> library cannot compare=20
closures, because each closure is in fact a different instance. With=20
your change, this might be resolved for static closures. So I see this=20
is in fact very beneficial for the unit testing.</p>
<p><a rel=3D"noopener" class=3D"gmail-decorated-link" href=3D"https://githu=
b.com/sebastianbergmann/comparator/issues/129">https://github.com/sebastian=
bergmann/comparator/issues/129<span aria-hidden=3D"true" class=3D"gmail-ms-=
0.5 gmail-inline-block gmail-align-middle gmail-leading-none"></span></a></=
p></div><br></div>Kind regards,<br></div>Jorg</div><br></div><br><div class=
=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr=
">On Sat, Jan 31, 2026 at 12:41=E2=80=AFAM Ilija Tovilo &lt;<a href=3D"mail=
to:tovilo.ilija@gmail.com">tovilo.ilija@gmail.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">Hi everyone<br>
<br>
A week ago, I sent an e-mail to internals regarding two closure<br>
optimizations with some subtle BC breaks. [1] While nobody objected, I<br>
decided to create a short RFC anyway to avoid any possible controversy<br>
due to the BC breaks. You can find it here:<br>
<br>
<a href=3D"https://wiki.php.net/rfc/closure-optimizations" rel=3D"noreferre=
r" target=3D"_blank">https://wiki.php.net/rfc/closure-optimizations</a><br>
<br>
Regards,<br>
Ilija<br>
<br>
[1] <a href=3D"https://externals.io/message/129825" rel=3D"noreferrer" targ=
et=3D"_blank">https://externals.io/message/129825</a><br>
</blockquote></div>

--0000000000006b78800649b2c8ba--