Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:12995
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: internals@lists.php.net
Content-Type: multipart/mixed; boundary="=-o+VY51WoXN0bkk/TwHcM"
Message-ID: <1096193618.321.2.camel@localhost>
Mime-Version: 1.0
Date: Sun, 26 Sep 2004 12:13:38 +0200
Subject: Readline compile failure
From: thekid@thekid.de (Timm Friebe)

--=-o+VY51WoXN0bkk/TwHcM
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,
here's a patch that fixes the following:

In file included from
/usr/home/thekid/devel/php/php/ext/readline/readline.c:28:
/usr/home/thekid/devel/php/php/ext/readline/php_readline.h:26: warning:
#warning Readline module will *NEVER* be thread-safe
/usr/home/thekid/devel/php/php/ext/readline/readline.c: In function
`_readline_completion_cb':
/usr/home/thekid/devel/php/php/ext/readline/readline.c:423: warning:
passing arg 1 of `completion_matches' discards qualifiers from pointer
target type
/usr/home/thekid/devel/php/php/ext/readline/readline.c: In function
`zif_readline_completion_function':
/usr/home/thekid/devel/php/php/ext/readline/readline.c:443: syntax error
before `char'
/usr/home/thekid/devel/php/php/ext/readline/readline.c:444: `name'
undeclared (first use in this function)
/usr/home/thekid/devel/php/php/ext/readline/readline.c:444: (Each
undeclared identifier is reported only once
/usr/home/thekid/devel/php/php/ext/readline/readline.c:444: for each
function it appears in.)
*** Error code 1

Stop in /usr/home/thekid/devel/php/php.

- Timm

--=-o+VY51WoXN0bkk/TwHcM
Content-Disposition: attachment; filename=readline.patch
Content-Type: text/x-patch; name=readline.patch; charset=iso-8859-1
Content-Transfer-Encoding: 7bit

Index: ext/readline/readline.c
===================================================================
RCS file: /repository/php-src/ext/readline/readline.c,v
retrieving revision 1.37
diff -u -r1.37 readline.c
--- ext/readline/readline.c	17 Sep 2004 11:26:43 -0000	1.37
+++ ext/readline/readline.c	26 Sep 2004 10:17:08 -0000
@@ -435,12 +435,12 @@
 PHP_FUNCTION(readline_completion_function)
 {
 	zval *arg = NULL;
+	char *name = NULL;
 
 	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &arg)) {
 		RETURN_FALSE;
 	}
 
-	char *name = NULL;
 	if (!zend_is_callable(arg, 0, &name)) {
 		php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s is not callable", name);
 		RETURN_FALSE;

--=-o+VY51WoXN0bkk/TwHcM--