Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129883
Precedence: list
MIME-Version: 1.0
References: <CABVsiphxzSjri5BU+-HUYP2JgoGFOgN4epDTG9exVpJZFNw71g@mail.gmail.com>
 <e5ec59e24469fae8fd24b8e222d7917c@bastelstu.be> <CABVsipgm5LZd-_6WPVknsKKFq2Y7EQ9EUFiDYAHuSdX9B96e2g@mail.gmail.com>
 <15b6506dc69bd13eceffd36375f83509@bastelstu.be>
In-Reply-To: <15b6506dc69bd13eceffd36375f83509@bastelstu.be>
Date: Fri, 23 Jan 2026 11:32:04 +0100
Message-ID: <CABVsipgXrqv9Ra95oRFSqdyesEZU-AiOrZtveSPPBHPXG9EeUQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Prefix and Suffix Functions
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c0f25106490bab53"
From: barel.barelon@gmail.com (Barel)

--000000000000c0f25106490bab53
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 23 Jan 2026 at 09:31, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:

> Hi
>
> Am 2026-01-22 19:28, schrieb Barel:
> > Following a comment by Tim D=C3=BCsterhus (thanks!) and another comment=
 in
> > the
> > PR, I have inverted the order of the parameters in the ensure and
> > remove
> > functions, so that they follow the parameter order in related functions
> > like str_contains() and str_starts_with()
>
> Thank you. I have given the RFC another look and have some polishing
> comments:
>
> 1. In the =E2=80=9CExact semantics (per function)=E2=80=9D example it wou=
ld probably be
> easier to understand if you would provide a userland implementation.
> Folks are already used to reading PHP and there is no ambiguity about
> the proposed behavior then. As a benefit, the implementation from the
> RFC would directly be usable as a polyfill, e.g. for use in
> https://github.com/symfony/polyfill. The previous =E2=80=9Carray_find=E2=
=80=9D RFC might
> be a good example here: https://wiki.php.net/rfc/array_find
>
> 2. In the =E2=80=9CBackwards Incompatible Changes=E2=80=9D section: Can y=
ou please
> perform some research for a rough number estimation? e.g. using GitHub's
> code search.
>
> ------
>
> Another thing I realized is the interaction between the `_replace`
> functions and PFA: It can be used as an (inefficient?) way of creating a
> concat as a function handle: `$concat =3D str_prefix_replace("", ?, ?);`
> (with suffix_replace being a reverse concat).
>
> Best regards
> Tim D=C3=BCsterhus
>

Tim, thanks for your suggestions, I updated the RFC

Cheers

Carlos

--000000000000c0f25106490bab53
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, 23 Jan 2026 at 09:31, Tim D=C3=BC=
sterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</a>&gt; wr=
ote:</div><div class=3D"gmail_quote gmail_quote_container"><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">Hi<br>
<br>
Am 2026-01-22 19:28, schrieb Barel:<br>
&gt; Following a comment by Tim D=C3=BCsterhus (thanks!) and another commen=
t in <br>
&gt; the<br>
&gt; PR, I have inverted the order of the parameters in the ensure and <br>
&gt; remove<br>
&gt; functions, so that they follow the parameter order in related function=
s<br>
&gt; like str_contains() and str_starts_with()<br>
<br>
Thank you. I have given the RFC another look and have some polishing <br>
comments:<br>
<br>
1. In the =E2=80=9CExact semantics (per function)=E2=80=9D example it would=
 probably be <br>
easier to understand if you would provide a userland implementation. <br>
Folks are already used to reading PHP and there is no ambiguity about <br>
the proposed behavior then. As a benefit, the implementation from the <br>
RFC would directly be usable as a polyfill, e.g. for use in <br>
<a href=3D"https://github.com/symfony/polyfill" rel=3D"noreferrer" target=
=3D"_blank">https://github.com/symfony/polyfill</a>. The previous =E2=80=9C=
array_find=E2=80=9D RFC might <br>
be a good example here: <a href=3D"https://wiki.php.net/rfc/array_find" rel=
=3D"noreferrer" target=3D"_blank">https://wiki.php.net/rfc/array_find</a><b=
r>
<br>
2. In the =E2=80=9CBackwards Incompatible Changes=E2=80=9D section: Can you=
 please <br>
perform some research for a rough number estimation? e.g. using GitHub&#39;=
s <br>
code search.<br>
<br>
------<br>
<br>
Another thing I realized is the interaction between the `_replace` <br>
functions and PFA: It can be used as an (inefficient?) way of creating a <b=
r>
concat as a function handle: `$concat =3D str_prefix_replace(&quot;&quot;, =
?, ?);` <br>
(with suffix_replace being a reverse concat).<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br><div>Tim, thanks for your sugge=
stions, I updated the RFC</div><div><br></div><div>Cheers<br><br></div>Carl=
os=C2=A0=C2=A0</div></div></div>

--000000000000c0f25106490bab53--