Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129840
Precedence: list
MIME-Version: 1.0
Date: Thu, 22 Jan 2026 09:38:25 +0100
To: Barel <barel.barelon@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] Check RFC draft
In-Reply-To: <CABVsipjN13-mZS2s=CtTVC6u70MT+zx73v9KOdt+jupV=XQdkg@mail.gmail.com>
References: <CABVsipjN13-mZS2s=CtTVC6u70MT+zx73v9KOdt+jupV=XQdkg@mail.gmail.com>
Message-ID: <68d0ebaf56276d8305fd04efe8e57324@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2026-01-22 09:01, schrieb Barel:
> I just created this RFC draft
> https://wiki.php.net/rfc/prefix_suffix_functions
> 
> Given that this is my first RFC I would like to ask if it would be 
> possible
> for someone to take a quick look to see if the format/overall content
> structure is correct or if there is anything that needs to be changed
> before I move it to the discussion process

You carefully followed the suggested template and provided extensive 
explanation of possible edge cases and also meaningful example use 
cases. I don't see anything that needs changes structure-wise or 
anything important missing. The formatting in “Edge cases and potential 
gotchas” is a little broken, instead of the bold bullet points it 
probably makes sense to add further sub-headings.

One note to the implementation: I believe the `_ensure` and `_remove()` 
functions should be “haystack first“ for consistency (i.e. first the 
target string, then the prefix/suffix).

Best regards
Tim Düsterhus