Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129663
Precedence: list
MIME-Version: 1.0
References: <CAGBsUrcKTcCzf5k_tGbk=cr02NrsEKPE=Y+CeSOqMrrdjKFftg@mail.gmail.com>
 <23051439-6f0d-4175-b632-3b943582bfe0@beccati.com> <CAGBsUrfwRdKj=i3xQeMx+kJ-_=g1Db0D-mBpxhTeRC56kVZPxw@mail.gmail.com>
 <CAJmy8YEZmC0yEA_QyJnj4TGS1quXqV2MfaUsVQSeXSzkNXsBuA@mail.gmail.com>
In-Reply-To: <CAJmy8YEZmC0yEA_QyJnj4TGS1quXqV2MfaUsVQSeXSzkNXsBuA@mail.gmail.com>
Date: Sat, 20 Dec 2025 09:28:14 +1000
Message-ID: <CAKVXxD_x6Ju2vFh9VHdMEyDaK6RnaB7QK+QeufcW+EQGu7BLTg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] New function mysqli_quote_string
To: Hans Henrik Bergan <divinity76@gmail.com>
Cc: Kamil Tekiela <tekiela246@gmail.com>, Matteo Beccati <php@beccati.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001ff4c10646566f06"
From: mickmackusa@gmail.com (mickmackusa)

--0000000000001ff4c10646566f06
Content-Type: text/plain; charset="UTF-8"

> btw pg_escape_literal is mis-named. it does not escape - it quotes.
> And there is an important difference between escaping and quoting,
> at least for SQLite, it is impossible to make a binary-safe escape()
> function,
> but it's fully possible to make a binary-safe quote() function
> (see https://github.com/php/php-src/pull/13972 )
>
> IMO  pg_escape_literal should be renamed pg_quote_literal.
>

A deviation, but this triggers my naming concern with preg_quote(). It
doesn't quote anything, it escapes things; and it should be able to process
an array of strings! I dream of a future with a robust preg_escape() in it.

mickmackusa

>

--0000000000001ff4c10646566f06
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div class=3D"gmail_quote gmail_quote_container" dir=3D"a=
uto"><div dir=3D"ltr" class=3D"gmail_attr"><br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-l=
eft:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div>btw pg_escape_lit=
eral is mis-named. it does not escape - it quotes.=C2=A0<br></div><div>And =
there is an important difference between escaping and quoting,</div><div>at=
 least for SQLite, it is impossible to make a binary-safe escape() function=
,</div><div>but it&#39;s fully=C2=A0possible to make a binary-safe quote() =
function<br></div><div>(see=C2=A0<a href=3D"https://github.com/php/php-src/=
pull/13972" target=3D"_blank" rel=3D"noreferrer">https://github.com/php/php=
-src/pull/13972</a> )</div><div><br></div><div>IMO=C2=A0
pg_escape_literal should be renamed pg_quote_literal.</div></div></div></bl=
ockquote></div><div dir=3D"auto"><br></div><div dir=3D"auto">A deviation, b=
ut this triggers my naming concern with preg_quote(). It doesn&#39;t quote =
anything, it escapes things; and it should be able to process an array of s=
trings! I dream of a future with a robust preg_escape() in it.</div><div di=
r=3D"auto"><br></div><div dir=3D"auto">mickmackusa</div><div class=3D"gmail=
_quote gmail_quote_container" dir=3D"auto"><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div>

--0000000000001ff4c10646566f06--