Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129661
Message-ID: <71b9ae2a-4313-475d-b733-4b0f3444c0d4@varteg.nz>
Date: Sat, 20 Dec 2025 11:38:21 +1300
Precedence: list
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] New function mysqli_quote_string
To: internals@lists.php.net
References: <CAGBsUrcKTcCzf5k_tGbk=cr02NrsEKPE=Y+CeSOqMrrdjKFftg@mail.gmail.com>
 <23051439-6f0d-4175-b632-3b943582bfe0@beccati.com>
 <CAGBsUrfwRdKj=i3xQeMx+kJ-_=g1Db0D-mBpxhTeRC56kVZPxw@mail.gmail.com>
 <CAJmy8YEZmC0yEA_QyJnj4TGS1quXqV2MfaUsVQSeXSzkNXsBuA@mail.gmail.com>
Content-Language: en-GB
In-Reply-To: <CAJmy8YEZmC0yEA_QyJnj4TGS1quXqV2MfaUsVQSeXSzkNXsBuA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: Weedpacket@varteg.nz (Morgan)

On 2025-12-20 04:09, Hans Henrik Bergan wrote:
> 
> 
> 
> btw pg_escape_literal is mis-named. it does not escape - it quotes.
> And there is an important difference between escaping and quoting,
> at least for SQLite, it is impossible to make a binary-safe escape() 
> function,
> but it's fully possible to make a binary-safe quote() function
> (see https://github.com/php/php-src/pull/13972 <https://github.com/php/ 
> php-src/pull/13972> )
> 
> IMO pg_escape_literal should be renamed pg_quote_literal.
 >
quote_literal() is how PostgreSQL itself names the function, and it 
would be consistent with PHP's functions being named to reflect those 
that it wraps (à la mysqli_real_escape_string()).

Instead, I think it got called pg_escape_string() by symmetry with 
mysql_escape_string().