Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:12961
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Cc: internals@lists.php.net
References: <1095938130.8750.204986086@webmail.messagingengine.com>
   <578268372.20040923210701@marcus-boerger.de>
   <1096010415.7706.205059081@webmail.messagingengine.com>
In-Reply-To: <1096010415.7706.205059081@webmail.messagingengine.com>
To: "Kamesh Jayachandran" <kameshj@fastmail.fm>,
	"Marcus Boerger" <helly@php.net>
Date: Fri, 24 Sep 2004 01:36:19 -0700
Message-ID: <1096014979.12206.205062371@webmail.messagingengine.com>
Subject: Re: [PHP-DEV] [PATCH] tests/classes/factory_and_singleton_009.phpt
From: kameshj@fastmail.fm ("Kamesh Jayachandran")

Hi Marcus,

Found the cause of the problem.

getSectionText function in run-tests2.php is trimming the each
sectiontext values except for POST.

This trimming causes the eol character in the phpt file to get lost when
saved to a php file.

Should we have to remove the trim function? or fix our testcases or
run-tests.php?

Please advise.

With regards
Kamesh Jayachandran

On Fri, 24 Sep 2004 00:20:15 -0700, "Kamesh Jayachandran"
<kameshj@fastmail.fm> said:
> Hi Marcus,
> 
> For me also this test is going through if I run the test using
> run-tests.php.
> 
> But it fails with run-tests2.php
> 
> With run-tests2.php
> I could see the output from the execute function itself was lacking that
> one new line character that exists between
> ===DONE=== and the actual waring line.
> 
> The only difference I could see is the way the php
> factory_and_singleton_009.php
> 
> In run-tests.php
> All the -d option value pairs are enclosed by double quote
> has extra options -d "xdebug.default_enable=0" -d "session.auto_start=0"
> runs the script with -f option.
> 
> With regards
> Kamesh Jayachandran
> On Thu, 23 Sep 2004 21:07:01 +0200, "Marcus Boerger" <helly@php.net>
> said:
> > Hello Kamesh,
> > 
> >  doesn't work for me. And if you were right we would see those tests
> >  FAILing
> > in all php 5 test reports. There must be another problem.
> > 
> > regards
> > marcus
> > 
> > Thursday, September 23, 2004, 1:15:30 PM, you wrote:
> > 
> > > Hi Helly,
> > > I had the tests/classes/factory_and_singleton_009.phpt testcase failing
> > > in Linux, NetWare, Windows ports of PHP.
> > > And found that this failure is due to one extra line.
> > 
> > > Attached the patch.
> > 
> > > Similar issue exists in tests/classes/factory_and_singleton_010.phpt
> > 
> > > Actually after ===DONE=== newline preceded in warning message brings the
> > > cursor to next immedeate line with a warning message. So expecting one
> > > more new line between ===DONE=== and warning message is incorrect.
> > 
> > > Correct me if I am wrong.
> > 
> > > If I am correct can I go ahead and commit it.
> > 
> > > With regards
> > > Kamesh Jayachandran 
> > 
> > 
> > 
> > -- 
> > Best regards,
> >  Marcus                            mailto:helly@php.net
> > 
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>