Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129573
Date: Tue, 9 Dec 2025 12:06:26 +0000 (GMT)
To: =?UTF-8?Q?M=C3=A1t=C3=A9_Kocsis?= <kocsismate90@gmail.com>
cc: PHP Internals List <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Followup Improvements for ext/uri
In-Reply-To: <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
Message-ID: <83238ad3-c844-4457-dfb3-11321787e022@php.net>
References: <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1445357481-1765281986=:29692"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1445357481-1765281986=:29692
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 1 Dec 2025, M=C3=A1t=C3=A9 Kocsis wrote:

> I'd like to introduce my latest RFC that I've been working on for a=20
> while now: https://wiki.php.net/rfc/uri_followup.
>=20
> It proposes 5 followup improvements for ext/uri in the following areas:
> - URI Building

Would it make sense to have an interface for the set*() methods? Besides=20
build(), they all seem to have the same API.

> - Query Parameter Manipulation

I see this adds NoDiscard:
#[\NoDiscard(message: "as Uri\Rfc3986\Uri::withQueryParams() does not modif=
y the object itself")]

But the original methods on the classes don't have these NoDiscards, and=20
it doesn't seem that this RFC is suggesting to add them. It should at=20
least be consistent.

> - Accessing Path Segments as an Array

Compare:

"especially considering the fact that Uri\Rfc3986\Uri internally stores=20
the path as a list of segments."

And:

Uri\Rfc3986\Uri::withPathSegments() =E2=80=A6 internally concatenate the in=
put=20
segments separated by a / character, and then trigger=20
Uri\Rfc3986\Uri::withPath() =E2=80=A6

Why does it need to do this concattenation, and then call withPath() for=20
Rfc3986\Uri then?

cheers,
Derick

--=20
https://derickrethans.nl | https://xdebug.org | https://dram.io

Author of Xdebug. Like it? Consider supporting me: https://xdebug.org/suppo=
rt

mastodon: @derickr@phpc.social @xdebug@phpc.social
--8323329-1445357481-1765281986=:29692--