Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129515
Feedback-ID: i8414410d:Fastmail
Precedence: list
MIME-Version: 1.0
Date: Tue, 02 Dec 2025 14:38:09 -0600
To: "php internals" <internals@lists.php.net>
Message-ID: <0081d8ac-6520-4a32-8ea5-5e10086e34e3@app.fastmail.com>
In-Reply-To: 
 <CAOV5rgYLush5cqYCct6yKqtQ-qXBGH8Lb5z5cZS4emw_kuuT=g@mail.gmail.com>
References: 
 <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
 <9873b03e-1260-44b3-8285-af9511d8766e@app.fastmail.com>
 <CAOV5rgYLush5cqYCct6yKqtQ-qXBGH8Lb5z5cZS4emw_kuuT=g@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Followup Improvements for ext/uri
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Dec 1, 2025, at 4:53 PM, ignace nyamagana butera wrote:
> Hi Larry, 
>
>>  - Url::isSpecial() Could we come up with a better name here?  "Special" could mean anything unless you know the RFC; it feels like "real escape string" all over again.This comes from the WHATWG specification the isSpecial is how it is named there 

I realize that, but the vast majority of PHP devs won't have read the official spec so don't know what "special" means.  Special in what way?  The scheme, the path, the encoding?  It's completely non-obvious unless you're versed in the specification, which, again, most people won't be.

>> It really feels like there's an interface to extract here from the Url/UriBuilder classes.  There's literally only one type-specific method (build()).
> Yes but the return type is not always the same object (Uri and Url are 
> different so I would be incline not adding a useless interface they are 
> similar yet different)

So the interface doesn't cover build().  Problem solved.

>> - Why both Uri getRawQueryParams() and getQueryParams()?  It looks like they would return the same value, no?  (If not, that should be explained.)
> Because Uri\Rfc3986\Uri already exposes Uri::getQuery and Uri::getRawQuery.

Then the RFC needs to explain why we need to have both for the query params, and how they differ.  Right now, there's no explanation of how they differ, and the example suggests that they'd return identical values.  

--Larry Garfield