Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129511
Precedence: list
MIME-Version: 1.0
References: <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
In-Reply-To: <CAH5C8xXUPKgd0wWwLC3G2Ye=kRZN58gK3DY82v5GoduBNNtb5A@mail.gmail.com>
Date: Tue, 2 Dec 2025 15:30:28 +0100
Message-ID: <CAOV5rgZZO5raL2mwXTh8AW6TDu=edCY-4n2GTscPJvfmdwhM9Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Followup Improvements for ext/uri
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>, 
	PHP Internals List <internals@lists.php.net>, =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Content-Type: multipart/alternative; boundary="00000000000097dbca0644f8f0f5"
From: nyamsprod@gmail.com (ignace nyamagana butera)

--00000000000097dbca0644f8f0f5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi M=C3=A0t=C3=A9,

I read the Accessing Path Segments as an Array sub RFC and I have a couple
of remarks, suggestions.
In the RFC text it is said that:

> The getter methods return null if the path is empty (https://example.com)=
,
an empty array when the path
> consists of a single slash (https://example.com/), and a non-empty array
otherwise.

This is suboptimal to me because it means that the signature for the getter
methods is `array|null` which would lead
developers to always add a check in the code whenever using the method to
distinguish the path state absolute or not.
Instead, I would rather always get a single type, the array as return
value. The issue you are facing is that
you want to convey via your return type if the path is absolute or not.
But, we already have access to this
information via the UriType Enum, at least in the case of the
Uri\Rfc3986\Uri class. For the Uri\WhatWg\Uri
the information is less crucial as the validation and normalization rules
of the WHATWG specifications
will autocorrect the path if needed. This leads me to propose the following
alternative:

For Uri\Rfc3986\Uri:

```
/** @return list<string> */
Uri::getPathSegments(): array {}
/** @return list<string> */
Uri::getRawPathSegments(): array {}
#[\NoDiscard(message: "as Uri\Rfc3986\Uri::withPathSegments() does not
modify the object itself")]
Uri::withPathSegments(array $segments, Uri\Rfc3986\UriType $uriType =3D
Uri\Rfc3986\UriType::RelativePathReference): static {}
```
(the default value for the `$uriType` parameter is TBD).

For Uri\WhatWg\Url:

```
/** @return list<string> */
Url::getPathSegments(): array {}
#[\NoDiscard(message: "as Uri\WhatWg\Url::withPathSegments() does not
modify the object itself")]
/**  @param list<UrlValidationError> $errors */
Url::withPathSegments(array $segments): static {}
```

with the following behaviour


*The getter methods return the empty array if the path is empty
(https://example.com <https://example.com>), or a single slash
(https://example.com/ <https://example.com/>),and a non-empty array
otherwise.* To distinguish between an absolute path and a relative path you
can refer to the Uri\Rfc3986\Uri::getUriType(),
method, in case of RFC 3986 URI, and the information does not matter
otherwise (ie: for WHATWG URL).

During update, for RFC 3986 URI, The additional `$uriType` argument would
serve to tell if a `/` should be prepended or not to the generated
string path. For the WHATWG URL, no soft errors are emitted, which show
that the starting slash does not really matter.

Best regards,
Ignace

On Mon, Dec 1, 2025 at 9:53=E2=80=AFPM M=C3=A1t=C3=A9 Kocsis <kocsismate90@=
gmail.com> wrote:

> Hi Everyone,
>
> I'd like to introduce my latest RFC that I've been working on for a while
> now: https://wiki.php.net/rfc/uri_followup.
>
> It proposes 5 followup improvements for ext/uri in the following areas:
> - URI Building
> - Query Parameter Manipulation
> - Accessing Path Segments as an Array
> - Host Type Detection
> - URI Type Detection
> - Percent-Encoding and Decoding Support
>
> I did my best to write an RFC that was at least as extensive as
> https://wiki.php.net/rfc/url_parsing_api had become by the end. Despite
> my efforts,
> there are still a couple things which need a final decision, or which
> need to be polished/improved. Some examples:
>
> - How to support array/object values for constructing query strings? (
> https://wiki.php.net/rfc/uri_followup#type_support)
> - How to make the UriQueryParams and UrlQueryParams classes more
> interoperable with the query string component (mainly with respect to
> percent-encoding)? (
> https://wiki.php.net/rfc/uri_followup#percent-encoding_and_decoding)
> - Exactly how the advanced percent-decoding capabilities should work? Doe=
s
> it make sense to support all the possible modes (UriPercentEncodingMode)
> for percent-decoding as well (
> https://wiki.php.net/rfc/uri_followup#percent-encoding_and_decoding_suppo=
rt
> )
> - etc.
>
> Regards,
> M=C3=A1t=C3=A9
>

--00000000000097dbca0644f8f0f5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi M=C3=A0t=C3=A9,<br><br>I read the Accessing Path Segmen=
ts as an Array sub RFC and I have a couple of remarks, suggestions.<br>In t=
he RFC text it is said that:<br><br>&gt; The getter methods return null if =
the path is empty (<a href=3D"https://example.com">https://example.com</a>)=
, an empty array when the path<br>&gt; consists of a single slash (<a href=
=3D"https://example.com/">https://example.com/</a>), and a non-empty array =
otherwise.<br><br>This is suboptimal to me because it means that the signat=
ure for the getter methods is `array|null` which would lead<br>developers t=
o always add a check in the code whenever using the method to distinguish t=
he path state absolute or not.<br>Instead, I would rather always get a sing=
le type, the array as return value. The issue you are facing is that<br>you=
 want to convey via your return type if the path is absolute or not. But, w=
e already have access to this<br>information via the UriType Enum, at least=
 in the case of the Uri\Rfc3986\Uri class. For the Uri\WhatWg\Uri<br>the in=
formation is less crucial as the validation and normalization rules of the =
WHATWG specifications<br>will autocorrect the path if needed. This leads me=
 to propose the following alternative:<br><br>For Uri\Rfc3986\Uri:<br><br>`=
``<br>/** @return list&lt;string&gt; */<br>Uri::getPathSegments(): array {}=
<br>/** @return list&lt;string&gt; */<br>Uri::getRawPathSegments(): array {=
}<br>#[\NoDiscard(message: &quot;as Uri\Rfc3986\Uri::withPathSegments() doe=
s not modify the object itself&quot;)]<br>Uri::withPathSegments(array $segm=
ents, Uri\Rfc3986\UriType $uriType =3D Uri\Rfc3986\UriType::RelativePathRef=
erence): static {}<br>```<br>(the default value for the `$uriType` paramete=
r is TBD).<br><br>For Uri\WhatWg\Url:<br><br>```<br>/** @return list&lt;str=
ing&gt; */<br>Url::getPathSegments(): array {}<br>#[\NoDiscard(message: &qu=
ot;as Uri\WhatWg\Url::withPathSegments() does not modify the object itself&=
quot;)]<br>/** =C2=A0@param list&lt;UrlValidationError&gt; $errors */<br>Ur=
l::withPathSegments(array $segments): static {}<br>```<br><br>with the foll=
owing behaviour<br><br><b>The getter methods return the empty array if the =
path is empty (<a href=3D"https://example.com">https://example.com</a>), or=
 a single slash (<a href=3D"https://example.com/">https://example.com/</a>)=
,<br>and a non-empty array otherwise.</b> To distinguish between an absolut=
e path and a relative path you can refer to the Uri\Rfc3986\Uri::getUriType=
(),<br>method, in case of RFC 3986 URI, and the information does not matter=
 otherwise (ie: for WHATWG URL).<br><br>During update, for RFC 3986 URI, Th=
e additional `$uriType` argument would serve to tell if a `/` should be pre=
pended or not to the generated<br>string path. For the WHATWG URL, no soft =
errors are emitted, which show that the starting slash does not really matt=
er.<br><br>Best regards,<br>Ignace</div><br><div class=3D"gmail_quote gmail=
_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Dec 1, 2025=
 at 9:53=E2=80=AFPM M=C3=A1t=C3=A9 Kocsis &lt;<a href=3D"mailto:kocsismate9=
0@gmail.com">kocsismate90@gmail.com</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Everyone,<div><br></=
div><div>I&#39;d like to introduce my latest RFC that I&#39;ve been working=
 on for a while now: <a href=3D"https://wiki.php.net/rfc/uri_followup" targ=
et=3D"_blank">https://wiki.php.net/rfc/uri_followup</a>.</div><div><br></di=
v><div>It proposes 5=C2=A0followup=C2=A0improvements for ext/uri in the fol=
lowing areas:</div><div>- URI Building<br>- Query Parameter Manipulation<br=
>- Accessing Path Segments as an Array<br>- Host Type Detection<br>- URI Ty=
pe Detection<br>- Percent-Encoding and Decoding Support</div><div><br></div=
><div>I did my best to write an RFC that was at least as extensive as=C2=A0=
<a href=3D"https://wiki.php.net/rfc/url_parsing_api" target=3D"_blank">http=
s://wiki.php.net/rfc/url_parsing_api</a> had become by the end. Despite my =
efforts,</div><div>there are still a couple things which need=C2=A0a final =
decision, or which need=C2=A0to be polished/improved. Some examples:</div><=
div><br></div><div>- How to support array/object values for constructing qu=
ery strings? (<a href=3D"https://wiki.php.net/rfc/uri_followup#type_support=
" target=3D"_blank">https://wiki.php.net/rfc/uri_followup#type_support</a>)=
</div><div>- How to make the UriQueryParams and=C2=A0UrlQueryParams classes=
 more interoperable with the query string component (mainly with respect to=
 percent-encoding)? (<a href=3D"https://wiki.php.net/rfc/uri_followup#perce=
nt-encoding_and_decoding" target=3D"_blank">https://wiki.php.net/rfc/uri_fo=
llowup#percent-encoding_and_decoding</a>)</div><div>- Exactly how the advan=
ced percent-decoding capabilities should work? Does it make sense to suppor=
t all the possible modes (UriPercentEncodingMode) for percent-decoding as w=
ell (<a href=3D"https://wiki.php.net/rfc/uri_followup#percent-encoding_and_=
decoding_support" target=3D"_blank">https://wiki.php.net/rfc/uri_followup#p=
ercent-encoding_and_decoding_support</a>)</div><div>- etc.</div><div><br></=
div><div>Regards,</div><div>M=C3=A1t=C3=A9</div></div>
</blockquote></div>

--00000000000097dbca0644f8f0f5--