Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12951 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72406 invoked by uid 1010); 23 Sep 2004 19:05:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 72372 invoked from network); 23 Sep 2004 19:05:02 -0000 Received: from unknown (HELO jan.prima.de) (83.97.50.139) by pb1.pair.com with SMTP; 23 Sep 2004 19:05:02 -0000 Received: from BAUMBART (p508EA07E.dip.t-dialin.net [::ffff:80.142.160.126]) (IDENT: HydraIRC, AUTH: LOGIN tobi) by jan.prima.de with esmtp; Thu, 23 Sep 2004 19:05:00 +0000 Date: Thu, 23 Sep 2004 21:07:01 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <578268372.20040923210701@marcus-boerger.de> To: Kamesh Jayachandran CC: internals@lists.php.net In-Reply-To: <1095938130.8750.204986086@webmail.messagingengine.com> References: <1095938130.8750.204986086@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] tests/classes/factory_and_singleton_009.phpt From: helly@php.net (Marcus Boerger) Hello Kamesh, doesn't work for me. And if you were right we would see those tests FAILing in all php 5 test reports. There must be another problem. regards marcus Thursday, September 23, 2004, 1:15:30 PM, you wrote: > Hi Helly, > I had the tests/classes/factory_and_singleton_009.phpt testcase failing > in Linux, NetWare, Windows ports of PHP. > And found that this failure is due to one extra line. > Attached the patch. > Similar issue exists in tests/classes/factory_and_singleton_010.phpt > Actually after ===DONE=== newline preceded in warning message brings the > cursor to next immedeate line with a warning message. So expecting one > more new line between ===DONE=== and warning message is incorrect. > Correct me if I am wrong. > If I am correct can I go ahead and commit it. > With regards > Kamesh Jayachandran -- Best regards, Marcus mailto:helly@php.net