Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12946 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16913 invoked by uid 1010); 23 Sep 2004 11:15:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 16810 invoked from network); 23 Sep 2004 11:15:30 -0000 Received: from unknown (HELO frontend1.messagingengine.com) (66.111.4.30) by pb1.pair.com with SMTP; 23 Sep 2004 11:15:30 -0000 Received: from web1.messagingengine.com (web1.internal [10.202.2.210]) by frontend1.messagingengine.com (Postfix) with ESMTP id 772F3C156EA; Thu, 23 Sep 2004 07:15:30 -0400 (EDT) Received: by web1.messagingengine.com (Postfix, from userid 99) id CAE865E3; Thu, 23 Sep 2004 07:15:30 -0400 (EDT) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_109593813087500"; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.5 (F2.73; T1.001; A1.62; B3.01; Q3.01) To: internals@lists.php.net, helly@php.net Date: Thu, 23 Sep 2004 04:15:30 -0700 X-Sasl-Enc: JWuH49KsKl1ETGbb4gVw9g 1095938130 Message-ID: <1095938130.8750.204986086@webmail.messagingengine.com> Subject: [PATCH] tests/classes/factory_and_singleton_009.phpt From: kameshj@fastmail.fm ("Kamesh Jayachandran") --_----------=_109593813087500 Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.5 (F2.73; T1.001; A1.62; B3.01; Q3.01) Date: Thu, 23 Sep 2004 11:15:30 UT Hi Helly, I had the tests/classes/factory_and_singleton_009.phpt testcase failing in Linux, NetWare, Windows ports of PHP. And found that this failure is due to one extra line. Attached the patch. Similar issue exists in tests/classes/factory_and_singleton_010.phpt Actually after ===DONE=== newline preceded in warning message brings the cursor to next immedeate line with a warning message. So expecting one more new line between ===DONE=== and warning message is incorrect. Correct me if I am wrong. If I am correct can I go ahead and commit it. With regards Kamesh Jayachandran --_----------=_109593813087500 Content-Disposition: attachment; filename="factory_and_singleton_009.phpt.patch" Content-Transfer-Encoding: base64 Content-Type: text/plain; name="factory_and_singleton_009.phpt.patch" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.5 (F2.73; T1.001; A1.62; B3.01; Q3.01) Date: Thu, 23 Sep 2004 11:15:30 UT LS0tIGZhY3RvcnlfYW5kX3NpbmdsZXRvbl8wMDkucGhwdAkyMDAzLTEyLTI4 IDIzOjMzOjA2LjAwMDAwMDAwMCArMDUzMAorKysgZmFjdG9yeV9hbmRfc2lu Z2xldG9uXzAwOS5waHB0Lm53CTIwMDQtMDctMjIgMTI6MjU6NTYuMDAwMDAw MDAwICswNTMwCkBAIC0xNyw1ICsxNyw0IEBACiA9PT1ET05FPT09CiAtLUVY UEVDVEYtLQogPT09RE9ORT09PQotCiBXYXJuaW5nOiBDYWxsIHRvIHByb3Rl Y3RlZCB0ZXN0OjpfX2Rlc3RydWN0KCkgZnJvbSBjb250ZXh0ICcnIGR1cmlu ZyBzaHV0ZG93biBpZ25vcmVkIGluIFVua25vd24gb24gbGluZSAwCg== --_----------=_109593813087500--