Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129352
Content-Type: multipart/alternative;
 boundary="------------FWI4PZLxfe0CaosmmXztEnic"
Message-ID:
 <AM8P250MB01704BC0481FB6DAB0482267E2D5A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Date: Fri, 21 Nov 2025 02:57:21 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Stream Error Handling Improvements
To: Jakub Zelenka <bukka@php.net>
Cc: PHP internals list <internals@lists.php.net>
References: <CAEKnhAEO8w0GJXTVyH_nwK8nGQGdJcNNkGOPMnYDVrcsNGrm4A@mail.gmail.com>
 <AM8P250MB0170998214C5628937E7AAF7E2D7A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <CAEKnhAFAnavL3y2U-jUgCJmCj0Qjm336nLM1U0_VTBXxe8dbYg@mail.gmail.com>
 <AM8P250MB017037F95CF2606FF17F0A7FE2D7A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <CAEKnhAE10uHsaVgAAL9GPFk2UYk40TVjsq9ORuOhqSnEoyjrGQ@mail.gmail.com>
 <AM8P250MB0170F502514B9DF15CC897FFE2D4A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <CAEKnhAHt-B-bUKgWdKQ4uRDJX8xY7VKVOZGabV8ZNcKiXxAQQg@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAEKnhAHt-B-bUKgWdKQ4uRDJX8xY7VKVOZGabV8ZNcKiXxAQQg@mail.gmail.com>
Precedence: list
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM8P250MB0170:EE_|GV2P250MB0875:EE_
X-MS-Office365-Filtering-Correlation-Id: 8022cccd-1995-42d3-1e1a-08de28a14f58
X-MS-Exchange-SLBlob-MailProps:
	9IecXKUgicCO8OP9JSHQ+xjWRIebUMjRbJUvapYNmxbm5vU2JthxwMN31wF9tNdCQeHgBag4sOqjctcQRg/mZUvr0iW1y/uYxvwff4fq9SXbNC0eiHzHogNAmhL/UXTXiJHiJxzTXwSjPIrIg8V4yJGN4/69dCGvYWOUZTHHVQoaUMgQKZYPVKQB9MXgNyV+JMuF5TPaKUDkO19v8/jPSARYYh2YskzjoGzaDFNdW3AqsocH6oQijayYHVXNBXQhsEQZnpPWVmcXWTGYDqLTO6SnANKDbXWcYqm+plpJbh4+fumlnm/D4UXaV/fSeZpmbotwc1lYvT3m9QMpj7FsS5JoBDMiRXjI6Mvt6c2PRDyCa5hRIzA+MfYAryIuV4F2rHRsmRoXVfV0xsGueAIB2rwFZGXtSaiBin4DJirmUt4+xn4VOf6iitxVaMxVDvAhggjEh4Z/Ao0DJ2kUwbR1Q+7MkWzEiZmuR/Z3DMQYVPnozTR9t4Pn5bLFIqINPR9Qe281m291us+a4RErwkBR5CDFqt+c/Pn6o0qHCtI3CwOEFXgiExGS0Tx22nXnUvYCLtJE5EgvIYuFvwILhs/HcoyuEwU5JvaFCldX9neIaZbliPLJE6pgQcrjnOgPzEbnHPHva2xFxPmbbptoWGRIF3aCFyoBLuMn1tTXgH0f8x6hkF8VswgdijvuSF8e4PMdbLLkz2tOdwt8WWug2zcrNpJJOBKCM04ASh0AxM0G9U9fEniItOzaog==
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|12121999013|23021999003|8060799015|5072599009|19110799012|461199028|15080799012|51005399006|40105399003|3412199025|440099028|26104999006;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?WHlIaWk4RzBNejBzaExSVVBWSCtsS2R1MWNaRVlmQmdkYUZhNFE3SzZQSC8r?=
 =?utf-8?B?V0V1L0RSby84NUhiUTgwbmsrbDhtTkEvelpVc29abkJQUEFTaGFRMXNqRzlH?=
 =?utf-8?B?R3BOZkF4RVdsQ2VGMUNWd2FXQTJYWlJzVnhyTnluL3NpdDdIZkIzdXV4OFpj?=
 =?utf-8?B?MWdsbnY4ZFV3dTJWbjJrL3RqYVl6YTdPVmRUYWhSVnRjbmcxS1JTSnp4SHpL?=
 =?utf-8?B?TDR3RG9PQ1BqL2ZwOGFsbjBMN1RyWm5hTXdyV0NGMGRocVUwYWFmbDM3SExG?=
 =?utf-8?B?RXhWQS9RaEpyTUlDVFdNWFBQTjdPOXJLclZSYTNOK1J2MEVwdFlVTk1zbWxJ?=
 =?utf-8?B?S2N2enBnS21wMUR2WXQyUkRQdS9rTmkzU1ByaXBxUjJPakMwNXJjNEVmb3R1?=
 =?utf-8?B?Yk8ycEJjSlE1dWs0dC9EdHBJNGFDYkViYncrWTU2RUwwcXVHUm8yeDJGajZR?=
 =?utf-8?B?U0U1REhoT3V5UmJmRUkwd21EeFdWaWh6bXNUbkluakwxNUpiRFNmUUF6aWJv?=
 =?utf-8?B?T0hsK2VqOURVcEJ1cENDdWUxVHNncTcyeEFtRksrRWkzVTZrVWtVZTRUK1Ry?=
 =?utf-8?B?QXRLakVqcXljbzNNU2hGVzhqS3oxeHBBcW1vbmdQRGRNOWRJUk5GTDRCZVNC?=
 =?utf-8?B?NHM5L2szQ2NyTS9hTVVHb3ptUFlIRmpSYTFHaG1RNW0vdFdpNUxlNS9ocnov?=
 =?utf-8?B?Tm5zenRkL3c2WGtpRldTbDkxRHBKRFF6ajQzUElHSVl4WlpxMzRQN0xBdGJH?=
 =?utf-8?B?allMWW1Kcm5CMHcvTkRCenVOSUE4dGV1NTJXUGtuRWN3R3RaRlAraVliZUVw?=
 =?utf-8?B?ZkZ0QURkUDhNQ2hIOE9nTGhpUXZ4QVlMVTUrZkM3MUp1c1ZGdWVMVW9DREI0?=
 =?utf-8?B?RlJuQUdLRW14aXlmT1UxVTJpckNrbHMvNVdITWJQdVNON1cycDVkYjd6WGp4?=
 =?utf-8?B?VHBrbFE2dkhyWHpXMnVLMExyVitXdzYzM1JYYkpidUZpTWtDTFBzdVVaUHpJ?=
 =?utf-8?B?cS9ycU01eW85eUlHUHh4K2piRDNEUyszenUyckNSQmRiMWg0blNPeEM0L2RU?=
 =?utf-8?B?dFNZSGhGOE9nMVBiS1RrZUNmVjEwZ2R0Z0xjYU9HQmVWaFZ1eldzakhoUzU0?=
 =?utf-8?B?SDAxN2hiNWdCaWFBbUpiM0dOd3JObTJKMGpvcUVDRHd6empCejN4Q2hGRSsv?=
 =?utf-8?B?QjhNRDdHTzlYdkVJbml6UEZkN1FvMkM3RUo1SWloV3JJQTdheTdaOWFwWHQ0?=
 =?utf-8?B?Q0V3QzNVLzlmRXRVb2I5U3crZHd4aTA0emN6ODV3K1c5bXVTcTBTdXEyODV5?=
 =?utf-8?B?WFpZMjFaNENOeHo5NjlzV0twcTNjby9VSmhqRFR6SmJsZEhkWHoxVDVkdXc1?=
 =?utf-8?B?RURuUFA1NlByQ3Y0cHV1aGd0bjZYK2VOaGkvbW02ZEQ4SFRJTURuK2RYN3pp?=
 =?utf-8?B?SzNjTjlmUTBoSkdhQVJFaTRIbFFVb2hENzMyYlBXUHlWczFvNHhkMG9EUmNV?=
 =?utf-8?B?Y2lZQXpkc21qSHBxdEZGUStMbW5RUGJzQk0zdmRMYS93U2NLaGhnNzIwd0xk?=
 =?utf-8?B?WGZ4Ym5nMEdOMGJuOHFPOGJSVnZuSU02VVRaWDJlbGRZNUlRVjRqbUVTYmYr?=
 =?utf-8?Q?E6WeMVOixRsasIAdQUbgHHWgqfAKRlq26UQpB6EQlU8k=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?blBPSTR1bUdabkh6SXBYOXFLeG9EczYweG03SStvQVRuSGxEM0RHUlFQZG1J?=
 =?utf-8?B?aUhEZC92eXpEZzlIUGVScDYxdWx4d2J3ZFdwOFRWUWFHMTZGNVJPd3RnYlFu?=
 =?utf-8?B?dzBJRm9yVkR1ZUpuY3BKM3cxVE1TeUxXL1dXUTQwK1QzRkpZb2xDdGsybith?=
 =?utf-8?B?bUhGM2tYME93c0M0ODQrTTkxVFZxYmFVVUVyNE5Sb1B3d0VoQ2hibWszMEF3?=
 =?utf-8?B?VzRHckc4di9VNG5ZbXN2bS8xeXBPZnNhYzhuYWU2ZUIrbkpTQkdia3RKTE1u?=
 =?utf-8?B?b1RzdXBsRmtuOFFYQm9NMXhMNmVvY2k0ZW5ST1JyeFlLM285RkJKaDM4Tmlo?=
 =?utf-8?B?K0Vma1JsQ3FxL21ZUXBWTk9ZWVVoWUxuNWNzd0o3SGhpTDU1OFp3QTJ5ZElT?=
 =?utf-8?B?QU91TjYybHJiQ0JPUXBvc3JzRGZldjNuWkdSMlI4alRISHNJNnRRNjlTUVhz?=
 =?utf-8?B?NlBvYTRvQnFYcDg1THZqU0xiMEdKNXIrejRJb0Z2VTlXWGZHWnhFaTVrV24x?=
 =?utf-8?B?S1FRamhmd1BTdEVJQytIeWhaakRYOUFlU0VlZGVFNTBhZWhyTm9jUGkybWlT?=
 =?utf-8?B?NThQZnNLMVIvcVBIRGhDcGs1K1NXNGJHWUxXdXNtR25RWnpkWklIeU1CT25U?=
 =?utf-8?B?blVyV1BNM2RwQWxNUlBlTlVzN2lkbTFaY3RYcFFZSkpyYzlqRmV2Y0tFTmxX?=
 =?utf-8?B?L3NzV3hNM1A1eGRtZ3BxZmRHc2h6TUI5KzZnQmFqcVBJUFY4eHFKOUlCR0xR?=
 =?utf-8?B?MGxxTG0zdVl2ZkNnTkJzV0ZWV1VoM2J6MjFESHJrbXVPb2pBSDJVQnF2a1Rh?=
 =?utf-8?B?SGs3dWN2cm5wQ0FFRjRxZnZNM3lGUDFkUFA5cys4RndsR0JUMFpKdmJXMjZt?=
 =?utf-8?B?VGNkTFdNL0Z4WUl4T0JRRllNTCtLQkVvNXpRSndYWjhQei91UGxXTHAybW1h?=
 =?utf-8?B?YjRWY0duUkJHbXc3Q2hHbytGUVdkcHlRQ2Z0U09tZFI3WlEvd1l2bkdUUFZw?=
 =?utf-8?B?Z2hZU1E5UjVkRGcydHBIaGl5dzNMYjE2QWVORm9Ca3lraWFxYW5LRTMzOHBv?=
 =?utf-8?B?NlVsN3FlaVpzRXhSd2NGZCttVEw5RlBNT2tDNXVIcHR2enNXM3NQaGZSS2F2?=
 =?utf-8?B?ZXAwd3UvSnUwVlVkdzJsNllXUXl0N3lCcFdkNXorZVZkS01Ic0M4YmRmTlpU?=
 =?utf-8?B?d1hTVkk5RU9iOFJCcUlxTWZuaEROcHRDeUs0YjZNRHhoYXhPMGtmdUZmRWx6?=
 =?utf-8?B?cHVvU0E3ditQMDY2c01GazlYQ1pCZ2w1TUhpYzZTRmk5cWlYUEJuc2xYc1d0?=
 =?utf-8?B?WHB4TjZYY1RzSFE1RGRnMmEvOWdrRFhXNmx5NURqK0FtZGpXeUdmYmNtOGps?=
 =?utf-8?B?dnd2SkFjdVcrSTNUenVGa1pXUk9jSUk2a2Q3eEVrVDIzWmNCTE9XOUlKU0Zr?=
 =?utf-8?B?c21rUGJRREdYcTlENVQ1SHRaNmdWZlBFVUFjNWlUUHRiYzZYbldBQnN6eWk3?=
 =?utf-8?B?OThOQ3J2SkFsc3NteGh4NWlOK3VlQW9DVUFKWGZjSkoyNWFjRDAxY05xTjds?=
 =?utf-8?B?eHRJYXhzTnA1MmtGc2RyeXNXa1VEcWNZUnJ3YjduS3ltVEhsQXc3NU5sdjZs?=
 =?utf-8?B?bEdIcE1EaG9HRytxQzdqdW5EL0o0NlAvVkp5a2ZZRkt0eVlOVCttcWdmNEFk?=
 =?utf-8?B?Mm5KYm0zVVhaYW9zSnA1TFJGRWNlRmptQU9oUHRpZUZPc3ZyeXlsclU0VUUw?=
 =?utf-8?Q?vzrvfWDNU2lU0AU+ec=3D?=
X-OriginatorOrg: sct-15-20-8534-15-msonline-outlook-5f066.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 8022cccd-1995-42d3-1e1a-08de28a14f58
X-MS-Exchange-CrossTenant-AuthSource: AM8P250MB0170.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 01:57:22.2756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2P250MB0875
From: bobwei9@hotmail.com (Bob Weinand)

--------------FWI4PZLxfe0CaosmmXztEnic
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hey Jakub,

On 20.11.2025 13:03:08, Jakub Zelenka wrote:
>
>     My point here is that $code generally does not get used for our
>     Exceptions. Whenever we need to attach extra information to an
>     exception, we do it as extraneous properties. (That's what my
>     example with ErrorException was about.)
>
>     I.e. ignore the existence of $code (just assign zero).
>
>     And add an extra property for the StreamError enum (which now
>     needs no backing).
>
>     class StreamException extends Exception {
>         public __construct(
>             public StreamError $error,
>             public string $wrapperName,
>             string $message = "",
>             public string|null $param = "",
>             ?Throwable $previous = null
>         ) {
>             parent::__construct($message, 0, $previous);
>         }
>     }
>
>     Does this make more sense, described as code?
>
>
> As I see what you mean now. I would prefer to use StreamError name for 
> the class holding all the details including code, wrapper name, 
> message and param as proposed by Jordi because this could be also 
> passed to handler and retrieved from the stored errors. It just seems 
> not right to use StreamException as a container without being thrown 
> (is that done anywhere?) so I think separate class for handler and 
> stored errors (or single last error) seems cleaner. Although 
> StreamException would be then quite similar. I could pass StreamError 
> there as a property but then it would duplicate the message so not sure.
>
> In any case I think it's better to call that enum StreamErrorCode. I 
> will still find a clean way to map it to the defines 
> (STREAM_ERROR_CODE_* macros) because that's what I use internally to 
> set code in the error. So not using int value for the exception code 
> won't make that much difference from the implementation PoV.

I don't mind the name, whether you call it StreamError or 
StreamErrorCode. Or maybe call the class "StreamFailure" and the enum 
"StreamError"? Just a suggestion, I don't care too much about the actual 
names.

For the internal implementation, does it actually matter passing around 
an int value or a char pointer with the name? Which would allow you to 
directly pass it into the enum lookup. But yup, do whatever fits you 
best here :-)

(Ranty tangent: Umm, what's even the internal proper way to get an enum 
value? Manual zend_hash_find_ptr(CE_CONSTANTS_TABLE(ce), constant_name) 
including zend_update_class_constant()?! We ought to figure a way to 
create the internal enum case objects at compile time, then we could 
just reference them directly... Working with enums internally can be 
annoying and fetching *feels* slow (even if it's just a HashTable lookup).)


Bob

--------------FWI4PZLxfe0CaosmmXztEnic
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    <p>Hey Jakub,</p>
    <div class="moz-cite-prefix">On 20.11.2025 13:03:08, Jakub Zelenka
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:CAEKnhAHt-B-bUKgWdKQ4uRDJX8xY7VKVOZGabV8ZNcKiXxAQQg@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_quote gmail_quote_container">
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div>
              <p>My point here is that $code generally does not get used
                for our Exceptions. Whenever we need to attach extra
                information to an exception, we do it as extraneous
                properties. (That's what my example with ErrorException
                was about.)</p>
              <p>I.e. ignore the existence of $code (just assign zero).</p>
              <p>And add an extra property for the StreamError enum
                (which now needs no backing).</p>
              <p>class StreamException extends Exception {<br>
                &nbsp; &nbsp; public __construct(<br>
                &nbsp; &nbsp; &nbsp; &nbsp; public StreamError $error,<br>
                &nbsp; &nbsp; &nbsp; &nbsp; public string $wrapperName,<br>
                &nbsp; &nbsp; &nbsp; &nbsp; string $message = &quot;&quot;,<br>
                &nbsp; &nbsp; &nbsp; &nbsp; public string|null $param = &quot;&quot;,<br>
                &nbsp; &nbsp; &nbsp; &nbsp; ?Throwable $previous = null<br>
                &nbsp; &nbsp; ) {<br>
                &nbsp; &nbsp; &nbsp; &nbsp; parent::__construct($message, 0, $previous);<br>
                &nbsp; &nbsp; }<br>
                }</p>
              <p>Does this make more sense, described as code?</p>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>As I see what you mean now. I would prefer to use
            StreamError name for the class holding all the details
            including code, wrapper name, message and param as proposed
            by Jordi because this could be also passed to handler and
            retrieved from the stored errors. It just seems not right to
            use StreamException as a container without being thrown (is
            that done anywhere?) so I think separate class for handler
            and stored errors (or single last error) seems cleaner.
            Although StreamException would be then quite similar. I
            could pass StreamError there as a property but then it would
            duplicate the message so not sure.</div>
          <div><br>
          </div>
          <div>In any case I think it's better to call that enum
            StreamErrorCode. I will still find a clean way to map it to
            the defines (STREAM_ERROR_CODE_* macros) because that's what
            I use internally to set code in the error. So not using int
            value for the exception code won't make that much difference
            from the implementation PoV.</div>
        </div>
      </div>
    </blockquote>
    <p>I don't mind the name, whether you call it StreamError or
      StreamErrorCode. Or maybe call the class &quot;StreamFailure&quot; and the
      enum &quot;StreamError&quot;? Just a suggestion, I don't care too much about
      the actual names.</p>
    <p>For the internal implementation, does it actually matter passing
      around an int value or a char pointer with the name? Which would
      allow you to directly pass it into the enum lookup. But yup, do
      whatever fits you best here :-)</p>
    <p>(Ranty tangent:&nbsp;Umm, what's even the internal proper way to get
      an enum value? Manual zend_hash_find_ptr(CE_CONSTANTS_TABLE(ce),
      constant_name) including zend_update_class_constant()?!&nbsp;We ought
      to figure a way to create the internal enum case objects at
      compile time, then we could just reference them directly...
      Working with enums internally can be annoying and fetching *feels*
      slow (even if it's just a HashTable lookup).)</p>
    <p><br>
    </p>
    <p>Bob</p>
  </body>
</html>

--------------FWI4PZLxfe0CaosmmXztEnic--