Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129318
Content-Type: multipart/alternative;
 boundary="------------Llj1gKza5Qih8TAot0fQBQfG"
Message-ID:
 <AM8P250MB0170F502514B9DF15CC897FFE2D4A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Date: Thu, 20 Nov 2025 01:11:05 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Stream Error Handling Improvements
To: Jakub Zelenka <bukka@php.net>
Cc: PHP internals list <internals@lists.php.net>
References: <CAEKnhAEO8w0GJXTVyH_nwK8nGQGdJcNNkGOPMnYDVrcsNGrm4A@mail.gmail.com>
 <AM8P250MB0170998214C5628937E7AAF7E2D7A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <CAEKnhAFAnavL3y2U-jUgCJmCj0Qjm336nLM1U0_VTBXxe8dbYg@mail.gmail.com>
 <AM8P250MB017037F95CF2606FF17F0A7FE2D7A@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <CAEKnhAE10uHsaVgAAL9GPFk2UYk40TVjsq9ORuOhqSnEoyjrGQ@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAEKnhAE10uHsaVgAAL9GPFk2UYk40TVjsq9ORuOhqSnEoyjrGQ@mail.gmail.com>
Precedence: list
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM8P250MB0170:EE_|DU2PPF619620E44:EE_
X-MS-Office365-Filtering-Correlation-Id: c2afb971-f3fa-4089-1998-08de27c94d2d
X-MS-Exchange-SLBlob-MailProps:
	9IecXKUgicCO8OP9JSHQ+xjWRIebUMjRbJUvapYNmxbm5vU2JthxwE2/ATEbp+4TttGxidBtGfUt2+RJVUFJFIHmRpzHWMhnihglZv+/Al1JogFJUJMtYC0CyptnB7ETZySenXz53lV5T1w8dik5MmCQZqcoo9r552gk4s7t84hIyewtztNeNXHJjlBA1/LQO6P7NK+Hb67TebwQShUoHXPPWifavx/IgGgmw4kSQhkCgnPrniu5Kc5nbXMzTwXLYJ5ndcTGQgY/5aOTuU0fKfiDbaZXMQHFlfvMaRIT7948cQnVUIL7EWyDAPaVWDDURN8NLWfIehPp8ccVt55s2L5wE//pD+7JoxJMVDP3ro2DPoRMiEIMyScGu/SDS8vKuZz/xSqGCbfop9IwEH5AeBp17MP7MICxlLVsREnhknOqO7l177iq7rgPyyg55v3jFfVrRllX49gJ9qqP7BwKIwpgZWlOzRCw9S9SLfvRG1xPKRpm/LwcKj39MArhJqJA0Au943TWYebSE93KNHBB3STZ/H0MNbLqiJZf3kp6Rh66IvY6EGq/7jpXsNlHvo9CCPJU6Wu2nlRqRHPc59BWmBzdznyaCYeDu18ALzwet4o/NeB1c/MsZrAAvbz7zAkJKl7Q+hXpm/uQa0IvF+tW+Z+PwAP/eeqIsZQ4KJRiMt5abFoM9oVLUxMdBBUQ+Bjuh1phQFktY0za8Q0KPyJ5gIY4Sx6wGtTamtZLtHrP7IxGMeyM03k/+A==
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|51005399006|12121999013|8060799015|19110799012|5072599009|23021999003|15080799012|12050799012|461199028|40105399003|3412199025|440099028|26104999006;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?VzZpWEhhZW9VZWFCZVc4SkdmYlV6bHlCMzNTWXl1MHRvdDJLOFFuN2Evam43?=
 =?utf-8?B?TzZXZXR2ZDA5dUdUeHVpaFV1QTNPYXRBWm10aml4cE9hTU5wTElTVitLckV1?=
 =?utf-8?B?TUdpUHZ5SVFuL3I0NkhnSkY3SGJ5ZWRGQ2N2ZWRSejFLVnE2MlJCSDJ4ZXFD?=
 =?utf-8?B?SWtWNmJvYXY3cHhwRjkrSmxmRkdPQmRxZ3NKcENtV21SQW1qbGFLZlJHWDZC?=
 =?utf-8?B?UVI1ZmcyL25aTHJUSTRZTjcybXBYUUdWWHV5RnVwNm5uVG53ZTFCd2xFbEN0?=
 =?utf-8?B?QWt0V3l1WW8vclYyTXgwSG1FT2JQbWt2TytXdmdxOXl4MlNmby83bEVtMUhM?=
 =?utf-8?B?TmI2NGpIekpXNXU1aXJ0QmF4Qk1QUDNFTktOOTMrYUdFanZiRk9mTFAvblAz?=
 =?utf-8?B?OHQyVDc2VXJ0MERJVVdGQnF0MzVVWHp2Y25Sc0lUSWtTRXNIUUVhTVQzYVNv?=
 =?utf-8?B?bkZybnVwS0tPN0xUSXhGd1FjS2toZ3FMVW5reWxqQW8wc2dlNHgraHlmZU11?=
 =?utf-8?B?b2oxNVU2UElFVXdSU0tTQkt4Y2JESXhrTW9aSEc5WlRHZk9TLzRxeHIxVUxO?=
 =?utf-8?B?SFVBTTJOWUswaGQxSUE2SkhMZFRiakdLOTZhNGxFeU0rNlFyOFFnUFE2OFFY?=
 =?utf-8?B?b0xqRXZDZERiQTJnOWVnVHk5QklsVzNyaGFwemlPSFpVRktBWmliR1FkY1RZ?=
 =?utf-8?B?U3RVekpSSTVUUVlSTmF5Ynp5ZGh5VE1zUURveTJtS1IwWmpYTWR6OU5wUnpL?=
 =?utf-8?B?c0sva09HZng0OTN3cGJYMFhYK014eFRuc3dkeFZMRlFPMno2MDlJd2M4alJx?=
 =?utf-8?B?Zm9jdlNVZnMrSDNsVjZnbGpMTFN2b29ubDluQUFzQUFNM3ZFSE9NNkFnQ09B?=
 =?utf-8?B?R05BS3ZrdmpMMXBNN3lldnRNZHB3VEQwYW5sZDRiSWo4WXJ4UmwrM0dLZUtw?=
 =?utf-8?B?WmU3UHM1bkNqcytYMG1pclQ2bTA4QUFMeCt2MkFZdzRHQWhzNlVMTDFUYXNa?=
 =?utf-8?B?MWZhR0tqd3hjR0lsbHB3a1FTRXEvcjVES3BaVzIvRndxak5XcnBBRWtlUFB0?=
 =?utf-8?B?R1Y1czlibnlxL3d3ZnN1cHFudDNVWDlkbGpxYmM3dFIzSHo2T3BaVkhvbGJU?=
 =?utf-8?B?K1dQdWVRbGdCc1VuazBCbjl3WmhvNERRL3RWYTA0c09IbU42S25IeFBSb2xQ?=
 =?utf-8?B?WnVmbXlSSFJnZEZiNzlzWEVlN2FBaUpSM3JkNWZyNk9RZVJiWW56Mml4NkIr?=
 =?utf-8?B?aUdDZTMzcHJLYkVncGxiYlhKa2ZheXJyY1RaMUl1U1p2VE5OMGlHTnkwV01P?=
 =?utf-8?B?VkhwZldtV243Ykt4bGJPOXNpQjhqZjliL0tzN1VIOEVUdmNUb1dpQkFNdlZw?=
 =?utf-8?B?cVp5aHczMm9hT3doL2lCQU4wU2xWOUUwTmhwdStQUnlocndzdS93dzRTM1hs?=
 =?utf-8?B?U0cvM0ZQSVZGK1lUUkd5VGN0cFVjZFpMY2FaSE5tMENHemJ1QTg1MXhhR3JD?=
 =?utf-8?B?eHprNDJMSndubWpPVm1VeDhaTm5PUSs1M00rQnRucHB1d29JV253WTJnUm1t?=
 =?utf-8?B?ZHN5OHFtdi96cURhZmFDQi9vRU1pTlNpVEhhWlhjZHlOVmVPZmNMa1BlVERS?=
 =?utf-8?B?ZHF0ZHpUQW0yWk92cXlvMHNSb2RORHRYZ25ncTlmQjNmeHJBRDMzNFBRTmRX?=
 =?utf-8?B?dWlVck5PZi9EcUNUaVRJRUVzd3dxczBnZ3l5c3hyWEdraExlTkpFWHNRPT0=?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TlEyNHZmMnQ0OE5pdlAwOUFTYjRucnlBdi9xcDVmRXhkL3dKdFZvMGhrWWhD?=
 =?utf-8?B?U3dYVk1oR0ZVMTkzL1AyTDhPVDMwN1U3RnFxL0U2aUVsMWM1RjFPTFNGc3ZE?=
 =?utf-8?B?Q2dsSnFOWDVFZzFpbXZxcFJZZkZ5VzJUNExubFpOU0FacndhT2YwNlpQMXlN?=
 =?utf-8?B?NEdZZmNtY3FCNjB0cFdMVnE4Sk4yMGlzaGxWek43a2hvSFh6bDNjUWNqUGg1?=
 =?utf-8?B?RWRObEthenFlRUlLNjhDUk9IYnZyaEVyS2w3YXNoWlF2RnZVMDkweW1nZzRR?=
 =?utf-8?B?QzVmZFB3QUdvMGdyaGJVeGViTlZMRnlzcjg5TVpuY1R5Y1Z0MXZsbmlBcnU4?=
 =?utf-8?B?U1Q1U2xweTRYNzUyRjNxUGFZU3JYakxkTmZweXpWSk1aeEpBQ3pVN0RPV3Jo?=
 =?utf-8?B?TnY5ZmlTcXlFTDgyR1lTbHl2eEVOa3kveG03cTh4bmhtU3NQUERQNGwva3VW?=
 =?utf-8?B?ekI4UUROTE9OZlVPSXRpYXhMUXJOWS94OVFoSU9mTVl5cWVCS2lWTUxDR3Bv?=
 =?utf-8?B?WE5iVXlGeURwSXhSQWFWYkc2WmNicVcxWTQ5N1hyZzEwT2l3UXBHRFpCU2VX?=
 =?utf-8?B?eDhZeVArblc1c0NBVXZoWHNFRlE5WDh4ZjNlYlVMcUJmVlhBdkJTSzhQR01u?=
 =?utf-8?B?TENmYXFady8zMGdwV0RSblFMNDZOc2Z0TUJpVU8rakdST2UzTklwOE8rT2tw?=
 =?utf-8?B?S3dzVUxXOVEwcFpRd3VIbmxFUWY4WlpGaEtXNUhCd3d4Zjc0NktNTmRaczhV?=
 =?utf-8?B?bElHRUJucU55MEZ1a3RtenNoVUdtU0Fzb1ZDeUZ1NnRHVmlVd0RXcjUvQmF5?=
 =?utf-8?B?OC9qcWF5dkpYajZsVHdUS1piZWFXSnhhZnk5eVhNT0Y0SHc2YWZMZmFGMHI0?=
 =?utf-8?B?QVN4S0haVUwzSGcvdDM4SlQ3RDFDbzFrMHNuRkVJTGEzU1UvaGY3UlNFWVMz?=
 =?utf-8?B?NzJuU1puUGovRUFGQmIxYXRPRFJGODlxVWFqOTFjU0FOUmpWTlRQc1Y4SHUr?=
 =?utf-8?B?T1ZYUVJlQ3lEL01tMCs2dW82cmkrb3RzTUdMcXJzOENJYU03YlVrYmRLMU9X?=
 =?utf-8?B?Y1UrKzJHRlY0MzBJZU1SKzIydzVBcUhGZVJFaHNZUDhmZFQwemhsSWJwaEcx?=
 =?utf-8?B?dWIvMjRYNzQzUFdBWEl0Nnc4UWxZc3g3dkxCNGJsQzZweUk0a1BmYzBLcGs0?=
 =?utf-8?B?bWR4ZUhRbzR1QkRrT2FGUURpWEJjdE54WXV1SDRiSk5YeWxXeTh6ZWdLQkJI?=
 =?utf-8?B?STZ5S1A1ME45NE82ZnlyUDZNQno4azJOVHlhYUF1NVlkOGhCQi8xN1dGcjly?=
 =?utf-8?B?RWMrblZVd3lMeGFLMDlMbEEvVU5uL01MZVZ6VmQ4UUJOWmdHbWZzRUtDYzY0?=
 =?utf-8?B?WmFhSjducDQ3ZTFXZzhmUEl3TjQrRjVWV0NGQ01kRTJIbUthUU1tSU1SMzBQ?=
 =?utf-8?B?aEpaUXpmWEduU2ZOOUlFckgvT25BKzZLTWJoeU4rZTBEa0szWG1oQloyR0NC?=
 =?utf-8?B?cEFRRlF6NWdlTkUvVFM4TW42bVpPWHBrOEpINmdrK0ZJdlBBdDhKeEpJZWxL?=
 =?utf-8?B?VzJxcmIxTzBJMXYzTXh4WldlNUVFVmxYY09NVlY2aEYweXZqM0tLMVhGTnIr?=
 =?utf-8?B?Z1pVMiszNG96WldlZ1E1Q01XOWg0bzk4bnc5Z3dsU2tvOGMrSVpINFFBbnVq?=
 =?utf-8?B?ZmVOU3VvK05PdHFENDRVV08vbzFFZWRuK2tqU0IwWkFaSnF1TThSRURKYTB4?=
 =?utf-8?Q?UplhWnQ7C8B0qbEz+I=3D?=
X-OriginatorOrg: sct-15-20-8534-15-msonline-outlook-5f066.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: c2afb971-f3fa-4089-1998-08de27c94d2d
X-MS-Exchange-CrossTenant-AuthSource: AM8P250MB0170.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 00:11:07.5091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PPF619620E44
From: bobwei9@hotmail.com (Bob Weinand)

--------------Llj1gKza5Qih8TAot0fQBQfG
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hey Jakub,

On 19.11.2025 23:58:57, Jakub Zelenka wrote:
> On Wed, Nov 19, 2025 at 5:37 PM Bob Weinand <bobwei9@hotmail.com> wrote:
>
>     On 19.11.2025 12:52:35, Jakub Zelenka wrote:
>>     The code one should be probably named StreamErrorCode (to not
>>     interact with what Jordi proposed) and think it will need to be
>>     backed as there should be a straightforward way how to compare it
>>     with exception code. I might need to extend the gen stub as I'm
>>     not sure it allows macro import for enum value like for constants
>>     or I will need to come up with some mapping. I just don't wan to
>>     duplicate the numbers. I will figure something out.
>
>     How important is it to have exception code?
>
> I think the exception code could be quite useful for checking for 
> specific errors. It's much better than trying to match it by error 
> message which I saw in past used in normal error handlers. So I can 
> see definitely use case for that. It might be also possible to group 
> those erors if enums are used so users could just match specific group 
> of errors.

For the purpose of grouping it would be vastly preferable to add 
functions to the enum class to mark enum values as pertaining to 
specific groups "function isIoError(): bool", "function 
isFileSystemError(): bool" etc. or just simply "function errorGroup(): 
StreamErrorGroup" which is another enum with some grooups like "Io", 
"Filesystem" etc. rather than comparing ranges.


>     I found that for our purposes we generally skip the exception code
>     (i.e. keep it at zero).
>     As a simple example, ErrorException does take two integers - one
>     for severity, and one for code, instead of using the severity as code.
>
> Severity is almost always warning which I don't think is a good 
> representation for code. I saw error codes used in various application 
> and I think they are useful. I don't think it hurts to have them. The 
> implementation of that enum should not be a big problem. I just need 
> to figure out how to make it nice.
>
>     I would propose something similar here: call it StreamError and
>     provide a public $error property for the actual enum, rather than
>     squeezing it into $code.
>
> I'm not sure I understand this. The code is a generic identifier for 
> the error class that can be matched. StreamError would be the actual 
> representation containing the message and other info - this cannot be 
> matched in a generic way.


My point here is that $code generally does not get used for our 
Exceptions. Whenever we need to attach extra information to an 
exception, we do it as extraneous properties. (That's what my example 
with ErrorException was about.)

I.e. ignore the existence of $code (just assign zero).

And add an extra property for the StreamError enum (which now needs no 
backing).

class StreamException extends Exception {
     public __construct(
         public StreamError $error,
         public string $wrapperName,
         string $message = "",
         public string|null $param = "",
         ?Throwable $previous = null
     ) {
         parent::__construct($message, 0, $previous);
     }
}

Does this make more sense, described as code?


Thank you,
Bob

--------------Llj1gKza5Qih8TAot0fQBQfG
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    <p>Hey Jakub,</p>
    <div class="moz-cite-prefix">On 19.11.2025 23:58:57, Jakub Zelenka
      wrote:</div>
    <blockquote type="cite" cite="mid:CAEKnhAE10uHsaVgAAL9GPFk2UYk40TVjsq9ORuOhqSnEoyjrGQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_quote gmail_quote_container">
          <div dir="ltr" class="gmail_attr">On Wed, Nov 19, 2025 at
            5:37 PM Bob Weinand &lt;<a href="mailto:bobwei9@hotmail.com" moz-do-not-send="true" class="moz-txt-link-freetext">bobwei9@hotmail.com</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div>
              <div>On 19.11.2025 12:52:35, Jakub Zelenka wrote:<br>
              </div>
              <blockquote type="cite">
                <div dir="ltr">
                  <div dir="ltr">
                    <div class="gmail_quote">
                      <div>The code one should be probably named
                        StreamErrorCode (to not interact with what Jordi
                        proposed) and think it will need to be backed as
                        there should be a straightforward way how to
                        compare it with exception code. I might need to
                        extend the gen stub as I'm not sure it allows
                        macro import for enum value like for constants
                        or I will need to come up with some mapping. I
                        just don't wan to duplicate the numbers. I will
                        figure something out.</div>
                    </div>
                  </div>
                </div>
              </blockquote>
              <p>How important is it to have exception code?</p>
            </div>
          </blockquote>
          <div>I think the exception code could be quite useful for
            checking for specific errors. It's much better than trying
            to match it by error message which I saw in past used in
            normal error handlers. So I can see definitely use case for
            that. It might be also possible to group those erors if
            enums are used so users could just match specific group of
            errors.</div>
        </div>
      </div>
    </blockquote>
    <p>For the purpose of grouping it would be vastly preferable to add
      functions to the enum class to mark enum values as pertaining to
      specific groups &quot;function isIoError(): bool&quot;, &quot;function
      isFileSystemError(): bool&quot; etc. or just simply &quot;function
      errorGroup(): StreamErrorGroup&quot; which is another enum with some
      grooups like &quot;Io&quot;, &quot;Filesystem&quot; etc. rather than comparing ranges.</p>
    <p><br>
    </p>
    <blockquote type="cite" cite="mid:CAEKnhAE10uHsaVgAAL9GPFk2UYk40TVjsq9ORuOhqSnEoyjrGQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_quote gmail_quote_container">
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div>
              <p>I found that for our purposes we generally skip the
                exception code (i.e. keep it at zero).<br>
                As a simple example, ErrorException does take two
                integers - one for severity, and one for code, instead
                of using the severity as code.<br>
              </p>
            </div>
          </blockquote>
          <div>Severity is almost always warning which I don't think is
            a good representation for code. I saw error codes used in
            various application and I think they are useful. I don't
            think it hurts to have them. The implementation of that enum
            should not be a big problem. I just need to figure out how
            to make it nice.</div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div>
              <p> I would propose something similar here: call it
                StreamError and provide a public $error property for the
                actual enum, rather than squeezing it into $code.</p>
            </div>
          </blockquote>
          <div>I'm not sure I understand this. The code is a generic
            identifier for the error class that can be matched.
            StreamError would be the actual representation containing
            the message and other info - this cannot be matched in a
            generic way.</div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>My point here is that $code generally does not get used for our
      Exceptions. Whenever we need to attach extra information to an
      exception, we do it as extraneous properties. (That's what my
      example with ErrorException was about.)</p>
    <p>I.e. ignore the existence of $code (just assign zero).</p>
    <p>And add an extra property for the StreamError enum (which now
      needs no backing).</p>
    <p>class StreamException extends Exception {<br>
      &nbsp; &nbsp; public __construct(<br>
      &nbsp; &nbsp; &nbsp; &nbsp; public StreamError $error,<br>
      &nbsp; &nbsp; &nbsp; &nbsp; public string $wrapperName,<br>
      &nbsp; &nbsp; &nbsp; &nbsp; string $message = &quot;&quot;,<br>
      &nbsp; &nbsp; &nbsp; &nbsp; public string|null $param = &quot;&quot;,<br>
      &nbsp; &nbsp; &nbsp; &nbsp; ?Throwable $previous = null<br>
      &nbsp; &nbsp; ) {<br>
      &nbsp; &nbsp; &nbsp; &nbsp; parent::__construct($message, 0, $previous);<br>
      &nbsp; &nbsp; }<br>
      }</p>
    <p>Does this make more sense, described as code?</p>
    <p><br>
    </p>
    <p>Thank you,<br>
      Bob</p>
  </body>
</html>

--------------Llj1gKza5Qih8TAot0fQBQfG--