Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129296
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAEO8w0GJXTVyH_nwK8nGQGdJcNNkGOPMnYDVrcsNGrm4A@mail.gmail.com>
 <CANS-=pf=ggfWq7vF0shVinnH8NLQ-Z7sCJfx8Br36UJC5utgsA@mail.gmail.com> <CAOV5rgaGAYu8Jb6HgV55kjAhxMLDFCAsR7PiLYss=4-xhUcntA@mail.gmail.com>
In-Reply-To: <CAOV5rgaGAYu8Jb6HgV55kjAhxMLDFCAsR7PiLYss=4-xhUcntA@mail.gmail.com>
Date: Wed, 19 Nov 2025 10:54:00 +0100
Message-ID: <CANS-=pdidqwDXwZX_U_82mxjh-SrGATP-qHWOUwmJn2BTs487A@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Stream Error Handling Improvements
To: ignace nyamagana butera <nyamsprod@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000da0b620643ef9005"
From: kjarli@gmail.com (Lynn)

--000000000000da0b620643ef9005
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 19, 2025 at 10:48=E2=80=AFAM ignace nyamagana butera <
nyamsprod@gmail.com> wrote:

>
> On Wed, Nov 19, 2025 at 10:45=E2=80=AFAM Lynn <kjarli@gmail.com> wrote:
>
>>
>>
>> On Tue, Nov 18, 2025 at 7:40=E2=80=AFPM Jakub Zelenka <bukka@php.net> wr=
ote:
>>
>>> Hello,
>>>
>>> I would like to introduce a new stream error handling RFC that is part
>>> of my stream evolution work (PHP Foundation project funded by Sovereign
>>> Tech Fund) :
>>>
>>> https://wiki.php.net/rfc/stream_errors
>>>
>>> Kind regards,
>>>
>>> Jakub
>>>
>>>
>> The naming of "terminal" is a little confusing to me. Reading the name
>> with a bool made me think it was whether or not the CLI was being used,
>> which made little sense in the context of stream errors. After reading t=
he
>> explanation "Terminal errors are those that prevent an operation from
>> completing (e.g., file not found, permission denied). Non-terminal error=
s
>> are warnings or notices that don't stop execution (e.g., buffer
>> truncation).", I feel like it might be more clear if this property was
>> named after what the result is, perhaps something like "operationBlocked=
"
>> or "operationPrevented".
>>
>
>
> I believe these types of issues can be resolved by replacing boolean
> values by Enums, hence my suggestion. Enum would be more self explanatory
> and would provide better insight on the outcome. I also like Jordi's
> suggestion, anything that can help static analysis is the way to go IMHO.
>
> Best regards,
> Ignace
>

I ended up removing this from my first reply, but an enum was also what I
thought of as it wouldn't surprise me if a 3rd state could be introduced:
fully prevented, fully executed but with warnings, and partially executed
like a buffer truncation. I just don't know enough about the underlying
errors/warnings to suggest this as alternative implementation.

--000000000000da0b620643ef9005
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Nov 19,=
 2025 at 10:48=E2=80=AFAM ignace nyamagana butera &lt;<a href=3D"mailto:nya=
msprod@gmail.com">nyamsprod@gmail.com</a>&gt; wrote:<br></div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Nov 19, 2025 at 10:=
45=E2=80=AFAM Lynn &lt;<a href=3D"mailto:kjarli@gmail.com" target=3D"_blank=
">kjarli@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div clas=
s=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 18, 202=
5 at 7:40=E2=80=AFPM Jakub Zelenka &lt;<a href=3D"mailto:bukka@php.net" tar=
get=3D"_blank">bukka@php.net</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><div dir=3D"ltr">Hello,<br><br>I would like to =
introduce a new stream error handling RFC that is part of my stream evoluti=
on work (PHP Foundation project funded by Sovereign Tech Fund) :<br><br><a =
href=3D"https://wiki.php.net/rfc/stream_errors" target=3D"_blank">https://w=
iki.php.net/rfc/stream_errors</a><br><br>Kind regards,<br><br>Jakub<div><br=
></div></div></blockquote><div><br></div><div>The naming of &quot;terminal&=
quot; is a little confusing to me. Reading the name with a bool made me thi=
nk it was whether or not the CLI was being used, which made little sense in=
 the context of stream errors. After reading the explanation &quot;Terminal=
 errors are those that prevent an operation from completing (e.g., file not=
 found, permission denied). Non-terminal errors are warnings or notices tha=
t don&#39;t stop execution (e.g., buffer truncation).&quot;, I feel like it=
 might be more clear if this property was named after what the result is, p=
erhaps something like &quot;operationBlocked&quot; or &quot;operationPreven=
ted&quot;.</div></div></div></blockquote><div><br></div><div><br></div><div=
 dir=3D"ltr">I believe these types of issues can be resolved by replacing b=
oolean values by Enums, hence my suggestion. Enum would be more self explan=
atory and would provide better insight on the outcome. I also like Jordi=
9;s suggestion,=C2=A0anything that can help static analysis is the way=C2=
=A0to go IMHO.<div><br></div><div>Best regards,</div></div><div>Ignace=C2=
=A0</div></div></div></blockquote><div><br></div><div>I ended up removing t=
his from my first reply, but an enum was also what I thought of as it would=
n&#39;t surprise me if a 3rd state could be introduced: fully prevented, fu=
lly executed but with warnings, and partially executed like a buffer trunca=
tion. I just don&#39;t know enough about the underlying errors/warnings to =
suggest this as alternative implementation.</div></div></div>

--000000000000da0b620643ef9005--