Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129295
Precedence: list
MIME-Version: 1.0
References: <CAEKnhAEO8w0GJXTVyH_nwK8nGQGdJcNNkGOPMnYDVrcsNGrm4A@mail.gmail.com>
 <CANS-=pf=ggfWq7vF0shVinnH8NLQ-Z7sCJfx8Br36UJC5utgsA@mail.gmail.com>
In-Reply-To: <CANS-=pf=ggfWq7vF0shVinnH8NLQ-Z7sCJfx8Br36UJC5utgsA@mail.gmail.com>
Date: Wed, 19 Nov 2025 10:48:46 +0100
Message-ID: <CAOV5rgaGAYu8Jb6HgV55kjAhxMLDFCAsR7PiLYss=4-xhUcntA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Stream Error Handling Improvements
To: Lynn <kjarli@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003d15100643ef7dbe"
From: nyamsprod@gmail.com (ignace nyamagana butera)

--0000000000003d15100643ef7dbe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 19, 2025 at 10:45=E2=80=AFAM Lynn <kjarli@gmail.com> wrote:

>
>
> On Tue, Nov 18, 2025 at 7:40=E2=80=AFPM Jakub Zelenka <bukka@php.net> wro=
te:
>
>> Hello,
>>
>> I would like to introduce a new stream error handling RFC that is part o=
f
>> my stream evolution work (PHP Foundation project funded by Sovereign Tec=
h
>> Fund) :
>>
>> https://wiki.php.net/rfc/stream_errors
>>
>> Kind regards,
>>
>> Jakub
>>
>>
> The naming of "terminal" is a little confusing to me. Reading the name
> with a bool made me think it was whether or not the CLI was being used,
> which made little sense in the context of stream errors. After reading th=
e
> explanation "Terminal errors are those that prevent an operation from
> completing (e.g., file not found, permission denied). Non-terminal errors
> are warnings or notices that don't stop execution (e.g., buffer
> truncation).", I feel like it might be more clear if this property was
> named after what the result is, perhaps something like "operationBlocked"
> or "operationPrevented".
>


I believe these types of issues can be resolved by replacing boolean values
by Enums, hence my suggestion. Enum would be more self explanatory and
would provide better insight on the outcome. I also like Jordi's
suggestion, anything that can help static analysis is the way to go IMHO.

Best regards,
Ignace

--0000000000003d15100643ef7dbe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_quote gmail_quote_container"><div =
dir=3D"ltr" class=3D"gmail_attr">On Wed, Nov 19, 2025 at 10:45=E2=80=AFAM L=
ynn &lt;<a href=3D"mailto:kjarli@gmail.com">kjarli@gmail.com</a>&gt; wrote:=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr=
"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr=
" class=3D"gmail_attr">On Tue, Nov 18, 2025 at 7:40=E2=80=AFPM Jakub Zelenk=
a &lt;<a href=3D"mailto:bukka@php.net" target=3D"_blank">bukka@php.net</a>&=
gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div =
dir=3D"ltr">Hello,<br><br>I would like to introduce a new stream error hand=
ling RFC that is part of my stream evolution work (PHP Foundation project f=
unded by Sovereign Tech Fund) :<br><br><a href=3D"https://wiki.php.net/rfc/=
stream_errors" target=3D"_blank">https://wiki.php.net/rfc/stream_errors</a>=
<br><br>Kind regards,<br><br>Jakub<div><br></div></div></blockquote><div><b=
r></div><div>The naming of &quot;terminal&quot; is a little confusing to me=
. Reading the name with a bool made me think it was whether or not the CLI =
was being used, which made little sense in the context of stream errors. Af=
ter reading the explanation &quot;Terminal errors are those that prevent an=
 operation from completing (e.g., file not found, permission denied). Non-t=
erminal errors are warnings or notices that don&#39;t stop execution (e.g.,=
 buffer truncation).&quot;, I feel like it might be more clear if this prop=
erty was named after what the result is, perhaps something like &quot;opera=
tionBlocked&quot; or &quot;operationPrevented&quot;.</div></div></div></blo=
ckquote><div><br></div><div><br></div><div dir=3D"ltr">I believe these type=
s of issues can be resolved by replacing boolean values by Enums, hence my =
suggestion. Enum would be more self explanatory and would provide better in=
sight on the outcome. I also like Jordi&#39;s suggestion,=C2=A0anything tha=
t can help static analysis is the way=C2=A0to go IMHO.<div><br></div><div>B=
est regards,</div></div><div>Ignace=C2=A0</div></div></div>

--0000000000003d15100643ef7dbe--