Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129260
Precedence: list
MIME-Version: 1.0
References: <CAJYrtd_YrEnpSPjkQoQqFGVKOOf_sDgNf+=rtP=pxF1Bik4o2w@mail.gmail.com>
 <CAPyeZ4Nq=S=QOLVqVhNGNN+BD3yByaLfB7NeHnaYCv2UaYGDLQ@mail.gmail.com>
 <CAJYrtd8y9b6jOWNA5gB_vT5mnTijJ302JoSQd2ZTvyrdOotduQ@mail.gmail.com>
 <34c08e21-8cd1-2e0e-1cca-148d4acc5432@php.net> <CAJYrtd9OgtkOV8U=eqxegukj=_rL9GVyFPkebfKoWAgJGkRcRw@mail.gmail.com>
 <a6b66245-5acc-49dc-9f6c-2de46d545ee2@app.fastmail.com> <a22a0cf8-640e-413e-896a-0530ce799fe1@gmail.com>
In-Reply-To: <a22a0cf8-640e-413e-896a-0530ce799fe1@gmail.com>
Date: Sun, 16 Nov 2025 12:44:28 +0300
Message-ID: <CAJYrtd_kdpkGFaS8pQy5LtY=KFU=ywBO9X9WkFDqRr=-OkeiJg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add values() Method to BackedEnum
To: Niels Dossche <dossche.niels@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000532ea90643b31432"
From: mikhail.d.savin@gmail.com (Mikhail Savin)

--000000000000532ea90643b31432
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=D1=81=D1=80, 12 =D0=BD=D0=BE=D1=8F=D0=B1. 2025=E2=80=AF=D0=B3. =D0=B2 22:2=
6, Niels Dossche <dossche.niels@gmail.com>:

>
>
> On 12/11/2025 20:01, Larry Garfield wrote:
> > Isn't this what the #[ReturnTypeWillChange] attribute was intended for?
> >
> > cf: https://wiki.php.net/rfc/internal_method_return_types
> >
> > That seems like an option C?  It's technically a BC break, but people
> can just drop an attribute on it to disable the return type check until
> 9.0.  We did the same for the various internal methods, as noted in that
> RFC.
>
> Parameter checks are not disabled by that attribute, so the BC problem
> remains.
>

Hi everyone,

Based on your feedback, I=E2=80=99ve updated both the PR and the RFC by rem=
oving
the return type declaration from the interface. Thanks for the input.

--000000000000532ea90643b31432
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">=D1=81=D1=80, 1=
2 =D0=BD=D0=BE=D1=8F=D0=B1. 2025=E2=80=AF=D0=B3. =D0=B2 22:26, Niels Dossch=
e &lt;<a href=3D"mailto:dossche.niels@gmail.com">dossche.niels@gmail.com</a=
>&gt;:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 12/11/2025 20:01, Larry Garfield wrote:<br>
&gt; Isn&#39;t this what the #[ReturnTypeWillChange] attribute was intended=
 for?<br>
&gt; <br>
&gt; cf: <a href=3D"https://wiki.php.net/rfc/internal_method_return_types" =
rel=3D"noreferrer" target=3D"_blank">https://wiki.php.net/rfc/internal_meth=
od_return_types</a><br>
&gt; <br>
&gt; That seems like an option C?=C2=A0 It&#39;s technically a BC break, bu=
t people can just drop an attribute on it to disable the return type check =
until 9.0.=C2=A0 We did the same for the various internal methods, as noted=
 in that RFC.<br>
<br>
Parameter checks are not disabled by that attribute, so the BC problem rema=
ins.<br></blockquote><div><br>Hi everyone,<br><br>Based on your feedback, I=
=E2=80=99ve updated both the PR and the RFC by removing the return type dec=
laration from the interface. Thanks for the input.<br></div></div></div>

--000000000000532ea90643b31432--