Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129226
Precedence: list
MIME-Version: 1.0
References: <CAPqq82sqFy1y77XLu8Kbncg18WNopeJdPrfB+JQ8FWNZ4XpTQg@mail.gmail.com>
 <CAPyj-LBG0nR75AUMXT0XCnpNnPP=T62NYvRQ34yeZpd+i=cTPw@mail.gmail.com>
 <CAPqq82sy1O9-J4yhvcPvsob3Rjdi1wFDW_t597850sBTbKc=sg@mail.gmail.com>
 <4b6abc36d8ab6cd306e95141869db3b0@bastelstu.be> <CAPqq82u7xhMDqmwuhEPOGqHdnrM3S2OM+HG=XpG-SyKPS3LofA@mail.gmail.com>
 <21ff8dee5016a1b7ecc412c44233abd1@bastelstu.be> <CAPqq82vPdraqE1DuJQ6w4pWpwr1koTHcj_o0pKV1dXxRoaguqg@mail.gmail.com>
 <3a20b5ef66fc23de6bad022685b41190@bastelstu.be> <CAPqq82vbQzUidGG1h=hLhz7fxRrdZFav1RDjBw83aA0vqmpgUw@mail.gmail.com>
 <4e3061bfaa5218309041460d31be2856@bastelstu.be>
In-Reply-To: <4e3061bfaa5218309041460d31be2856@bastelstu.be>
Date: Sat, 15 Nov 2025 00:51:23 +0200
Message-ID: <CAPqq82v89W_fXuMDqAK_2wYEZW8cTi6t7npDFQdZ7f54bsLAig@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] Add #[NoSerialize] attribute for
 excluding properties or classes from serialization
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Ilija Tovilo <tovilo.ilija@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: lnkvisitor.ts@gmail.com (Dmytro Kulyk)

=D0=BF=D1=82, 7 =D0=BB=D0=B8=D1=81=D1=82. 2025=E2=80=AF=D1=80. =D0=BE 12:57=
 Tim D=C3=BCsterhus <tim@bastelstu.be> =D0=BF=D0=B8=D1=88=D0=B5:
>
> Thank you. The updated RFC is looking good to me. I also appreciate that
> you kept a changelog within the RFC.
>
> One thing you could mention and that should be done as part of the RFC
> is migrating all existing classes with `@not-serializable` to make use
> of the attribute instead. That's also what has been done when the
> `#[\Deprecated]` attribute was introduced. Other than that, I don't have
> any further comments.
>

Thank you for the review and the helpful suggestion.

I agree that all internal classes currently annotated with
@not-serializable should also receive the corresponding
#[\NoSerialize] attribute as part of this RFC. This ensures that
internal metadata, reflection, and userland tooling remain fully
aligned, and that the behavior is consistently exposed at both the
engine and stub levels.

The RFC has been updated to explicitly state that these attributes
will be added for all such internal classes.

I also have one technical question regarding stub generation:
When attributes are emitted into generated arginfo.h files, should the
generator automatically include zend_attributes.h?
This would avoid requiring extensions to include zend_attributes.h
explicitly when they do not use attributes themselves but only include
generated stubs that reference them. Before making any implementation
adjustments, I=E2=80=99d appreciate confirmation that this approach is
acceptable within the current stub-generation design.

```
/* This is a generated file, edit the .stub.php file instead.
 * Stub hash: 2fc12d1fde65efbec4305f4934a3f4b25282a552 */

#include "zend_attributes.h"
...
    zend_add_class_attribute(class_entry, ZSTR_KNOWN(ZEND_STR_NO_SERIALIZE)=
, 0);
...
```

Best regards,
Dmytro