Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129197
Precedence: list
MIME-Version: 1.0
References: <CAJYrtd_YrEnpSPjkQoQqFGVKOOf_sDgNf+=rtP=pxF1Bik4o2w@mail.gmail.com>
 <CAPyeZ4Nq=S=QOLVqVhNGNN+BD3yByaLfB7NeHnaYCv2UaYGDLQ@mail.gmail.com> <CAJYrtd8y9b6jOWNA5gB_vT5mnTijJ302JoSQd2ZTvyrdOotduQ@mail.gmail.com>
In-Reply-To: <CAJYrtd8y9b6jOWNA5gB_vT5mnTijJ302JoSQd2ZTvyrdOotduQ@mail.gmail.com>
Date: Tue, 11 Nov 2025 13:43:37 +0200
Message-ID: <CAAwdEzAr1deQVS9wEO5Q0zSQuD9Cfr45zanya8E+zid0P+VU2w@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add values() Method to BackedEnum
To: Mikhail Savin <mikhail.d.savin@gmail.com>
Cc: Valentin Udaltsov <udaltsov.valentin@gmail.com>, php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000923392064350299b"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000923392064350299b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 11, 2025 at 10:29=E2=80=AFAM Mikhail Savin <mikhail.d.savin@gma=
il.com>
wrote:

>
> That said, adding values() to BackedEnum is a source-level BC break for
> codebases that already define conflicting values() on backed enums.
>
> But, as we can see from GitHub searches that I posted in PR, most of the
> implementations is exactly the same, so BC break is very small
>

Do you think you can quantify this BC break: how many implementations are
having a different signature? And update the RFC "Impact on Ecosystem"
section?

Small note:
implementations usually use `array_column(self::cases(), 'value')` instead
of `array_map(static fn(self $c) =3D> $c->value, self::cases())`.
and that's just normal, as it is 2x faster: https://3v4l.org/Q5AYg#v8.4.14
maybe mention it as well, or instead of the one you had it the examples, as
this is usually how it can be found in libraries.

--=20
Alex

--000000000000923392064350299b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 11,=
 2025 at 10:29=E2=80=AFAM Mikhail Savin &lt;<a href=3D"mailto:mikhail.d.sav=
in@gmail.com">mikhail.d.savin@gmail.com</a>&gt; wrote:<br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><b=
r></div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Th=
at said, adding values() to BackedEnum is a source-level BC break for codeb=
ases that already define conflicting values() on backed enums.</div><br>But=
, as we can see from GitHub searches that I posted in PR, most of the imple=
mentations is exactly the same, so BC break is very small<br></div></div></=
blockquote><div><br></div><div>Do you think you can quantify this BC break:=
 how many implementations are having a different signature? And update the =
RFC &quot;Impact on Ecosystem&quot; section?</div><div><br></div><div>Small=
 note:</div><div>implementations usually use `array_column(self::cases(), &=
#39;value&#39;)` instead of `array_map(static fn(self $c) =3D&gt; $c-&gt;va=
lue, self::cases())`.<br>and that&#39;s just normal, as it is 2x faster:=C2=
=A0<a href=3D"https://3v4l.org/Q5AYg#v8.4.14">https://3v4l.org/Q5AYg#v8.4.1=
4</a><br>maybe mention it as well, or instead of the one you had it the exa=
mples, as this is usually how it can be found in libraries.</div><div><br><=
/div><div>--=C2=A0</div><div>Alex</div></div></div>

--000000000000923392064350299b--