Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129026
Precedence: list
MIME-Version: 1.0
References: <CAPqq82sqFy1y77XLu8Kbncg18WNopeJdPrfB+JQ8FWNZ4XpTQg@mail.gmail.com>
 <CAPyj-LBG0nR75AUMXT0XCnpNnPP=T62NYvRQ34yeZpd+i=cTPw@mail.gmail.com>
 <CAPqq82sy1O9-J4yhvcPvsob3Rjdi1wFDW_t597850sBTbKc=sg@mail.gmail.com>
 <4b6abc36d8ab6cd306e95141869db3b0@bastelstu.be> <CAPqq82u7xhMDqmwuhEPOGqHdnrM3S2OM+HG=XpG-SyKPS3LofA@mail.gmail.com>
 <21ff8dee5016a1b7ecc412c44233abd1@bastelstu.be> <CAPqq82vPdraqE1DuJQ6w4pWpwr1koTHcj_o0pKV1dXxRoaguqg@mail.gmail.com>
 <3a20b5ef66fc23de6bad022685b41190@bastelstu.be> <CA+NMNO0ULGv8M-YamTG6LK2f4AVNCHmt6TsPjng-3pSmncnyOg@mail.gmail.com>
 <e77425f531e82be94f51ed41eb09e53f@bastelstu.be>
In-Reply-To: <e77425f531e82be94f51ed41eb09e53f@bastelstu.be>
Reply-To: erictnorris@gmail.com
Date: Fri, 31 Oct 2025 08:29:36 -0400
Message-ID: <CA+NMNO2GJynu+Gh-jO4WQ66XqhVRr7snpioRpwhU=QAa_sJfnA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] Add #[NoSerialize] attribute for
 excluding properties or classes from serialization
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Dmytro Kulyk <lnkvisitor.ts@gmail.com>, Ilija Tovilo <tovilo.ilija@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004ba2b0064273854f"
From: eric.t.norris@gmail.com (Eric Norris)

--0000000000004ba2b0064273854f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 31, 2025, 8:23=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.be>=
 wrote:

> Hi
>
> Am 2025-10-31 13:16, schrieb Eric Norris:
> > I hope I'm not starting a bikeshed discussion, but I've been following
> > along - can I suggest "DoNotSerialize"? "NoSerialize" sounds odd to me,
> > whereas "DoNotSerialize" can be seen as both an instruction to PHP -
> > "don't
> > serialize this property when serializing the class" - and an
> > instruction to
> > developers - "do not attempt to serialize this class".
>
> I don't have a particularly strong opinion on naming, but I'd like to
> note that #[\NoSerialize] is in line with #[\NoDiscard] (added in PHP
> 8.5, https://wiki.php.net/rfc/marking_return_value_as_important).
>

Fair. I had considered that this might already be inconsistent with other
attributes, but I was responding by phone and didn't look it up - thanks.
I'm still partial to something that sounds more "natural" from a language
perspective to me, but I can appreciate the argument to prefer consistency.

(This may come up in the future, so I wonder if we have / should have a
naming policy?)

>

--0000000000004ba2b0064273854f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote gmail_quote_container"><di=
v dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 31, 2025, 8:23=E2=80=AFAM Ti=
m D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 =
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
Am 2025-10-31 13:16, schrieb Eric Norris:<br>
&gt; I hope I&#39;m not starting a bikeshed discussion, but I&#39;ve been f=
ollowing<br>
&gt; along - can I suggest &quot;DoNotSerialize&quot;? &quot;NoSerialize&qu=
ot; sounds odd to me,<br>
&gt; whereas &quot;DoNotSerialize&quot; can be seen as both an instruction =
to PHP - <br>
&gt; &quot;don&#39;t<br>
&gt; serialize this property when serializing the class&quot; - and an <br>
&gt; instruction to<br>
&gt; developers - &quot;do not attempt to serialize this class&quot;.<br>
<br>
I don&#39;t have a particularly strong opinion on naming, but I&#39;d like =
to <br>
note that #[\NoSerialize] is in line with #[\NoDiscard] (added in PHP <br>
8.5, <a href=3D"https://wiki.php.net/rfc/marking_return_value_as_important"=
 rel=3D"noreferrer noreferrer" target=3D"_blank">https://wiki.php.net/rfc/m=
arking_return_value_as_important</a>).<br></blockquote></div></div><div dir=
=3D"auto"><br></div><div dir=3D"auto">Fair. I had considered that this migh=
t already be inconsistent with other attributes, but I was responding by ph=
one and didn&#39;t look it up - thanks. I&#39;m still partial to something =
that sounds more &quot;natural&quot; from a language perspective to me, but=
 I can appreciate the argument to prefer consistency.</div><div dir=3D"auto=
"><br></div><div dir=3D"auto">(This may come up in the future, so I wonder =
if we have / should have a naming policy?)</div><div dir=3D"auto"><div clas=
s=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--0000000000004ba2b0064273854f--