Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129020
Precedence: list
MIME-Version: 1.0
References: <CA+XhMqy46mXBtop2pn_fZt7LGaQvT5seUPfFhurEjPsGSOE9EQ@mail.gmail.com>
 <6301b5d6e65d39f53e95ee4f9ade7632@bastelstu.be>
In-Reply-To: <6301b5d6e65d39f53e95ee4f9ade7632@bastelstu.be>
Date: Fri, 31 Oct 2025 09:42:48 +0000
Message-ID: <CA+XhMqx0SeC=vVxLi1fQFaxR=-Of_Q4JaBUf_y1w2xq0XGruKw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] Using TidyException new type for tidy extension
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f5089e064271308c"
From: devnexen@gmail.com (David CARLIER)

--000000000000f5089e064271308c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Tim,


On Wed, 29 Oct 2025 at 13:06, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:

> Hi
>
> Am 2025-10-26 18:09, schrieb David CARLIER:
> > https://wiki.php.net/rfc/tidyexception-for-tidy
>
> Thank you for the RFC. I believe moving to Exceptions for error handling
> is the right thing, so I support the RFC in principle.
>
> However the proposal is *very* bare-bones. It would be useful to
> describe which errors can currently be emitted from ext/tidy, so that we
> can discuss a proper Exception hierarchy. In the PR I'm seeing just 3
> locations - are those all of them?
>
Yes.

>
> Naming-wise I wonder if we should go all the way to
> `\Tidy\TidyException` (i.e. with a namespace) right away.
>

I would not mind going as far as to introduce a whole namespace if needs
be.
RFC updated.

>
> Best regards
> Tim D=C3=BCsterhus
>

--000000000000f5089e064271308c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Tim,<div><br></div></div><br><div clas=
s=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_att=
r">On Wed, 29 Oct 2025 at 13:06, Tim D=C3=BCsterhus &lt;<a href=3D"mailto:t=
im@bastelstu.be">tim@bastelstu.be</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Hi<br>
<br>
Am 2025-10-26 18:09, schrieb David CARLIER:<br>
&gt; <a href=3D"https://wiki.php.net/rfc/tidyexception-for-tidy" rel=3D"nor=
eferrer" target=3D"_blank">https://wiki.php.net/rfc/tidyexception-for-tidy<=
/a><br>
<br>
Thank you for the RFC. I believe moving to Exceptions for error handling <b=
r>
is the right thing, so I support the RFC in principle.<br>
<br>
However the proposal is *very* bare-bones. It would be useful to <br>
describe which errors can currently be emitted from ext/tidy, so that we <b=
r>
can discuss a proper Exception hierarchy. In the PR I&#39;m seeing just 3 <=
br>
locations - are those all of them?<br></blockquote><div>Yes.=C2=A0</div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Naming-wise I wonder if we should go all the way to <br>
`\Tidy\TidyException` (i.e. with a namespace) right away.<br></blockquote><=
div>=C2=A0</div><div>I would not mind going as far as to introduce a whole =
namespace if needs be.=C2=A0</div><div>RFC updated.</div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
<br>
Best regards<br>
Tim D=C3=BCsterhus<br>
</blockquote></div></div>

--000000000000f5089e064271308c--