Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:129005
Precedence: list
MIME-Version: 1.0
Date: Thu, 30 Oct 2025 09:23:03 +0100
To: Dmytro Kulyk <lnkvisitor.ts@gmail.com>
Cc: Ilija Tovilo <tovilo.ilija@gmail.com>, PHP internals
 <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC][Discussion] Add #[NoSerialize] attribute for
 excluding properties or classes from serialization
In-Reply-To: <CAPqq82u7xhMDqmwuhEPOGqHdnrM3S2OM+HG=XpG-SyKPS3LofA@mail.gmail.com>
References: <CAPqq82sqFy1y77XLu8Kbncg18WNopeJdPrfB+JQ8FWNZ4XpTQg@mail.gmail.com>
 <CAPyj-LBG0nR75AUMXT0XCnpNnPP=T62NYvRQ34yeZpd+i=cTPw@mail.gmail.com>
 <CAPqq82sy1O9-J4yhvcPvsob3Rjdi1wFDW_t597850sBTbKc=sg@mail.gmail.com>
 <4b6abc36d8ab6cd306e95141869db3b0@bastelstu.be>
 <CAPqq82u7xhMDqmwuhEPOGqHdnrM3S2OM+HG=XpG-SyKPS3LofA@mail.gmail.com>
Message-ID: <21ff8dee5016a1b7ecc412c44233abd1@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

I am just noticing that your RFC still is marked as Draft, both within 
the RFC text and within the overview at https://wiki.php.net/rfc. Don't 
forget to adjust the status to “Under Discussion” for proper visibility.

Am 2025-10-29 23:23, schrieb Dmytro Kulyk:
> It already makes no sense because the class-level attribute will be
> excluded from the RFC, and I have no plan to add something like this
> to #[NotSerializable]. It may be added in a future RFC.

I am seeing that you adjusted the RFC to remove the support for applying 
`#[\NoSerialize]` to classes. Given that we determined that serializing 
classes should either throw or work (i.e. that serializing them to 
`null` is never right), I don't think that two separate attributes are 
necessary. While a combined attribute would behave somewhat differently 
for classes and properties, the name of `#[\NoSerialize]` and 
`#[\NotSerializable]` is very similar and thus confusing in itself. I 
would suggest to merge the RFCs of `#[\NoSerialize]` and 
`#[\NotSerializable]` into a single attribute, since in both cases you 
are indicating “I don't want this serialized” and I think it is 
reasonable to expect from users to learn that there is some difference 
in behavior for properties compared to classes.

Best regards
Tim Düsterhus