Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:128995 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by lists.php.net (Postfix) with ESMTPS id 879BA1A00BC for ; Wed, 29 Oct 2025 13:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1761743182; bh=7FCzF9B1cfeoBCZ7CxeAMaRDyqVCcp0OfrhYt6SJXSc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QUBWJwZQhek9dIg1RUQU9C7kyTVnbuw2z0dC8DRhFkLT/+zOEqUJyTSrRG1dKrGQe Vevxvn8hkNpHenCgBWF3Kx/iiYmuaZuYpPUOJkps/T70gkbxDZnIRftr/FAImM7IJ+ /vIoc68MFvYAWLMU2+o9joit1R9sWcK7CCuKaJ2bLti/MH5s92k+EjVpS/OhOSJRq2 vkspJ2+v+kFvSQS1sDlcWHpnotmCNO8TaPppZQcQvkUPKBTNIjbMLvEPtNANrxOjiH T2H3UyJng/ar/fTN5yvdh3r7nWwVCi188mTQi+aAs0fRiV9YwHSp/T6hARAIpwnvCY hJJuVUchYugGg== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 2EB7718003F for ; Wed, 29 Oct 2025 13:06:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Virus: No X-Envelope-From: Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 29 Oct 2025 13:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be; s=mail20171119; t=1761743173; bh=MwiN+EUp4tKj3VCNkb2A3GIKUNyOC0EOFfXhpPuY/Vk=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type:from:to:cc:subject:message-id; b=Tv9IWG0L8f9Jj5so4WcMYCs5C/HYOeFcsRXnf8J1btfKJi+MZYzdZs9HANZF9AFTV aDpm4Yl6nvF4awBPBqwwbhm+CgSu7rLeTkpcZZzxpmT7YVeY4x1sBcrYxcOkYjOZ52 +f4FLrTvSLn5gIafXx+Tb8R0009XNx53oq1W4xkdpxBNa2ppTIqPacGJKVGaqPBZ3+ fmmGnWkI41zvPITRQqZ6jkG8+gWZF11uVL0MHuGAk4RpgrE0CprwMeifGgvT9i19zk KHsk2VP63XCNEYiu4IB9Ry9NByifK5h7P+Iqi74ui68Q6MreToeAsSeDiUge09tXdX nmoBxd4PljOog== Precedence: list list-help: list-unsubscribe: list-post: List-Id: x-ms-reactions: disallow MIME-Version: 1.0 Date: Wed, 29 Oct 2025 14:06:13 +0100 To: David CARLIER Cc: PHP internals Subject: Re: [PHP-DEV] [RFC][Discussion] Using TidyException new type for tidy extension In-Reply-To: References: Message-ID: <6301b5d6e65d39f53e95ee4f9ade7632@bastelstu.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=) Hi Am 2025-10-26 18:09, schrieb David CARLIER: > https://wiki.php.net/rfc/tidyexception-for-tidy Thank you for the RFC. I believe moving to Exceptions for error handling is the right thing, so I support the RFC in principle. However the proposal is *very* bare-bones. It would be useful to describe which errors can currently be emitted from ext/tidy, so that we can discuss a proper Exception hierarchy. In the PR I'm seeing just 3 locations - are those all of them? Naming-wise I wonder if we should go all the way to `\Tidy\TidyException` (i.e. with a namespace) right away. Best regards Tim Düsterhus