Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128993
Message-ID: <AFF38489-1BF0-480C-A4C7-04291F1070E9@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_3E02AA98-45CA-4EDB-8BC6-A847016B7F60"
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: [PHP-DEV] Change `setlocale()` to use the `uselocale()` C
 function if available on POSIX too
Date: Wed, 29 Oct 2025 09:45:17 +0100
In-Reply-To: <ZR1P278MB112080300D6FB5871FFD7E9AD1FDA@ZR1P278MB1120.CHEP278.PROD.OUTLOOK.COM>
Cc: "internals@lists.php.net" <internals@lists.php.net>
To: Marc Henderkes <m@pyc.ac>
References: <ZR1P278MB112080300D6FB5871FFD7E9AD1FDA@ZR1P278MB1120.CHEP278.PROD.OUTLOOK.COM>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail=_3E02AA98-45CA-4EDB-8BC6-A847016B7F60
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 28 oct. 2025 =C3=A0 16:52, Marc Henderkes <m@pyc.ac> a =C3=A9crit :
>=20
> Hello everyone,
> =20
> We recently noticed that the setlocale function currently uses =
`setlocale` in its C implementation as well =
[https://github.com/php/frankenphp/pull/1941], which is a) not =
multithreading safe to use and b) when it doesn=E2=80=99t crash, leads =
to overriding the current locale for the entire process.
> For NTS builds with php-fpm this is not an issue, but for FrankenPHP =
and mod_php, this leads to unexpected behaviour described here: =
https://github.com/php/frankenphp/pull/1941#issuecomment-3457137937
>=20
> On Windows builds, since PHP 7, it is already per-thread, but on POSIX =
systems it is not.
>=20
> I would therefore like to get your reactions on whether it would make =
sense to unify the behaviour between POSIX systems and Windows and make =
the `setlocale()` function thread-safe and per-thread, rather than =
per-process.
> In case my proposal sees positive reception, I=E2=80=99d like to go =
ahead and create an RFC. I will also implement the changes in php-src, =
I=E2=80=99ve already done so as a proof of concept.
>=20
> Thank you for your time,
> Marc Henderkes

Hi,

=46rom my point of view, the current behaviour (not thread-safe and not =
per-thread) is obviously a bug, not a feature. I assume that there is no =
need to create an RFC for fixing a bug?

=E2=80=94Claude=

--Apple-Mail=_3E02AA98-45CA-4EDB-8BC6-A847016B7F60
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;"><br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>Le 28 oct. 2025 =C3=A0 16:52, Marc Henderkes =
&lt;m@pyc.ac&gt; a =C3=A9crit :</div><br =
class=3D"Apple-interchange-newline"><div><meta charset=3D"UTF-8"><div =
class=3D"WordSection1" style=3D"page: WordSection1; caret-color: rgb(0, =
0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;"><div style=3D"margin: 0cm; font-size: 11pt; =
font-family: Aptos, sans-serif;">Hello everyone,<o:p></o:p></div><div =
style=3D"margin: 0cm; font-size: 11pt; font-family: Aptos, =
sans-serif;"><o:p>&nbsp;</o:p></div><div style=3D"margin: 0cm; =
font-size: 11pt; font-family: Aptos, sans-serif;">We recently noticed =
that the setlocale function currently uses `setlocale` in its C =
implementation as well [<a =
href=3D"https://github.com/php/frankenphp/pull/1941" style=3D"color: =
rgb(70, 120, 134); text-decoration: =
underline;">https://github.com/php/frankenphp/pull/1941</a>], which is =
a) not multithreading safe to use and b) when it doesn=E2=80=99t crash, =
leads to overriding the current locale for the entire =
process.<o:p></o:p></div><div style=3D"margin: 0cm; font-size: 11pt; =
font-family: Aptos, sans-serif;">For NTS builds with php-fpm this is not =
an issue, but for FrankenPHP and mod_php, this leads to unexpected =
behaviour described here:<span =
class=3D"Apple-converted-space">&nbsp;</span><a =
href=3D"https://github.com/php/frankenphp/pull/1941#issuecomment-345713793=
7" style=3D"color: rgb(70, 120, 134); text-decoration: =
underline;">https://github.com/php/frankenphp/pull/1941#issuecomment-34571=
37937</a><br><br>On Windows builds, since PHP 7, it is already =
per-thread, but on POSIX systems it is not.<br><br>I would therefore =
like to get your reactions on whether it would make sense to unify the =
behaviour between POSIX systems and Windows and make the `setlocale()` =
function thread-safe and per-thread, rather than =
per-process.<o:p></o:p></div><div style=3D"margin: 0cm; font-size: 11pt; =
font-family: Aptos, sans-serif;">In case my proposal sees positive =
reception, I=E2=80=99d like to go ahead and create an RFC. I will also =
implement the changes in php-src, I=E2=80=99ve already done so as a =
proof of concept.<br><br>Thank you for your time,<o:p></o:p></div><div =
style=3D"margin: 0cm; font-size: 11pt; font-family: Aptos, =
sans-serif;">Marc =
Henderkes</div></div></div></blockquote></div><br><div>Hi,</div><div><br><=
/div><div>=46rom my point of view, the current behaviour (not&nbsp;<span =
style=3D"font-family: Aptos, sans-serif; font-size: =
11pt;">thread</span>-safe and not per-thread) is obviously a bug, not a =
feature. I assume that there is no need to create an RFC for fixing a =
bug?</div><div><br></div><div>=E2=80=94Claude</div></body></html>=

--Apple-Mail=_3E02AA98-45CA-4EDB-8BC6-A847016B7F60--