Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128967
Precedence: list
MIME-Version: 1.0
References: <CAE1541vPXkgZsxfAiWJyosnhDksGT=2tDJyoYOcJtG16jZh9nA@mail.gmail.com>
 <48b2d4f5-2baa-4dac-9f13-163ac68a4adf@app.fastmail.com> <a8bdf747-3ba0-4331-b9fd-3b9709c12070@varteg.nz>
 <dfd39d2a-7b09-4554-b2ab-b1f828b45f40@app.fastmail.com> <c71f4bff-6f41-4f39-ac52-888b5c48f3cd@varteg.nz>
In-Reply-To: <c71f4bff-6f41-4f39-ac52-888b5c48f3cd@varteg.nz>
Date: Sat, 25 Oct 2025 14:01:00 -0700
Message-ID: <CAE1541sThm9tBP+UdgM_02O5R+NCfzdNjzUD6qhKRKtqkX1GOw@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC proposal for adding SORT_STRICT flag to array_unique()
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000003f4d4c064201f7e5"
From: jmarble@intuitivetechnology.com (Jason Marble)

--0000000000003f4d4c064201f7e5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Rob has convinced me SORT_STRICT is semantically incorrect. I agree
SORT_BINARY has merit, though I'm having difficulty with the implementation=
.

I think I got too focused on _convention_ wanting to align naming
convention with the existing SORT_* flags. But a perfectly acceptable
alternative exists, ARRAY_UNIQUE_STRICT.

I'm aware of the previous effort (https://externals.io/message/118952) made
regarding the flag ARRAY_UNIQUE_IDENTICAL. While this is technically
correct and follows existing convention (e.g. ARRAY_FILTER_USE_*), I
personally feel it's a bit awkward.

ARRAY_UNIQUE_STRICT is, I think, a bit more intuitive. Especially today, as
`declare(strict_types=3D1)` has become more common and even encouraged,
particularly for those who love PHPStan level max haha.

Pull it, test it, break it. Let's do this!
https://github.com/php/php-src/compare/master...jmarble:php-src:feature/arr=
ay-unique-sort-strict

On Sat, Oct 25, 2025 at 7:41=E2=80=AFAM Morgan <Weedpacket@varteg.nz> wrote=
:

> On 2025-10-26 00:16, Rob Landers wrote:
>
> >
> > Object identity and value are different things... https://3v4l.org/uZTs=
N
> > <https://3v4l.org/uZTsN>
> >
>
>
>   $white =3D=3D new Color("white")
>
> That's comparing the values of the objects' properties (which may or may
> not be relevant to its "effective value" - the comparison applies to
> private properties as well) and considering the aggregate to be the
> "value of the object".
>
> Regardless, the comparison is certainly not useful to me (where
> recursively grovelling around in the objects' properties would be
> prohibitively expensive if not fatal), and doesn't make array_unique()
> any more helpful in deduplicating.
>

--0000000000003f4d4c064201f7e5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Rob has convinced me SORT_STRICT is semantically incorrect=
. I agree SORT_BINARY has merit, though I&#39;m having difficulty with the =
implementation.<br><br>I think I got too focused on _convention_ wanting to=
 align naming convention with the existing SORT_* flags. But a perfectly ac=
ceptable alternative exists, ARRAY_UNIQUE_STRICT.<br><br>I&#39;m aware of t=
he previous effort (<a href=3D"https://externals.io/message/118952">https:/=
/externals.io/message/118952</a>) made regarding the flag ARRAY_UNIQUE_IDEN=
TICAL. While this is technically correct and follows existing convention (e=
.g.=C2=A0ARRAY_FILTER_USE_*), I personally feel it&#39;s a bit awkward.<br>=
<br>ARRAY_UNIQUE_STRICT is, I think, a bit more intuitive. Especially=C2=A0=
today, as `declare(strict_types=3D1)` has become more common and even encou=
raged, particularly for those who love PHPStan level max haha.<br><br>Pull =
it, test it, break it. Let&#39;s do this!<br><a href=3D"https://github.com/=
php/php-src/compare/master...jmarble:php-src:feature/array-unique-sort-stri=
ct" target=3D"_blank">https://github.com/php/php-src/compare/master...jmarb=
le:php-src:feature/array-unique-sort-strict</a></div><br><div class=3D"gmai=
l_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sat=
, Oct 25, 2025 at 7:41=E2=80=AFAM Morgan &lt;<a href=3D"mailto:Weedpacket@v=
arteg.nz">Weedpacket@varteg.nz</a>&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex">On 2025-10-26 00:16, Rob Landers wrote:<br>
<br>
&gt; <br>
&gt; Object identity and value are different things... <a href=3D"https://3=
v4l.org/uZTsN" rel=3D"noreferrer" target=3D"_blank">https://3v4l.org/uZTsN<=
/a> <br>
&gt; &lt;<a href=3D"https://3v4l.org/uZTsN" rel=3D"noreferrer" target=3D"_b=
lank">https://3v4l.org/uZTsN</a>&gt;<br>
&gt; <br>
<br>
<br>
=C2=A0 $white =3D=3D new Color(&quot;white&quot;)<br>
<br>
That&#39;s comparing the values of the objects&#39; properties (which may o=
r may <br>
not be relevant to its &quot;effective value&quot; - the comparison applies=
 to <br>
private properties as well) and considering the aggregate to be the <br>
&quot;value of the object&quot;.<br>
<br>
Regardless, the comparison is certainly not useful to me (where <br>
recursively grovelling around in the objects&#39; properties would be <br>
prohibitively expensive if not fatal), and doesn&#39;t make array_unique() =
<br>
any more helpful in deduplicating.<br>
</blockquote></div>

--0000000000003f4d4c064201f7e5--