Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128956
Precedence: list
MIME-Version: 1.0
References: <CAE1541vPXkgZsxfAiWJyosnhDksGT=2tDJyoYOcJtG16jZh9nA@mail.gmail.com>
 <4b605609-47c2-4df5-be71-8b962ad9ff1e@varteg.nz>
In-Reply-To: <4b605609-47c2-4df5-be71-8b962ad9ff1e@varteg.nz>
Date: Sat, 25 Oct 2025 01:23:19 +0300
Message-ID: <CAPyeZ4N2gS724=+ux3hsHyNp3iyVbZJA_4a2jf78svGo_QEYvg@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC proposal for adding SORT_STRICT flag to array_unique()
To: Morgan <Weedpacket@varteg.nz>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000e09d510641eeff51"
From: udaltsov.valentin@gmail.com (Valentin Udaltsov)

--000000000000e09d510641eeff51
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=D1=81=D0=B1, 25 =D0=BE=D0=BA=D1=82. 2025=E2=80=AF=D0=B3. =D0=B2 01:18, Mor=
gan <Weedpacket@varteg.nz>:

> On 2025-10-25 08:34, Jason Marble wrote:
> > Hello everybody!
> >
> >
> > The potential for a `SORT_NATURAL` flag also came to mind as another
> > useful addition, but I believe `SORT_STRICT` is the more critical
> > feature to discuss first.
> >
>
> I know I find array_unique generally useless due to its insistence on
> stringifying everything for comparison.
>
> ```
> $uniques =3D [];
> foreach($source_array as $a) {
>      if(!in_array($a, $uniques, true)) {
>          $uniques[] =3D $a;
>      }
> }
> ```
>
> I seem to recall part of the issue is that array_unique works by sorting
> its elements so that "equal" values are adjacent. I know this would be
> done on O(n log(n)) vs. O(n^2) grounds, but that could be addressed at
> least in part by a smarter sort criterion that sorts by type/class (in
> some arbitrary order) before sorting by value. For uncomparable types
> (i.e., instances of most classes) this would be by object ID, because we
> don't _actually_ care about ordering.
>

I would rather propose smth like usort: `array_uunique(array<T>,
callable(T, T): -1|0|1): array<T>`.

--=20
Valentin

--000000000000e09d510641eeff51
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">=D1=81=D0=B1, 25 =D0=BE=D0=BA=D1=82. 2025=
=E2=80=AF=D0=B3. =D0=B2 01:18, Morgan &lt;<a href=3D"mailto:Weedpacket@vart=
eg.nz">Weedpacket@varteg.nz</a>&gt;:</div><div class=3D"gmail_quote gmail_q=
uote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2025-1=
0-25 08:34, Jason Marble wrote:<br>
&gt; Hello everybody!<br>
&gt; <br>
&gt; <br>
&gt; The potential for a `SORT_NATURAL` flag also came to mind as another <=
br>
&gt; useful addition, but I believe `SORT_STRICT` is the more critical <br>
&gt; feature to discuss first.<br>
&gt; <br>
<br>
I know I find array_unique generally useless due to its insistence on <br>
stringifying everything for comparison.<br>
<br>
```<br>
$uniques =3D [];<br>
foreach($source_array as $a) {<br>
=C2=A0 =C2=A0 =C2=A0if(!in_array($a, $uniques, true)) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$uniques[] =3D $a;<br>
=C2=A0 =C2=A0 =C2=A0}<br>
}<br>
```<br>
<br>
I seem to recall part of the issue is that array_unique works by sorting <b=
r>
its elements so that &quot;equal&quot; values are adjacent. I know this wou=
ld be <br>
done on O(n log(n)) vs. O(n^2) grounds, but that could be addressed at <br>
least in part by a smarter sort criterion that sorts by type/class (in <br>
some arbitrary order) before sorting by value. For uncomparable types <br>
(i.e., instances of most classes) this would be by object ID, because we <b=
r>
don&#39;t _actually_ care about ordering.<br>
</blockquote></div><div><br clear=3D"all"></div><div><div>I would rather pr=
opose smth like usort: `array_uunique(array&lt;T&gt;, callable(T, T): -1|0|=
1): array&lt;T&gt;`.</div></div><div><br></div><span class=3D"gmail_signatu=
re_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div di=
r=3D"ltr">Valentin<br></div></div></div>

--000000000000e09d510641eeff51--