Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128840
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>, PHP
 internals <internals@lists.php.net>
Subject: [PHP-DEV] Re: Inconsistency in PHP 8.5 deprecation of terminating case with semicolon
Thread-Topic: Inconsistency in PHP 8.5 deprecation of terminating case with
 semicolon
Thread-Index: AQHcPWfWLSBHm0Rd+0m8YWyzCF9iN7TClTMu
Date: Wed, 15 Oct 2025 04:21:52 +0000
Message-ID:
 <BL4P223MB13645C59490A13076481C3A9DEE8A@BL4P223MB1364.NAMP223.PROD.OUTLOOK.COM>
References: <68EEE5F4.5070105@adviesenzo.nl>
In-Reply-To: <68EEE5F4.5070105@adviesenzo.nl>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BL4P223MB1364:EE_|MN0P223MB1256:EE_
x-ms-office365-filtering-correlation-id: 6c71056b-6702-461d-a607-08de0ba25e4e
x-microsoft-antispam:
 BCL:0;ARA:14566002|12121999013|15030799006|8060799015|8062599012|461199028|31061999003|19110799012|15080799012|3412199025|440099028|4302099013|52005399003|40105399003|10035399007|102099032|1602099012;
x-microsoft-antispam-message-info:
 =?iso-8859-1?Q?d6WZSVRrxRIAS74Jj8zDHaVspXAUq7uMTYz3FTgKbdxRukihP9lP7edMiI?=
 =?iso-8859-1?Q?jDEfuZb0+IP6YDL6KTbJzoA7tx3dw4S2VJ/wqJ2EGNtB+GVy0uMPX4VTJy?=
 =?iso-8859-1?Q?b8A3Zg+Gyc7+CRPH6wOurMTlv4ie8cRvUm9xEkZP8tx82wwAtc04siA21n?=
 =?iso-8859-1?Q?olVzX8nIAM7gpFMNJ9OFaxI3MAkPwefujmKseoMjDvF9GRVHwZ0zvvMuI1?=
 =?iso-8859-1?Q?AEDERArRNhvrtmgAg6SxqwytaE9gnAgoD1Qszgh0SrM35UvsFFRlHX0/+z?=
 =?iso-8859-1?Q?l6vTGoda5QO0VQ6PFKiXI/Yr/NGA7O2lU9Mx4lFSCzEgv0yydZ1rUElz6X?=
 =?iso-8859-1?Q?JSuVfosTjbBF2zSbLJH9oGqAQEan5lg14E5vvwVeeLQP7MliTzXYzokSrE?=
 =?iso-8859-1?Q?nlUb1GlCyKgLd1p1geBVc9l1DzNJ7iTbI1yC1AmRgOBtl2sOmbJ4pmLtdg?=
 =?iso-8859-1?Q?cEkihfnxpzxqkGTobSW3G2ROfK150G8hAs2Stclim8NVNYYahn+t1Dio4h?=
 =?iso-8859-1?Q?1EXrCy28Zk+szhEK29lRZ8WifHJbkeqrkR8RmkCGsOezxPzDpl8PW23e1U?=
 =?iso-8859-1?Q?9kUKfDBhtjqCZDVgjgY24qHLIRtYMSh3yANebt3XbZuhP28ZQzFSpKR/Ti?=
 =?iso-8859-1?Q?+zWFxGINDcN6E5pzhxZF7JMQy2om2b2mHW3hUOVrEHork6D/8m5t77kvuy?=
 =?iso-8859-1?Q?GwDus5KyZpSL0eJgfgKolwWkRm2D0FH7ud+n5iwyUX1n1TLW3Ccmx7DeO+?=
 =?iso-8859-1?Q?ANb0LotJhiSW8GanCiYA90KnXEYcMs4HoB4nObQ1GpdWKKNU+eoUyXHg8W?=
 =?iso-8859-1?Q?/n+lvSPhDlF7DKuYki3vqF+lAyV8HEBOBUsNsHqLAF0pfPef9IFe+0TV2I?=
 =?iso-8859-1?Q?xWw9p8FddTovUyemcSFCEZnPVB7b+EhD4o1rnEJXqyhkU70YbLw9Yva43I?=
 =?iso-8859-1?Q?ozMQtEryWrYRpSzWJfGx6xyc9U1qcKNCvtj05F8n+JzeaWu8iMTUL/jMtE?=
 =?iso-8859-1?Q?VJzK0HNuaBM1WGrdGZk5H3VS9zKsyldBdrMzQI4OpSiYPUaXyKtohD+DnY?=
 =?iso-8859-1?Q?A0L2r2H7yBnO7XaGobU6IsEz3+MMP9iQsJDVyipGxJPYd2IkXOiI4dF85g?=
 =?iso-8859-1?Q?Jd0H2tpeuaHjunpUa9YY0PI0razF9tii5Ft8X87S5fOq+MinBOhw8ID4XN?=
 =?iso-8859-1?Q?BSwAua3oPbulTHM2WUPNhQMbVAiOfnMCU8y+WFB/SI+phh/DPWkCQz8nhh?=
 =?iso-8859-1?Q?tWp7Fv1/jtviBcjyATHwDjhiAsLas1MNkurnFGVHSTOkKhr73poFtz7X3h?=
 =?iso-8859-1?Q?a8D+ItKlBvMBHb2RJ/62laA5PZzdAtG6Rc/8DajmbPYThxEZufP6JLRybL?=
 =?iso-8859-1?Q?C/12+YbquS?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?x7Md8/htqLqC8emBLSPIvmNseKlyDc96Imr/sa81uQ8SaupfPKzWntiH9i?=
 =?iso-8859-1?Q?vnQAe1zrtHVxxRPNGzYZ6J1ahFAqRRaSEjZSNhCLZnDDSVx7zE3JriEJ67?=
 =?iso-8859-1?Q?fYK9yM9lth3U4qdJ8hBWVr07HdFAnU13K5g7F8HhRnpkvVX9nb1h2zsFSh?=
 =?iso-8859-1?Q?Vlwoa0Uh2gDHBpKMvsXWEg6aMzQugRqQjAKxTyIeuZcKNkM/V6TJhYBOxs?=
 =?iso-8859-1?Q?QQvnG0W3lJhleYGhPTL3nObPZL4aQsV7T6XCM7QraV9nNs1w9xkwKPFEU7?=
 =?iso-8859-1?Q?hL7SFK25j0RyGkcAM+7OHsN2H6XZz4CRwVCErH2VTBtMbEdznzOnrJg3ip?=
 =?iso-8859-1?Q?JEvAUg5dXItlWoRhzMl/OCqcrVtROnX3R9M2wogIQpelM7CsWKxjaxU/LE?=
 =?iso-8859-1?Q?72Gwu/nOcdJ4KC205/kU8GTTv/mcAigLHV8t18dT9rW+ucavnKwtZB8aVf?=
 =?iso-8859-1?Q?jldgzcK0N96Z3f0G29FCvLsni5E1emdxlI6j8UMnC41kES40761iD56FA/?=
 =?iso-8859-1?Q?vkENcbSFmYk/2RY3uiWWLFxhd1V8PPjj85Rts7y/XHPdHTsqB9aIj7cpG1?=
 =?iso-8859-1?Q?jHr7g0pI7qrFgT8ihXD8bXKHH91I0I42tQB7kX6HHO9VCwBPIGiEU1EfFO?=
 =?iso-8859-1?Q?GL5mD5tV9z4zfEv1lefgIGUM9PFhVj6a4Ks9a6TlnRDzgdaXEEu/txIkLG?=
 =?iso-8859-1?Q?gBcbxNMmP7opv8MfDUpOu5gpptIVmQHAtXjL2PA+rH6kSsb4k2+ccrrZaC?=
 =?iso-8859-1?Q?Qvvavkij1MuLdHMgVtdlxVRpd/nmY7RdJiz8O7QUurBl4atUj/RjOGk8rF?=
 =?iso-8859-1?Q?3qrNuGHRS6E+VziqI36Um9bd/FbGhaf5BBOA/PNCIkG6dyee/+0G/E8Gde?=
 =?iso-8859-1?Q?H3k7AEKo5+G38UGRds6WtdkdivKBEU6CxTZFo+XzG3QvVAQ35p1AhmP2PL?=
 =?iso-8859-1?Q?1AdqnAyD7FfcDfCjwUoVS4uYY8vXDbOG3AO8FtvU0OyrmDzJgtOdl5sgMt?=
 =?iso-8859-1?Q?c7geJHmUb4JFRhNzOBBqmFllb/02rIyecSYRD7dfkKRfn9ShP1E2tsTY6I?=
 =?iso-8859-1?Q?/5yLGK3I0oZuv5r/qfjZefwOS35qqJtT85cvcq6g1dXG1HJ4VAOLYKNof0?=
 =?iso-8859-1?Q?cnxdIs93M3dHsdt41fxwMn3i+Jwh0Kecfwj1j1Mhmouv0GkvnwAc2+Lpl8?=
 =?iso-8859-1?Q?zHrqZq7Swl/cS66ttTaJSlEHIMpiDqSCdL49KAJvxcbxvREv5Xiwo3Z+K6?=
 =?iso-8859-1?Q?hgccAK1cMeKlV7L0HoPghrYvXc81HfzqIbj7VdsyA=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: list
list-help: <mailto:internals+help@lists.php.net>
list-unsubscribe: <mailto:internals+unsubscribe@lists.php.net>
list-post: <mailto:internals@lists.php.net>
List-Id: <internals.lists.php.net>
x-ms-reactions: disallow
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL4P223MB1364.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c71056b-6702-461d-a607-08de0ba25e4e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2025 04:21:52.7736
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0P223MB1256
From: theodorejb@outlook.com (Theodore Brown)

On Tue, October 14 2025 at 18:08 Juliette Reinders Folmer wrote:=0A=
=0A=
> Dear Theodore and list,=0A=
>=0A=
> I've been looking into the "Deprecate semicolon after case in switch stat=
ement" PHP 8.5 deprecation [1]=0A=
> with the aim of adding a sniff for this to the PHPCompatibility standard =
and I'm noticing an oddity for=0A=
> which I would like to clarify whether this is intentional or an oversight=
.=0A=
>=0A=
> As demonstrated in the example code provided in the deprecation RFC, both=
 switch `case` condition=0A=
> statements, as well as `default` statements, can be ended with a semicolo=
n.=0A=
>=0A=
> So when I first read the RFC, I interpreted the proposal to include both =
`case` as well as `default`,=0A=
> as, in my mind, `default` is just a special `case` in a switch.=0A=
>=0A=
> However, the RFC explicitly only talked about deprecating the use of a se=
micolon after a=0A=
> `case` statement and the implementation has followed this to the letter. =
[2]=0A=
>=0A=
> The net result of this, is that you can now have a `switch` statement wit=
h semicolons=0A=
> terminating `case` statements and `default` statements, where the former =
(`case`) will=0A=
> result in a deprecation notice, while the latter (`default`) will not. Fo=
r an example, see [3]=0A=
>=0A=
> This feels inconsistent to me and counter to the intention of the RFC, wh=
ich is stated to be:=0A=
>=0A=
>> Case statements followed by a semicolon can cause confusion, as a develo=
per may think they=0A=
>> behave differently in some way from regular case statements (e.g. preven=
ting fallthrough),=0A=
>> when they do not.=0A=
>=0A=
> Which leaves me wondering what the reason was not to _also_ deprecate the=
 use of a semicolon=0A=
> to terminate a `default` statement in a switch ? I can't find any discuss=
ion about this in the=0A=
> original mailing list thread [4].=0A=
>=0A=
> Anyone would care to clarify ?=0A=
=0A=
Hi Juliette,=0A=
=0A=
Thank you for pointing out the discrepancy. You are correct that `default` =
is just a special=0A=
case statement, and the intention in the RFC was to output the deprecation =
message for default cases=0A=
as well (the example in the RFC included a default case followed by a semic=
olon to highlight this).=0A=
=0A=
The fact that a deprecation message isn't shown for default cases is an ove=
rsight on my part=0A=
when I implemented the RFC. The merged implementation correctly updated the=
 AST for default=0A=
case statements followed by a semicolon to support the deprecation message,=
 but I failed to=0A=
notice that when the compiler code loops over switch cases, there is a `con=
tinue` statement=0A=
when handling the default case which prevents reaching the code for the dep=
recation.=0A=
=0A=
I opened a follow-up pull request to fix this, which can hopefully be merge=
d before=0A=
PHP 8.5 is released: https://github.com/php/php-src/pull/20172=0A=
=0A=
Kind regards,  =0A=
Theodore=0A=
=0A=
>=0A=
> Smile,  =0A=
> Juliette=0A=
> =0A=
> [1]: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_semicolon_af=
ter_case_in_switch_statement=0A=
> [2]: https://github.com/php/php-src/commit/5f8d648af6ef4e29a3c7f2b2029d08=
466c12bc6f=0A=
> [3]: https://3v4l.org/liFIK/rfc#vgit.master=0A=
> [4]: https://externals.io/message/126000=