Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128750
Message-ID: <CE73D727-9546-469F-A723-FE667CA4061D@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_9D3E1AC2-3625-4064-A475-C6864B89E51F"
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: [PHP-DEV] [Discuss] Add PDO disconnect() and isConnected()
Date: Wed, 1 Oct 2025 09:11:00 +0200
In-Reply-To: <CANdUeaZhn-8b2+LZDV3UnT1sx+BVFcz=m7neQHyv7huGega+_Q@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
To: Robert Wolf <rposky@gmail.com>
References: <CANdUeaZhn-8b2+LZDV3UnT1sx+BVFcz=m7neQHyv7huGega+_Q@mail.gmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail=_9D3E1AC2-3625-4064-A475-C6864B89E51F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 30 sept. 2025 =C3=A0 14:49, Robert Wolf <rposky@gmail.com> a =C3=A9cr=
it :
>=20
> Hello all,
>=20
> I am announcing discussion phase of RFC "Add PDO disconnect() and =
isConnected()". As the title suggests, this proposes to add a PHP =
interface to disconnect a PDO client, an alternative to the object =
destructor.
>=20
> Thank you in advance for your consideration and guidance.
>=20
> https://wiki.php.net/rfc/pdo_disconnect
>=20
> -Robert Wolf
>=20

Hi,=20

I=E2=80=99ve reviewed my uses of mysqli->close() in the wrapper class =
around mysqli I wrote several years ago. All of them were useless, and I =
have just deleted them after having carefully checked the documentation. =
Here is the most obvious case (yes, this is real code):

```php

    public function __destruct() {
        if ($this->link !=3D=3D null) {
            @ $this->link->close();
            $this->link =3D null;
        }
    }

```

I wished that mysqli->close() were never implemented...

Methods like mysqli->close() are innocuous by themselves. The issue is =
that users are tempted, even incited, to do manual operations that are =
very well done automatically (in this case, by the garbage collector). =
They are also driven to ask themselves questions that they don=E2=80=99t =
need to bother (=E2=80=9Cwhat if disconnection fails?=E2=80=9D).

If you still have good reasons to add such a method in pdo. I recommend =
to use a name that deters users from using it in normal operations, e.g. =
pdo->debug_manual_disconnect().

=E2=80=94Claude


--Apple-Mail=_9D3E1AC2-3625-4064-A475-C6864B89E51F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;"><br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>Le 30 sept. 2025 =C3=A0 14:49, Robert Wolf =
&lt;rposky@gmail.com&gt; a =C3=A9crit :</div><br =
class=3D"Apple-interchange-newline"><div><div dir=3D"ltr"><div>Hello =
all,</div><div><br></div>I am announcing discussion phase of RFC "Add =
PDO disconnect() and isConnected()". As the title suggests, this =
proposes to add a PHP interface to disconnect a PDO client, an =
alternative to the object destructor.<div><br></div><div>Thank you in =
advance for your consideration and guidance.<div><br></div><div><a =
href=3D"https://wiki.php.net/rfc/pdo_disconnect">https://wiki.php.net/rfc/=
pdo_disconnect</a><br></div><div><br></div><div>-Robert =
Wolf</div><div><br></div></div></div>
=
</div></blockquote></div><br><div>Hi,&nbsp;</div><div><br></div><div>I=E2=80=
=99ve reviewed my uses of mysqli-&gt;close() in the wrapper class around =
mysqli I wrote several years ago. All of them were useless, and I have =
just deleted them after having carefully checked the documentation. Here =
is the most obvious case (yes, this is real =
code):</div><div><br></div><div>```php</div><div><br></div><div><div>&nbsp=
; &nbsp; public function __destruct() {</div><div>&nbsp; &nbsp; &nbsp; =
&nbsp; if ($this-&gt;link !=3D=3D null) {</div><div>&nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; @ $this-&gt;link-&gt;close();</div><div>&nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; $this-&gt;link =3D =
null;</div><div>&nbsp; &nbsp; &nbsp; &nbsp; }</div><div>&nbsp; &nbsp; =
}</div><div><br></div></div><div>```</div><div><br></div><div>I wished =
that mysqli-&gt;close() were never =
implemented...</div><div><br></div><div>Methods like mysqli-&gt;close() =
are innocuous by themselves. The issue is that users are tempted, even =
incited, to do manual operations that are very well done automatically =
(in this case, by the garbage collector). They are also driven to ask =
themselves questions that they don=E2=80=99t need to bother (=E2=80=9Cwhat=
 if disconnection fails?=E2=80=9D).</div><div><br></div><div>If you =
still have good reasons to add such a method in pdo. I recommend to use =
a name that deters users from using it in normal operations, e.g. =
pdo-&gt;debug_manual_disconnect().</div><div><br></div><div>=E2=80=94Claud=
e</div><div><br></div></body></html>=

--Apple-Mail=_9D3E1AC2-3625-4064-A475-C6864B89E51F--