Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128743
Precedence: list
MIME-Version: 1.0
References: <CANdUeaZhn-8b2+LZDV3UnT1sx+BVFcz=m7neQHyv7huGega+_Q@mail.gmail.com>
 <CAGBsUrd_-6UmqedKs1x95Uj2bb8GkBvYHJaFkvrnnoKTq_O=QA@mail.gmail.com>
In-Reply-To: <CAGBsUrd_-6UmqedKs1x95Uj2bb8GkBvYHJaFkvrnnoKTq_O=QA@mail.gmail.com>
Date: Tue, 30 Sep 2025 17:42:30 +0300
Message-ID: <CAPhkiZyYL72x93E-M2BNAN7vfN-7DSNmoXvS+KOSPgAoo7qjSg@mail.gmail.com>
Subject: Re: [PHP-DEV] [Discuss] Add PDO disconnect() and isConnected()
To: Kamil Tekiela <tekiela246@gmail.com>
Cc: Robert Wolf <rposky@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000aadefd064005c30c"
From: narf@devilix.net (Andrey Andreev)

--000000000000aadefd064005c30c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 30, 2025 at 4:56=E2=80=AFPM Kamil Tekiela <tekiela246@gmail.com=
> wrote:

> I find this proposal to be a backwards step in the age when we are
> moving away from resources and their explicit closure. We have
> disabled this in PHP 8.0 for curl_close(), imagedestroy(),
> openssl_pkey_free(), shmop_close() and xml_parser_free(). Sure,
> mysqli_close() still works, but the whole extension is mostly a
> historical artefact and a bunch of bad design choices due to what that
> extension is (quick replacement of mysql_* API). PDO was designed much
> better and it deliberately avoided the foot gun that is explicit
> connection closure. I really wish we would not introduce bad design
> choices into the language, and because of this, I wish this proposal
> were unsuccessful.
>

All of the foot gun examples you listed are such because that historic
design pattern *required* explicit resource frees, and they are foot guns
because it is easy to forget doing that.
Also, mysqli_close() is the only one that handles a stateful network
connection and not a local resource, which is a good reason why it still
works.

There are legitimate use cases where you may want to explicitly and
immediately close a network connection, even if PHP would do it eventually.

Cheers,
Andrey.

--000000000000aadefd064005c30c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div dir=
=3D"ltr" class=3D"gmail_attr">On Tue, Sep 30, 2025 at 4:56=E2=80=AFPM Kamil=
 Tekiela &lt;<a href=3D"mailto:tekiela246@gmail.com">tekiela246@gmail.com</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I =
find this proposal to be a backwards step in the age when we are<br>
moving away from resources and their explicit closure. We have<br>
disabled this in PHP 8.0 for curl_close(), imagedestroy(),<br>
openssl_pkey_free(), shmop_close() and xml_parser_free(). Sure,<br>
mysqli_close() still works, but the whole extension is mostly a<br>
historical artefact and a bunch of bad design choices due to what that<br>
extension is (quick replacement of mysql_* API). PDO was designed much<br>
better and it deliberately avoided the foot gun that is explicit<br>
connection closure. I really wish we would not introduce bad design<br>
choices into the language, and because of this, I wish this proposal<br>
were unsuccessful.<br></blockquote><div><br></div><div>All of the foot gun =
examples you listed are such because that historic design pattern *required=
* explicit resource frees, and they are foot guns because it is easy to for=
get doing that.</div><div>Also, mysqli_close() is the only one that handles=
 a stateful network connection and not a local resource, which is a good re=
ason why it still works.</div><div><br></div><div>There are legitimate use =
cases where you may want to explicitly and immediately close a network conn=
ection, even if PHP would do it eventually.</div><div><br></div><div>Cheers=
,</div><div>Andrey.</div></div></div>

--000000000000aadefd064005c30c--