Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128630
Date: Thu, 04 Sep 2025 10:40:46 +0200
To: PHP internals list <internals@lists.php.net>, 
 Matteo Beccati <php@beccati.com>
Message-ID: <568a0b0e0228b340f7993e2b66b299fa9685d400@hey.com>
In-Reply-To: <f9b5c55d-638d-4ccd-8b9f-196364c427cd@beccati.com>
Subject: Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute
Precedence: list
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_68b9508eab338_8c2015045816";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
From: samuel@archte.ch (=?UTF-8?B?U2FtdWVsIMWgdGFuY2w=?=)
References: <f9b5c55d-638d-4ccd-8b9f-196364c427cd@beccati.com>


----==_mimepart_68b9508eab338_8c2015045816
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Matteo,

From reading earlier discussions my understanding is the feature freeze
only applies to things that need RFCs. With PRs that add simple
constants not necessarily needing an RFC.

Personally I think the diff in the linked PR itself matches that
description well, while the alternative implementation in the comment
seems more likely to need an RFC.

If I need RM approval how would I go about that. Email one of the RMs
individually?

Thank you.

Samuel =C5=A0tancl

On September 4, 2025, Matteo Beccati <php@beccati.com> wrote:
> Hi Samuel,
>
> Il 04/09/2025 00:38, Samuel =C5=A0tancl ha scritto:
> > Hi,
> >=C2=A0
> > Is there anything I could do here to get this reviewed before the
> 8.5=C2=A0
> > release? As mentioned earlier the proposed implementation should not
> be=C2=A0
> > subject to the feature freeze.
> >=C2=A0
> > https://github.com/php/php-src/pull/19317
> <https://github.com/php/php-=C2=A0
> > src/pull/19317>
>
> I think the 8.5 ship has sailed. Why should it not be subject to
> feature=C2=A0
> freeze? It surely is, unless the RMs approve it.
>
>
> Cheers
> --=C2=A0
> Matteo Beccati

----==_mimepart_68b9508eab338_8c2015045816
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html>
<html>
  <head>
    <meta charset=3D"utf-8">
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf=
-8" />
    <meta name=3D"viewport" id=3D"viewport" content=3D"width=3Ddevice-wid=
th,minimum-scale=3D1.0,maximum-scale=3D10.0,initial-scale=3D1.0" />

    <style>
      html {
  -webkit-text-size-adjust: 100%;
  -ms-text-size-adjust: 100%;
}

h1 {
  font-size: 1.3em;
  line-height: 1.2;
  margin: 0;
}

ul,
ol {
  margin: 0;
  padding: 0;
}

ul li,
ol li,
li li {
  margin: 0 0 0 36px;
}

[dir=3Drtl] li {
  margin: 0 18px 0 0;
}

blockquote {
  border-color: #dfdee1; /* --color--border */
  border-style: solid;
  border-width: 0 0 0 1px;
  margin: 0;
  padding: 0 0 0 1em;
}

[dir=3Drtl] blockquote,
blockquote[dir=3Drtl] {
  border-width: 0 1px 0 0;
  padding: 0 1em 0 0;
}

pre {
  font-family: "SFMono-Regular", Consolas, "Liberation Mono", Menlo, Cour=
ier, monospace; /* --font-family--mono */
  font-size: 0.9em;
  margin: 0;
  padding: 1rem;
  background-color: #f3f1ef; /* --color-bg--surface */
  white-space: pre-wrap;
  word-wrap: break-word;
  overflow: visible;
}

.message-content {
  font-family: -apple-system, BlinkMacSystemFont, Aptos, Roboto, "Segoe U=
I", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", =
"Segoe UI Symbol"; /* --font-family */
  line-height: 1.4;
}

.attachment {
  display: inline-block;
  margin: 0;
  padding: 0;
}

.attachment__caption {
  padding: 0;
  text-align: center;
}

.attachment__caption a[href] {
  text-decoration: none;
  color: #333333;
}

.attachment--preview {
  width: 100%;
  text-align: center;
  margin: 0.625em 0;
}

.attachment--preview img {
  border: 1px solid #dfdee1; /* --color--border */
  vertical-align: middle;
  width: auto;
  max-width: 100%;
  max-height: 640px;
}

.attachment--preview .attachment__caption {
  color: #716d7b;  /* --color-txt--subtle */
  font-size: 0.85em;
  margin-top: 0.625em;
}

.attachment--file {
  color: #282138; /* --color-txt */
  line-height: 1;
  margin: 0 2px 2px 0;
  padding: 0.4em 1em;
  border: 1px solid #dfdee1; /* --color--border */
  border-radius: 5px;
}

.permalink {
  color: inherit;
}

.txt--subtle {
  color: #716d7b;  /* --color-txt--subtle */
}

.txt--xx-small {
  font-size: 14px;
}

.flush {
  margin: 0;
  padding: 0;
}

.push--bottom {
  margin-bottom: 8px;
}

.border--top {
  border-top: 1px solid #ECE9E6; /* --color-border--solid */
}

.btn {
  padding: 0.2em 0.4em;
  font-weight: 500;
  text-decoration: none;
  border-radius: 3rem;
  white-space: nowrap;
  background: #5522FA; /* --color-tertiary */
  border-color: #5522FA;
  color: #ffffff;
}

.btn--email {
  display: inline-block;
  text-align: center;
  font-weight: 500;
  font-size: 1em;
  text-decoration: none;
  border-radius: 2em;
  white-space: nowrap;
  background: #5522FA; /* --color-tertiary */
  border-color: #5522FA;
  color: #ffffff;
  border-top: 0.3em solid #5522FA;
  border-left: 1em solid #5522FA;
  border-bottom: 0.3em solid #5522FA;
  border-right: 1em solid #5522FA;
}

.shaded {
  padding: 1em;
  border-radius: 4px;
  background-color: #f6f5f3; /* --color-bg--surface */
  border: 1px solid #dfdee1; /* --color--border */
}

.shaded--blue {
  background-color: rgba(80, 162, 255, 0.2); /* --rgb-blue 0.2 */
}

.shaded--red {
  background-color: rgba(255, 120, 120, 0.2); /* --rgb-red 0.2 */
}

.strikethrough {
  text-decoration: line-through;
}

    </style>
  </head>

  <body>
    <div class=3D"message-content">
      <div class=3D"trix-content">
  <div>Hi Matteo,<br><br>From reading earlier discussions my understandin=
g is the feature freeze only applies to things that need RFCs. With PRs t=
hat add simple constants not necessarily needing an RFC.<br><br>Personall=
y I think the diff in the linked PR itself matches that description well,=
 while the alternative implementation in the comment seems more likely to=
 need an RFC.<br><br>If I need RM approval how would I go about that. Ema=
il one of the RMs individually?<br><br>Thank you.<br><br></div><div>Samue=
l =C5=A0tancl</div><div><br><br></div><div>On September 4, 2025, Matteo B=
eccati &lt;php@beccati.com&gt; wrote:</div><blockquote>Hi Samuel,<br><br>=
Il 04/09/2025 00:38, Samuel =C5=A0tancl ha scritto:<br>&gt; Hi,<br>&gt;=C2=
=A0<br>&gt; Is there anything I could do here to get this reviewed before=
 the 8.5=C2=A0<br>&gt; release? As mentioned earlier the proposed impleme=
ntation should not be=C2=A0<br>&gt; subject to the feature freeze.<br>&gt=
;=C2=A0<br>&gt; https://github.com/php/php-src/pull/19317 &lt;https://git=
hub.com/php/php-=C2=A0<br>&gt; src/pull/19317&gt;<br><br>I think the 8.5 =
ship has sailed. Why should it not be subject to feature=C2=A0<br>freeze?=
 It surely is, unless the RMs approve it.<br><br><br>Cheers<br>--=C2=A0<b=
r>Matteo Beccati</blockquote>
</div>


    </div>
  </body>
</html>

----==_mimepart_68b9508eab338_8c2015045816--