Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128595
Message-ID: <93d89063-b7ae-4266-a3b8-90c06117c1a3@varteg.nz>
Date: Sat, 30 Aug 2025 09:11:39 +1200
Precedence: list
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add clamp function
To: internals@lists.php.net
References: <CADyq6sKVyL=Ck_OeBwe+EQH1Lz0s_X1Qf3yM4H6cQg3sykMN_g@mail.gmail.com>
 <1756361767126.3727989781.4204927711@yahoo.de>
 <3b1bd29cd42074b499d38e10cb97bf42@bastelstu.be>
 <CANBC5npgHSSUw=irGcCAXtwY54SyFL6EC9qCGpAoa=j1_Bt5vQ@mail.gmail.com>
 <ea96837d-3181-4a9e-b058-14599ecfa615@bastelstu.be>
 <4db81c8b-64ee-4bf6-9134-c233c8cb3f71@varteg.nz>
 <d62eb709-fc4c-42da-96a1-9299756f000c@bastelstu.be>
Content-Language: en-GB
In-Reply-To: <d62eb709-fc4c-42da-96a1-9299756f000c@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: weedpacket@varteg.nz (Morgan)

On 2025-08-30 01:10, Tim Düsterhus wrote:
> Hi
> 
> On 8/29/25 04:42, Morgan wrote:
>> Another part of the argument is "complexity", as brought up in the
>> original proposal. I notice that the offered implementation of this
>> function relies entirely on zend_compare().
> 
> I'm not finding the word “complexity” in https://wiki.php.net/rfc/clamp 
> or https://externals.io/message/115050. Can you link to the message you 
> are referring to?
> 
I'm probably misremembering https://externals.io/message/128505#128532 
and #128542.

>> reasons. The extra complication may not be worth it if there are only
>> two or three values being compared (long and double are the first types
>> zend_compare tries).
> 
> I'm positive that the benchmarks will answer that question.
> 
Agreed. But if clamp doesn't need to special-case numeric inputs to 
perform well then maybe max/min don't either (at least not any more) and 
their implementations could be streamlined.

> Best regards
> Tim Düsterhus