Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128579
Precedence: list
MIME-Version: 1.0
Date: Thu, 28 Aug 2025 09:29:58 +0200
To: Marco Pivetta <ocramius@gmail.com>
Cc: Kyle Katarn <kylekatarnls@gmail.com>, PHP Internals
 <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add clamp function
In-Reply-To: <CADyq6sKVyL=Ck_OeBwe+EQH1Lz0s_X1Qf3yM4H6cQg3sykMN_g@mail.gmail.com>
References: <CANBC5npwi3azjJwf3p0mWeNpEWvKpY9yuNQreX3A6MJBAwFWPg@mail.gmail.com>
 <CADyq6sKVyL=Ck_OeBwe+EQH1Lz0s_X1Qf3yM4H6cQg3sykMN_g@mail.gmail.com>
Message-ID: <3314b2f7e74a45a45c3c6626fd0159e9@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-08-27 17:45, schrieb Marco Pivetta:
> I know this isn't very used in internals, but does it make sense to 
> write
> generics for the generated stubs of this function?

The stub generator makes use of the types provided in the PHPDoc comment 
to generate optimizer information. The stub generator has no support for 
generic types (or things like array shapes), which makes this risky. The 
information is not used, it is not tested and it might confuse the stub 
generator.

See https://github.com/php/php-src/pull/19546 as an example.

If there is an interest in having generics in the stubs, the stub 
generator should first be extended to handle them, even if it does not 
(yet) use the information and then it should be consistently applied to 
the entirety of PHP's stdlib.

Best regards
Tim Düsterhus