Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128542
Precedence: list
MIME-Version: 1.0
References: <CANBC5np5gFoG2vy572K_rV5df58qBJdQuKsmYdHiprA2mLPWUg@mail.gmail.com>
 <c9acda400885e3c78775e400cb492538@bastelstu.be> <CANBC5noypta7=YvVaAB6sPFhQKQCxJTFMQZ7fEShii2isya49A@mail.gmail.com>
 <0027ab13-89fb-40b4-991b-2f88a35c2f31@gmx.de> <CANBC5npgKA2T51t9=CD8LcqZsbLY-mW1GUepyGkZLPEGtVxoPA@mail.gmail.com>
 <011001dc1358$287f1860$797d4920$@glaive.pro> <CANBC5nppDhGpuRw_yCWrWfNLoweb8LAgbtMAyh5R37HZwx-dkg@mail.gmail.com>
 <70b0d91d-c415-42b5-b02d-7e346efaea01@varteg.nz>
In-Reply-To: <70b0d91d-c415-42b5-b02d-7e346efaea01@varteg.nz>
Date: Sun, 24 Aug 2025 16:27:15 +0200
Message-ID: <CANBC5nrQorLdE1n77Dckzi5O-q6zJGJ+xyJbDEh+wET07iDUgQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Add clamp function
To: Weedpacket@varteg.nz
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000ea67ab063d1d3c42"
From: kylekatarnls@gmail.com (Kyle Katarn)

--000000000000ea67ab063d1d3c42
Content-Type: text/plain; charset="UTF-8"

2025-08-22 at 22:29, Morgan <Weedpacket@varteg.nz> wrote:

> On 2025-08-23 05:29, Kyle Katarn wrote:
> >
> > Also from my point of view,  min($max, max($min, $value)) has a counter-
> > intuitive reading when used to clamp a value.
>
> Well, that's trivial to deal with:
>
> min(max($min, $value), $max));
>

It's not just about the order of parameters, it's still not intuitive to
call max() with $min and min() with $max, you still have to think about
what it does step by step to make sense out of it, while clamp($value, min:
$min, $max) or clamp(min: $min, value: $value, max: $max) will provide a
syntax that immediately make sense for next reader.

Like the author of the RFC v1 also mentioned, min(max()) is inefficient
(see the inner complexity of those functions).

--000000000000ea67ab063d1d3c42
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">2025-08-22 at 22:29, Morgan &lt;<a href=
=3D"mailto:Weedpacket@varteg.nz">Weedpacket@varteg.nz</a>&gt; wrote:</div><=
div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">On 2025-08-23 05:29, Kyle Katarn wrote:<br>
&gt; <br>
&gt; Also from my point of view,=C2=A0 min($max, max($min, $value)) has a c=
ounter- <br>
&gt; intuitive reading when used to clamp a value.<br>
<br>
Well, that&#39;s trivial to deal with:<br>
<br>
min(max($min, $value), $max));<br></blockquote><div><br></div><div>It&#39;s=
 not just about the order of parameters, it&#39;s still not intuitive to ca=
ll max() with $min and min() with $max, you still have to think=C2=A0about =
what it does step by step to make sense out of it, while clamp($value, min:=
 $min, $max) or clamp(min: $min, value: $value, max: $max) will provide a s=
yntax that immediately make sense for next reader.</div><div><br></div><div=
>Like the author of the RFC v1 also mentioned, min(max()) is inefficient (s=
ee the inner complexity of those functions).=C2=A0</div></div></div>

--000000000000ea67ab063d1d3c42--