Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128530
Feedback-ID: i8414410d:Fastmail
Precedence: list
MIME-Version: 1.0
Date: Fri, 22 Aug 2025 11:06:45 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <272c241b-3145-4069-8a6a-9ea877f936c0@app.fastmail.com>
In-Reply-To: 
 <CANBC5npgKA2T51t9=CD8LcqZsbLY-mW1GUepyGkZLPEGtVxoPA@mail.gmail.com>
References: 
 <CANBC5np5gFoG2vy572K_rV5df58qBJdQuKsmYdHiprA2mLPWUg@mail.gmail.com>
 <c9acda400885e3c78775e400cb492538@bastelstu.be>
 <CANBC5noypta7=YvVaAB6sPFhQKQCxJTFMQZ7fEShii2isya49A@mail.gmail.com>
 <0027ab13-89fb-40b4-991b-2f88a35c2f31@gmx.de>
 <CANBC5npgKA2T51t9=CD8LcqZsbLY-mW1GUepyGkZLPEGtVxoPA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Add clamp function
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, Aug 22, 2025, at 3:01 AM, Kyle Katarn wrote:
> 2025-08-20 at 14:28, Christoph M. Becker <cmbecker69@gmx.de> wrote :
>> On 20.08.2025 at 09:29, Kyle Katarn wrote:
>>=20
>> > 2025-08-19 14:59, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote :>>>
>> https://wiki.php.net/rfc/howto#external_resources#rfcs_belong_to_a_si=
ngle_author <https://wiki.php.net/rfc/howto#external_resources%23rfcs_be=
long_to_a_single_author>
>> >> (the "RFCs 'belong' to a single author") section. The existing RFC=
 may
>> >> only be adjusted with the original author=E2=80=99s consent. It mi=
ght be easiest
>> >> for you to create a =E2=80=9Cclamp function v2=E2=80=9D RFC instea=
d.
>> >=20
>> > Thanks, when I go to https://wiki.php.net/RFC/clamp-v2 and click "E=
dit the
>> > page", it says:
>> > "Sorry, you don't have enough rights to continue."
>> >=20
>> > Can you grant me this permission? Thanks.
>>=20
>> I've granted RFC karma to the kylekatarnls account; there is also a
>> kylek account, though?  Can that be removed?
>>=20
>> Christoph
>
> Thanks, yes "kylek" account can be removed.
>
> I created https://wiki.php.net/rfc/clamp_v2 (re-using most of the info=20
> from https://wiki.php.net/rfc/clamp).
>
> Thanks for you

The grammar in this one sentence is very clumsy:

> clamp takes three arguments, a $num, $min and $max, checks if $num is =
within the bounds of $min and $max, if in range, returns the value of $n=
um, otherwise, returns the nearest bound value, i.e. if $num > $max retu=
rn $max, if $num < $min return $min.=20

Please break it up into multiple sentences so it's easier to follow.  I =
think I follow it, but it's clunky enough that I am not certain of it. :=
-)

Also, the text says $num but the code example says $value.

What determines comparability?  What happens if you try to clamp values =
that are not comparable?  Eg:

clamp(new Point(1, 2), new Point(0, 0), new Point(5, 5));

I assume that will fail somehow, but the failure should be described exp=
licitly.

--Larry Garfield