Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128452
Precedence: list
MIME-Version: 1.0
References: <CAEwRQKZBZxV6D6qcpEduY5Er_+du+mWyrK-c+SQCwkNCQwKwHQ@mail.gmail.com>
 <CAPyj-LCT6xiZ1a1VbVEN=7mq6VGJsR8Ytu3i0tW0qV0BAVd=hg@mail.gmail.com>
In-Reply-To: <CAPyj-LCT6xiZ1a1VbVEN=7mq6VGJsR8Ytu3i0tW0qV0BAVd=hg@mail.gmail.com>
Date: Tue, 12 Aug 2025 14:40:15 +0200
Message-ID: <CAPyj-LCaOtC-E=1LCW0HqwDauB1M94FoN4jsRA2Z0rnMf-chiQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Test coverage
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Vinicius

On Thu, Aug 7, 2025 at 5:44=E2=80=AFPM Ilija Tovilo <tovilo.ilija@gmail.com=
> wrote:
>
> Hi Vinicius
>
> On Thu, Aug 7, 2025 at 5:20=E2=80=AFPM Vinicius Dias <carlosv775@gmail.co=
m> wrote:
> >
> > I would like to know how or where I can find the code coverage for
> > php-src to see if there is any uncovered code I might be able to
> > contribute with new tests.
>
> It lives here:
>
> https://app.codecov.io/github/php/php-src
>
> However, it seems it's currently borked. The nightly job succeeded, so
> I'm not immediately sure what's wrong. I'll put it on my list, unless
> somebody beats me to it.

Looks like whatever issue there was fixed itself. I'm happy to review
any patches improving coverage.

There are some inaccuracies with tracking, i.e. some executed lines
are marked as red. This happens often for macros that insert branches
that are never taken (and aren't intended to be taken).

We also don't care about the failure paths of the Z_PARAM_ macros.
These are tested sufficiently, so we don't need to repeat the same
test for every function.

Thanks!
Ilija