Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128448
Date: Tue, 12 Aug 2025 03:07:51 +0200
To: internals@lists.php.net, 
 Morgan <weedpacket@varteg.nz>
Message-ID: <fa26b8a1da9befef2d52cde436d96721a6263f3b@hey.com>
In-Reply-To: <32e94668-a516-41d8-90b5-72a0bae3852f@varteg.nz>
Subject: Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute
Precedence: list
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_689a93e7a02e0_2320130112819";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
From: samuel@archte.ch (=?UTF-8?B?U2FtdWVsIMWgdGFuY2w=?=)
References: <32e94668-a516-41d8-90b5-72a0bae3852f@varteg.nz>


----==_mimepart_689a93e7a02e0_2320130112819
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

By enums I'm assuming you mean PHP enums. That could work and would
solve my issue of trying to represent the values of the attribute (only
thing I'm not sure about is Pdo\SqliteTransactionMode being directly in
the Pdo namespace). I've included a sample implementation in this
comment <https://github.com/php/php-src/pull/19317#issuecomment-
3177353751>

On August 12, 2025, Morgan <weedpacket@varteg.nz> wrote:
> On 2025-08-12 07:35, Samuel =C5=A0tancl wrote:
> > Hi, I've opened a PR adding a new attribute to PDO\Sqlite: https://
> > github.com/php/php-src/pull/19317 <<https://github.com/php/php-
> src/>=C2=A0
> > pull/19317?=C2=A0
> >
> notification_referrer_id=3DNT_kwDOAfgLhrQxNzkxMjcwMjYzOTozMzAzMzA5NA#is=
suecomment-
> 3176177745>
> >=C2=A0
> As far as the form the attribute takes goes, an Enum with the values=C2=
=A0
> DEFERRED/IMMEDIATE/EXCLUSIVE would do the job.
>
> (As for calling it an attribute, I thought at first that what was
> being=C2=A0
> suggested was an Attribute, rather than a connection option.)

----==_mimepart_689a93e7a02e0_2320130112819
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html>
<html>
  <head>
    <meta charset=3D"utf-8">
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf=
-8" />
    <meta name=3D"viewport" id=3D"viewport" content=3D"width=3Ddevice-wid=
th,minimum-scale=3D1.0,maximum-scale=3D10.0,initial-scale=3D1.0" />

    <style>
      html {
  -webkit-text-size-adjust: 100%;
  -ms-text-size-adjust: 100%;
}

h1 {
  font-size: 1.3em;
  line-height: 1.2;
  margin: 0;
}

ul,
ol {
  margin: 0;
  padding: 0;
}

ul li,
ol li,
li li {
  margin: 0 0 0 36px;
}

[dir=3Drtl] li {
  margin: 0 18px 0 0;
}

blockquote {
  border-color: #dfdee1; /* --color--border */
  border-style: solid;
  border-width: 0 0 0 1px;
  margin: 0;
  padding: 0 0 0 1em;
}

[dir=3Drtl] blockquote,
blockquote[dir=3Drtl] {
  border-width: 0 1px 0 0;
  padding: 0 1em 0 0;
}

pre {
  font-family: "SFMono-Regular", Consolas, "Liberation Mono", Menlo, Cour=
ier, monospace; /* --font-family--mono */
  font-size: 0.9em;
  margin: 0;
  padding: 1rem;
  background-color: #f3f1ef; /* --color-bg--surface */
  white-space: pre-wrap;
  word-wrap: break-word;
  overflow: visible;
}

.message-content {
  font-family: -apple-system, BlinkMacSystemFont, Aptos, Roboto, "Segoe U=
I", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", =
"Segoe UI Symbol"; /* --font-family */
  line-height: 1.4;
}

.attachment {
  display: inline-block;
  margin: 0;
  padding: 0;
}

.attachment__caption {
  padding: 0;
  text-align: center;
}

.attachment__caption a[href] {
  text-decoration: none;
  color: #333333;
}

.attachment--preview {
  width: 100%;
  text-align: center;
  margin: 0.625em 0;
}

.attachment--preview img {
  border: 1px solid #dfdee1; /* --color--border */
  vertical-align: middle;
  width: auto;
  max-width: 100%;
  max-height: 640px;
}

.attachment--preview .attachment__caption {
  color: #716d7b;  /* --color-txt--subtle */
  font-size: 0.85em;
  margin-top: 0.625em;
}

.attachment--file {
  color: #282138; /* --color-txt */
  line-height: 1;
  margin: 0 2px 2px 0;
  padding: 0.4em 1em;
  border: 1px solid #dfdee1; /* --color--border */
  border-radius: 5px;
}

.permalink {
  color: inherit;
}

.txt--subtle {
  color: #716d7b;  /* --color-txt--subtle */
}

.txt--xx-small {
  font-size: 14px;
}

.flush {
  margin: 0;
  padding: 0;
}

.push--bottom {
  margin-bottom: 8px;
}

.border--top {
  border-top: 1px solid #ECE9E6; /* --color-border--solid */
}

.btn {
  padding: 0.2em 0.4em;
  font-weight: 500;
  text-decoration: none;
  border-radius: 3rem;
  white-space: nowrap;
  background: #5522FA; /* --color-tertiary */
  border-color: #5522FA;
  color: #ffffff;
}

.btn--email {
  display: inline-block;
  text-align: center;
  font-weight: 500;
  font-size: 1em;
  text-decoration: none;
  border-radius: 2em;
  white-space: nowrap;
  background: #5522FA; /* --color-tertiary */
  border-color: #5522FA;
  color: #ffffff;
  border-top: 0.3em solid #5522FA;
  border-left: 1em solid #5522FA;
  border-bottom: 0.3em solid #5522FA;
  border-right: 1em solid #5522FA;
}

.shaded {
  padding: 1em;
  border-radius: 4px;
  background-color: #f6f5f3; /* --color-bg--surface */
  border: 1px solid #dfdee1; /* --color--border */
}

.shaded--blue {
  background-color: rgba(80, 162, 255, 0.2); /* --rgb-blue 0.2 */
}

.shaded--red {
  background-color: rgba(255, 120, 120, 0.2); /* --rgb-red 0.2 */
}

.strikethrough {
  text-decoration: line-through;
}

    </style>
  </head>

  <body>
    <div class=3D"message-content">
      <div class=3D"trix-content">
  <div>By enums I&#39;m assuming you mean PHP enums. That could work and =
would solve my issue of trying to represent the values of the attribute (=
only thing I&#39;m not sure about is Pdo\SqliteTransactionMode being dire=
ctly in the Pdo namespace). I&#39;ve included a sample implementation in =
this comment <a href=3D"https://github.com/php/php-src/pull/19317#issueco=
mment-3177353751">https://github.com/php/php-src/pull/19317#issuecomment-=
3177353751</a></div><div><br><br></div><div>On August 12, 2025, Morgan &l=
t;weedpacket@varteg.nz&gt; wrote:</div><blockquote>On 2025-08-12 07:35, S=
amuel =C5=A0tancl wrote:<br>&gt; Hi, I&#39;ve opened a PR adding a new at=
tribute to PDO\Sqlite: https:// <br>&gt; github.com/php/php-src/pull/1931=
7 &lt;<a href=3D"https://github.com/php/php-src/">https://github.com/php/=
php-src/</a>=C2=A0<br>&gt; pull/19317?=C2=A0<br>&gt; notification_referre=
r_id=3DNT_kwDOAfgLhrQxNzkxMjcwMjYzOTozMzAzMzA5NA#issuecomment-3176177745&=
gt;<br>&gt;=C2=A0<br>As far as the form the attribute takes goes, an Enum=
 with the values=C2=A0<br>DEFERRED/IMMEDIATE/EXCLUSIVE would do the job.<=
br><br>(As for calling it an attribute, I thought at first that what was =
being=C2=A0<br>suggested was an Attribute, rather than a connection optio=
n.)</blockquote>
</div>


    </div>
  </body>
</html>

----==_mimepart_689a93e7a02e0_2320130112819--