Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128349
Feedback-ID: id5114917:Fastmail
Content-Type: multipart/alternative;
 boundary="------------wt5IeCCUakya6GINMectBPv9"
Message-ID: <33e35f41-8d8d-4413-a36c-4cba4aa413a9@rwec.co.uk>
Date: Thu, 31 Jul 2025 16:53:10 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Optional Catch Block Body
Content-Language: en-GB
To: internals@lists.php.net
References: <CAJWOiuN8fuejkX1Tj0h=s_Fs2bGEtz-qdMZxRTC1s4at23y=Vw@mail.gmail.com>
 <095f25f5-695b-46d4-9f31-5d7e7a04ce05@rwec.co.uk>
 <CANS-=peEKJRT0nZeCQPLah-rg0pDd1F1JecvAj95ya0MP8JNPg@mail.gmail.com>
 <a12e42bf-fd60-45c6-a2f6-91308cb0cb32@rwec.co.uk>
 <7E01A890-E986-4156-B598-ECD07264C39A@cschneid.com>
In-Reply-To: <7E01A890-E986-4156-B598-ECD07264C39A@cschneid.com>
From: imsop.php@rwec.co.uk ("Rowan Tommins [IMSoP]")

This is a multi-part message in MIME format.
--------------wt5IeCCUakya6GINMectBPv9
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 31/07/2025 14:46, Christian Schneider wrote:
>> $fh = try fopen($filePath, 'w') ignore (FileLockedException);
> First of all: I'm wary because partial error handling seems dangerous to mel do I know all possible Exception types and which ones should abort and which ones should continue?


That's kind of the point: it's for when you know how to handle some 
specific cases, but want *anything else* to abort.

In this hypothetical example, the code is using an exclusive lock to 
avoid two processes writing to the file; it wants to gracefully handle 
the specific scenario of "some other process has the lock". If there's 
some other error, like "invalid file path", that *should not* be suppressed.

But the current PHP I/O functions give no way to distinguish:

$fh = @fopen($filePath, 'w');
if ( $fh === false ) {
     // probably something else had the lock; could also be an invalid 
file path, or a catastrophic disk failure ¯\_(ツ)_/¯
}


> I have to admit that I'm also a sceptic of converting every possible info/warning/error to an Exception but that's a different topic


I didn't intend to imply that this would replace all Warnings. Think of 
it more as replacing the "returns false on error" part of the fopen() 
signature.


> If we decide to add something like the above I would very much prefer the try ... ignore block to be an expression with value null on error, making the first line obsolete.


Good point, I agree.


-- 
Rowan Tommins
[IMSoP]

--------------wt5IeCCUakya6GINMectBPv9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 31/07/2025 14:46, Christian
      Schneider wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:7E01A890-E986-4156-B598-ECD07264C39A@cschneid.com">
      <pre class="moz-quote-pre" wrap=""><blockquote type="cite"
      style="color: #007cff;"><pre wrap="" class="moz-quote-pre">$fh = try fopen($filePath, 'w') ignore (FileLockedException);
</pre></blockquote><pre wrap="" class="moz-quote-pre">First of all: I'm wary because partial error handling seems dangerous to mel do I know all possible Exception types and which ones should abort and which ones should continue?</pre></pre>
    </blockquote>
    <p><br>
    </p>
    <p>That's kind of the point: it's for when you know how to handle
      some specific cases, but want *anything else* to abort.</p>
    <p>In this hypothetical example, the code is using an exclusive lock
      to avoid two processes writing to the file; it wants to gracefully
      handle the specific scenario of "some other process has the lock".
      If there's some other error, like "invalid file path", that
      *should not* be suppressed.</p>
    <p>But the current PHP I/O functions give no way to distinguish:</p>
    $fh = @fopen($filePath, 'w');<br>
    if ( $fh === false ) {<br>
        // probably something else had the lock; could also be an
    invalid file path, or a catastrophic disk failure ¯\_(ツ)_/¯<br>
    }<br>
    <p><br>
    </p>
    <p>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">I have to admit that I'm also a sceptic of converting every possible info/warning/error to an Exception but that's a different topic</pre>
      </blockquote>
    </p>
    <p><br>
    </p>
    <p>I didn't intend to imply that this would replace all Warnings.
      Think of it more as replacing the "returns false on error" part of
      the fopen() signature.</p>
    <p><br>
    </p>
    <p>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">If we decide to add something like the above I would very much prefer the try ... ignore block to be an expression with value null on error, making the first line obsolete.</pre>
      </blockquote>
    </p>
    <p><br>
    </p>
    <p>Good point, I agree.</p>
    <p><br>
    </p>
    <pre class="moz-signature" cols="72">-- 
Rowan Tommins
[IMSoP]</pre>
  </body>
</html>

--------------wt5IeCCUakya6GINMectBPv9--