Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128338
Precedence: bulk
MIME-Version: 1.0
References: <CAJWOiuN8fuejkX1Tj0h=s_Fs2bGEtz-qdMZxRTC1s4at23y=Vw@mail.gmail.com>
 <aef1a188-cc6a-450d-b64b-b821007f96c2@app.fastmail.com> <CAJWOiuOdzev9w8JULOQUpHmNpRONqH9op1vXaSxo=oFMj9Am4w@mail.gmail.com>
In-Reply-To: <CAJWOiuOdzev9w8JULOQUpHmNpRONqH9op1vXaSxo=oFMj9Am4w@mail.gmail.com>
Date: Thu, 31 Jul 2025 12:21:24 +0300
Message-ID: <CANTuiHuixRV4+BxGDEwFouMjw4-yNbMBVD-CcY5wm_-9O2B5=g@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Optional Catch Block Body
To: Mihail Liahimov <91liahim@gmail.com>
Cc: Rob Landers <rob@bottled.codes>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000f4f95f063b362a6a"
From: xepozzd@gmail.com (Dmitry Derepko)

--000000000000f4f95f063b362a6a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 31, 2025 at 10:42=E2=80=AFAM Mihail Liahimov <91liahim@gmail.co=
m> wrote:

> Hi, Rob!
>
> When we want to avoid returning null values, we resort to using exception=
s
> so that the client code can somehow handle the absence of values.
> For example:
>
> if ($user->getName() !=3D=3D null) {
> $this->doSomethingWithUserName($user->getName());
> }
>
> We usually add an exception inside such getters if there is no value:
>
> try {
> $this->doSomethingWithUserName($user->getName());
> } catch (UserNameIsNull);
>

There will be TypeError because "doSomethingWithUserName" should accept
strings.
Using exceptions to check types is rough practice because exceptions aren't
cheap. "if" is cheaper.


>
> This is useful when we need to "do nothing" when there is no value. In my
> opinion, this code looks more declarative.
>
> We can do something like this also with repositories:
>
> try {
> $post =3D $this->postRepository->get($postId);
>
> // do something with post
> } catch (PostNotFound);
>

Instead of idents inside another block I'd prefer to use early returns:

try {
-- ...
-- ...
-- ...
-- ...
-- ...
} catch (...)

vs

try {
-- ...
} catch (...) {
-- return
}
...
...
...
...

Or even "if"

if (!...) {
-- return ...
}
...
...
...
...



--=20
Best regards,
Dmitrii Derepko.
@xepozz

--000000000000f4f95f063b362a6a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Jul 31, 2025 at 10:42=E2=80=AFAM =
Mihail Liahimov &lt;<a href=3D"mailto:91liahim@gmail.com">91liahim@gmail.co=
m</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"=
ltr"><div>Hi, Rob!<br><br>When we want to avoid returning null values, we r=
esort to using exceptions so that the client code can somehow handle the ab=
sence of values.<br>For example:<br><br>if ($user-&gt;getName() !=3D=3D nul=
l) {<br>$this-&gt;doSomethingWithUserName($user-&gt;getName());</div><div>}=
<br><br>We usually add an exception inside such getters if there is no valu=
e:<br><br>try {</div><div>$this-&gt;doSomethingWithUserName($user-&gt;getNa=
me());<br></div><div>} catch (UserNameIsNull);<br></div></div></div></block=
quote><div><br></div><div>There will be TypeError because &quot;doSomething=
WithUserName&quot; should accept strings.=C2=A0</div><div>Using exceptions =
to check types is rough practice because exceptions aren&#39;t cheap. &quot=
;if&quot; is cheaper.</div><div>=C2=A0</div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div><br>This is usefu=
l when we need to &quot;do nothing&quot; when there is no value. In my opin=
ion, this code looks more declarative.<br><br>We can do something like this=
 also with repositories:<br><br>try {<br>$post =3D $this-&gt;postRepository=
-&gt;get($postId);</div><div><br></div><div>// do something with post</div>=
<div>} catch (PostNotFound);</div></div></div>
</blockquote></div><div><br clear=3D"all"></div><div>Instead of idents=C2=
=A0inside another block I&#39;d prefer to use early returns:</div><div><br>=
</div><div>try {</div><div>-- ...</div><div>-- ...</div><div>-- ...</div><d=
iv>-- ...</div><div>-- ...</div><div>} catch (...)</div><div><br></div><div=
>vs</div><div><br></div><div>try {</div><div>-- ...</div><div>} catch (...)=
 {</div><div>-- return</div><div>}</div><div>...</div><div>...</div><div>..=
.</div><div>...</div><div><br></div><div>Or even &quot;if&quot;</div><div><=
div></div><div><br class=3D"gmail-Apple-interchange-newline">if (!...) {</d=
iv><div>-- return ...</div><div>}</div><div>...</div><div>...</div><div>...=
</div><div>...</div></div><div><br></div><div><br></div><div><br></div><spa=
n class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"=
gmail_signature"><div dir=3D"ltr"><div style=3D"color:rgb(34,34,34)">Best r=
egards,</div><div style=3D"color:rgb(34,34,34)"><div dir=3D"ltr"><div dir=
=3D"ltr">Dmitrii Derepko.</div><div><a>@xepozz</a></div></div></div></div><=
/div></div>

--000000000000f4f95f063b362a6a--