Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128337
Precedence: bulk
MIME-Version: 1.0
References: <CAJWOiuN8fuejkX1Tj0h=s_Fs2bGEtz-qdMZxRTC1s4at23y=Vw@mail.gmail.com>
 <aef1a188-cc6a-450d-b64b-b821007f96c2@app.fastmail.com>
In-Reply-To: <aef1a188-cc6a-450d-b64b-b821007f96c2@app.fastmail.com>
Date: Thu, 31 Jul 2025 12:16:10 +0300
Message-ID: <CANTuiHs98kxQUwS0dTKzUa84aa_c=Qq9N2b=rn5tCJRsiRHEXA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Optional Catch Block Body
To: Rob Landers <rob@bottled.codes>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000472397063b3618fb"
From: xepozzd@gmail.com (Dmitry Derepko)

--000000000000472397063b3618fb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 31, 2025 at 10:12=E2=80=AFAM Rob Landers <rob@bottled.codes> wr=
ote:


> my empty catches have lengthy comments describing why they are empty in
> case a user steps into it, so they can better understand how the framewor=
k
> works.
>
> =E2=80=94 Rob
>

Agree. I prefer to describe why I've wrote it:
try {  ... } catch (...) {
  /**
   * We don't care If it's broken, because we should go further.
   */
}

A few cases from my side:

$decoded =3D [];
try {
  $decoded =3D json_decode($unknownData, asArray: true);
} catch (JsonException);

Almost the same as

try {
  $decoded =3D json_decode($unknownData, asArray: true);
} catch (JsonException) {
  $decoded =3D [];
}

try {
  doSmth()
} catch (RaceConditionException $e) {
  // ok, skip 'cause another worker did the same
}


--=20
Best regards,
Dmitrii Derepko.
@xepozz

--000000000000472397063b3618fb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Jul 31, 2025 at 10:12=E2=80=AFAM =
Rob Landers &lt;rob@bottled.codes&gt; wrote:</div><div class=3D"gmail_quote=
 gmail_quote_container"><div>=C2=A0</div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex"><div><div>my empty catches have lengthy comments describing=
 why they are empty in case a user steps into it, so they can better unders=
tand how the framework works.</div><div><br></div><div id=3D"m_-17145110524=
10690779sig121229152">=E2=80=94 Rob</div></div></blockquote></div><div><br =
clear=3D"all"></div><div>Agree. I prefer to describe why I&#39;ve wrote it:=
</div><div>try {=C2=A0 ... } catch (...) {</div><div>=C2=A0 /**</div><div>=
=C2=A0 =C2=A0* We don&#39;t care If it&#39;s broken, because we should go f=
urther.</div><div>=C2=A0 =C2=A0*/</div><div>}</div><div><br></div><div>A fe=
w cases from my side:</div><div><br></div><div>$decoded =3D [];</div><div>t=
ry {=C2=A0</div><div>=C2=A0 $decoded =3D json_decode($unknownData, asArray:=
 true);=C2=A0</div><div>} catch (JsonException);</div><div><br></div><div>A=
lmost the same as</div><div><br></div><div><div>try {=C2=A0</div><div>=C2=
=A0 $decoded =3D json_decode($unknownData, asArray: true);=C2=A0</div><div>=
} catch (JsonException) {</div><div>=C2=A0 $decoded =3D [];</div><div>}=C2=
=A0</div><div><br></div><div>try {</div><div>=C2=A0 doSmth()</div><div>} ca=
tch (RaceConditionException $e) {</div><div>=C2=A0 // ok, skip &#39;cause a=
nother worker did the same</div><div>}</div><div><br></div></div><div><br><=
/div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" =
class=3D"gmail_signature"><div dir=3D"ltr"><div style=3D"color:rgb(34,34,34=
)">Best regards,</div><div style=3D"color:rgb(34,34,34)"><div dir=3D"ltr"><=
div dir=3D"ltr">Dmitrii Derepko.</div><div><a>@xepozz</a></div></div></div>=
</div></div></div>

--000000000000472397063b3618fb--