Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128330
Precedence: bulk
MIME-Version: 1.0
References: <CAJWOiuN8fuejkX1Tj0h=s_Fs2bGEtz-qdMZxRTC1s4at23y=Vw@mail.gmail.com>
 <aef1a188-cc6a-450d-b64b-b821007f96c2@app.fastmail.com>
In-Reply-To: <aef1a188-cc6a-450d-b64b-b821007f96c2@app.fastmail.com>
Date: Thu, 31 Jul 2025 12:40:42 +0500
Message-ID: <CAJWOiuOdzev9w8JULOQUpHmNpRONqH9op1vXaSxo=oFMj9Am4w@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Optional Catch Block Body
To: Rob Landers <rob@bottled.codes>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000d72134063b34c224"
From: 91liahim@gmail.com (Mihail Liahimov)

--000000000000d72134063b34c224
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Rob!

Good point! I also know one another case when empty catch block are useful.

When we want to avoid returning null values, we resort to using exceptions
so that the client code can somehow handle the absence of values.
For example:

if ($user->getName() !=3D=3D null) {
$this->doSomethingWithUserName($user->getName());
}

We usually add an exception inside such getters if there is no value:

try {
$this->doSomethingWithUserName($user->getName());
} catch (UserNameIsNull);

This is useful when we need to "do nothing" when there is no value. In my
opinion, this code looks more declarative.

We can do something like this also with repositories:

try {
$post =3D $this->postRepository->get($postId);

// do something with post
} catch (PostNotFound);

But again, there is a fine line between situations where an empty body of a
catch block is reasonable and when it is not.

=D1=87=D1=82, 31 =D0=B8=D1=8E=D0=BB. 2025=E2=80=AF=D0=B3. =D0=B2 12:13, Rob=
 Landers <rob@bottled.codes>:

>  even in my case, my empty catches have lengthy comments describing why
> they are empty in case a user steps into it, so they can better understan=
d
> how the framework works.
>
> =E2=80=94 Rob
>

--000000000000d72134063b34c224
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi, Rob!<br><br>Good point! I also k=
now one another case when empty catch block are useful.<br><br>When we want=
 to avoid returning null values, we resort to using exceptions so that the =
client code can somehow handle the absence of values.<br>For example:<br><b=
r>if ($user-&gt;getName() !=3D=3D null) {<br>$this-&gt;doSomethingWithUserN=
ame($user-&gt;getName());</div><div>}<br><br>We usually add an exception in=
side such getters if there is no value:<br><br>try {</div><div>$this-&gt;do=
SomethingWithUserName($user-&gt;getName());<br></div><div>} catch (UserName=
IsNull);<br><br>This is useful when we need to &quot;do nothing&quot; when =
there is no value. In my opinion, this code looks more declarative.<br><br>=
We can do something like this also with repositories:<br><br>try {<br>$post=
 =3D $this-&gt;postRepository-&gt;get($postId);</div><div><br></div><div>//=
 do something with post</div><div>} catch (PostNotFound);<br><br>But again,=
 there is a fine line between situations where an empty body of a catch blo=
ck is reasonable and when it is not.<br></div><br><div class=3D"gmail_quote=
 gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">=D1=87=D1=82,=
 31 =D0=B8=D1=8E=D0=BB. 2025=E2=80=AF=D0=B3. =D0=B2 12:13, Rob Landers &lt;=
rob@bottled.codes&gt;:<br></div><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex"><u></u><div><div>=C2=A0even in my case, my empty catches have length=
y comments describing why they are empty in case a user steps into it, so t=
hey can better understand how the framework works.<br></div><div><br></div>=
<div id=3D"m_8361791828552604938sig121229152">=E2=80=94 Rob</div></div></bl=
ockquote></div></div></div>

--000000000000d72134063b34c224--