Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128240
Content-Type: multipart/alternative; boundary=Apple-Mail-D03900D7-08BE-4C13-BEF8-0848BAA8594E
Content-Transfer-Encoding: 7bit
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] Validating #[\Attribute] targets
In-Reply-To: <CALaXqqTW-r+XoJhcxAp0QEg0c1=azGormzdMfCeOUH=Y2Ga6yA@mail.gmail.com>
Cc: php internals <internals@lists.php.net>
Date: Sat, 26 Jul 2025 16:37:02 +0200
Message-ID: <5CF14046-F7CD-43D1-9A07-A93CDB14EA5D@gmail.com>
References: <CALaXqqTW-r+XoJhcxAp0QEg0c1=azGormzdMfCeOUH=Y2Ga6yA@mail.gmail.com>
To: Daniel Scherzer <daniel.e.scherzer@gmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail-D03900D7-08BE-4C13-BEF8-0848BAA8594E
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable



> Le 25 juil. 2025 =C3=A0 18:37, Daniel Scherzer <daniel.e.scherzer@gmail.co=
m> a =C3=A9crit :
> =EF=BB=BF
> Hi internals,
>=20
> The #[\Attribute] attribute is used to mark classes as being usable as att=
ributes. It currently does not trigger any error if added to a trait, interf=
ace, enum, or abstract class. However, if any of those *were* used as an att=
ribute, calling ReflectionAttribute::newInstance() would fail; if you are no=
t going to call ReflectionAttribute::newInstance(), then you don't really ne=
ed to mark the trait/interface/enum/abstract class as an attribute.
>=20
> I have proposed https://github.com/php/php-src/pull/19154 to add validatio=
n to the #[Attribute] attribute, and it was suggested that I post here on th=
e mailing list in case there were any objections. So, are there?
>=20
> -Daniel

Hi,

Validating more precisely the target of #[Atrribute] is reasonable. Now, obs=
erving that there are several internal attributes that may benefit this capa=
bility (e.g. #[Attribute], #[AllowDynamicProperties], #[Deprecated] on trait=
s as currenty voted on), I wonder if we can also expose this capability to u=
ser-defined attributes? Concretely, there could be the following additional c=
onstants:

* Attribute::TARGET_INTERFACE
* Attribute::TARGET_ABSTRACT_CLASS
* Attribute::TARGET_TRAIT
* Attribute::TARGET_ENUM
* Attribute::TARGET_REGULAR_CLASS

and Attribute::TARGET_CLASS would be equal to the result of combining all of=
 those with the `|` operator.=20

=E2=80=94Claude=20

=E2=80=94Claude=20



--Apple-Mail-D03900D7-08BE-4C13-BEF8-0848BAA8594E
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div dir=3D"ltr"><meta http-equiv=3D"conten=
t-type" content=3D"text/html; charset=3Dutf-8"><div dir=3D"ltr"></div><div d=
ir=3D"ltr"><br></div><div dir=3D"ltr"><br><blockquote type=3D"cite">Le 25 ju=
il. 2025 =C3=A0 18:37, Daniel Scherzer &lt;daniel.e.scherzer@gmail.com&gt; a=
 =C3=A9crit&nbsp;:<br><br></blockquote></div><blockquote type=3D"cite"><div d=
ir=3D"ltr">=EF=BB=BF<div dir=3D"ltr">Hi internals,<div><br></div><div>The #[=
\Attribute] attribute is used to mark classes as being usable as attributes.=
 It currently does not trigger any error if added to a trait, interface, enu=
m, or abstract class. However, if any of those *were* used as an attribute, c=
alling ReflectionAttribute::newInstance() would fail; if you are not going t=
o call ReflectionAttribute::newInstance(), then you don't really need to mar=
k the trait/interface/enum/abstract class as an attribute.</div><div><br></d=
iv><div>I have proposed&nbsp;<a href=3D"https://github.com/php/php-src/pull/=
19154">https://github.com/php/php-src/pull/19154</a> to add validation to th=
e #[Attribute] attribute, and it was suggested that I post here on the maili=
ng list in case there were any objections. So, are there?</div><div><br></di=
v><div>-Daniel</div></div>
</div></blockquote><div dir=3D"ltr"><br></div>Hi,</div><div dir=3D"ltr"><br>=
<div>Validating more precisely the target of #[Atrribute] is reasonable. Now=
, observing that there are several internal attributes that may benefit this=
 capability (e.g. #[Attribute], #[AllowDynamicProperties], #[Deprecated] on t=
raits as currenty voted on), I wonder if we can also expose this capability t=
o user-defined attributes? Concretely, there could be the following addition=
al constants:</div><div><br></div><div>* Attribute::TARGET_INTERFACE</div><d=
iv>* Attribute::TARGET_ABSTRACT_CLASS</div><div>* Attribute::TARGET_TRAIT</d=
iv><div>* Attribute::TARGET_ENUM</div><div>* Attribute::TARGET_REGULAR_CLASS=
</div><div><br></div><div>and Attribute::TARGET_CLASS would be equal to the r=
esult of combining all of those with the `|` operator.&nbsp;</div><div><br><=
/div><div>=E2=80=94Claude&nbsp;</div><div><br></div><div>=E2=80=94Claude&nbs=
p;</div><div><br></div><div><br></div></div></body></html>=

--Apple-Mail-D03900D7-08BE-4C13-BEF8-0848BAA8594E--