Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128236
To: "'Daniel Scherzer'" <daniel.e.scherzer@gmail.com>,
	"'php internals'" <internals@lists.php.net>
References: <CALaXqqTW-r+XoJhcxAp0QEg0c1=azGormzdMfCeOUH=Y2Ga6yA@mail.gmail.com>
In-Reply-To: <CALaXqqTW-r+XoJhcxAp0QEg0c1=azGormzdMfCeOUH=Y2Ga6yA@mail.gmail.com>
Subject: RE: [PHP-DEV] Validating #[\Attribute] targets
Date: Sat, 26 Jul 2025 14:29:30 +0300
Message-ID: <010c01dbfe20$8ddad8e0$a9908aa0$@glaive.pro>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_010D_01DBFE39.B328FB40"
Thread-Index: AQFZ2k2ZJ46Rg5f6UjhMOotW0OmHibVIiOWA
Content-Language: lv
From: juris@glaive.pro ("Juris Evertovskis")

This is a multipart message in MIME format.

------=_NextPart_000_010D_01DBFE39.B328FB40
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hey,

=20

> if you are not going to call ReflectionAttribute::newInstance(), then =
you don't
> really need to mark the trait/interface/enum/abstract class as an =
attribute.

=20

Personally I never knew the `#[\Attribute]` is only required to do =
`->newInstance()`.

=20

The docs make it seem like it=E2=80=99s a boilerplate to have an =
attribute at all: =
https://www.php.net/manual/en/language.attributes.overview.php

And the documented example does not call `newInstance` although the =
attribute is defined with `#[Attribute]`.

=20

I=E2=80=99m also confused as the example created by Ilija =
https://3v4l.org/8Lih3#v8.4.10 that would supposedly break does not =
include `#[Attribute]` at all. But it includes an enum being used as =
attribute without it using the label itself. So what would actually =
break? Using enums as attributes or declaring them as such?

=20

Btw while reviewing the docs =
https://www.php.net/manual/en/language.attributes.classes.php=20

I noticed that

=20

> It is recommended to define a separate class for each attribute.

=20

Recommended as opposed to what other options? I don=E2=80=99t think I =
can use a random string as an attribute without defining it, right? So =
what is this recommendation steering me away from?

=20

BR,

Juris


------=_NextPart_000_010D_01DBFE39.B328FB40
Content-Type: text/html;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" =
xmlns:o=3D"urn:schemas-microsoft-com:office:office" =
xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" =
xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta =
http-equiv=3DContent-Type content=3D"text/html; charset=3Dutf-8"><meta =
name=3DGenerator content=3D"Microsoft Word 15 (filtered =
medium)"><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Aptos;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	font-size:12.0pt;
	font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
span.EpastaStils18
	{mso-style-type:personal-reply;
	font-family:"Aptos",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:11.0pt;
	mso-fareast-language:EN-US;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]--></head><body lang=3DLV link=3Dblue =
vlink=3Dpurple style=3D'word-wrap:break-word'><div =
class=3DWordSection1><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>Hey,<o:p></o:p></sp=
an></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>&gt; if you are =
not going to call ReflectionAttribute::newInstance(), then you =
don't<br>&gt; really need to mark the trait/interface/enum/abstract =
class as an attribute.<o:p></o:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>Personally I never =
knew the `#[\Attribute]` is only required to do =
`-&gt;newInstance()`.<o:p></o:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>The docs make it =
seem like it=E2=80=99s a boilerplate to have an attribute at all: <a =
href=3D"https://www.php.net/manual/en/language.attributes.overview.php">h=
ttps://www.php.net/manual/en/language.attributes.overview.php</a><o:p></o=
:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>And the documented =
example does not call `newInstance` although the attribute is defined =
with `#[Attribute]`.<o:p></o:p></span></p><div><div><p =
class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>I=E2=80=99m also =
confused as the example created by Ilija <a =
href=3D"https://3v4l.org/8Lih3#v8.4.10">https://3v4l.org/8Lih3#v8.4.10</a=
> that would supposedly break does not include `#[Attribute]` at all. =
But it includes an enum being used as attribute without it using the =
label itself. So what would actually break? Using enums as attributes or =
declaring them as such?<o:p></o:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>Btw while =
reviewing the docs <a =
href=3D"https://www.php.net/manual/en/language.attributes.classes.php">ht=
tps://www.php.net/manual/en/language.attributes.classes.php</a> =
<o:p></o:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>I noticed =
that<o:p></o:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>&gt; It is =
recommended to define a separate class for each =
attribute.<o:p></o:p></span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'><o:p>&nbsp;</o:p></=
span></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt;mso-fareast-language:EN-US'>Recommended as =
opposed to what other options? I don=E2=80=99t think I can use a random =
string as an attribute without defining it, right? So what is this =
recommendation steering me away from?<o:p></o:p></span></p><p =
class=3DMsoNormal><b><span =
style=3D'font-size:11.0pt;font-family:"Calibri",sans-serif'><o:p>&nbsp;</=
o:p></span></b></p><p class=3DMsoNormal><span =
style=3D'font-size:11.0pt'>BR,<o:p></o:p></span></p><p =
class=3DMsoNormal><span =
style=3D'font-size:11.0pt'>Juris<o:p></o:p></span></p></div></div></div><=
/body></html>
------=_NextPart_000_010D_01DBFE39.B328FB40--