Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:128234
Precedence: bulk
MIME-Version: 1.0
References: <CAMU7irKKsXxe4j07tsiW45=EWt=fE56Wcz0tdXjdbhYkW3AhJw@mail.gmail.com>
 <BCD461E2-825D-472B-88D9-83435FFBC86A@rwec.co.uk>
In-Reply-To: <BCD461E2-825D-472B-88D9-83435FFBC86A@rwec.co.uk>
Date: Sat, 26 Jul 2025 08:13:27 +0200
Message-ID: <CAMU7ir+CQuNZ--=bVZiuOu7QNv4M++pk1HXSgMkVNyekBSYaDA@mail.gmail.com>
Subject: Re: [PHP-DEV] [DISCUSSION] Adding the "is_integer_safe()" function
To: "Rowan Tommins [IMSoP]" <imsop.php@rwec.co.uk>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: alex.daubois+php@gmail.com (Alexandre Daubois)

Hello Rowan,

Le ven. 25 juil. 2025 =C3=A0 23:10, Rowan Tommins [IMSoP]
<imsop.php@rwec.co.uk> a =C3=A9crit :
> 1) You need to flesh out your proposal to be explicit about *what* it wou=
ld do, as well as why.

Indeed, I was too focused on the why and I forgot the most important part.

The idea is to have a function that receives an integer or a float and
returns bool if the provided argument is inside the safe Javascript
integer interval, namely [-(2^53)+1 ; (2^53)-1]. It's signature would
be `is_integer_safe(int|float $num): bool`. This interval is
considered safe because the floating-point mantissa is stored on 52
bits. This is nicely described in MDN [1].

> 2) The function needs a better name, to avoid confusion over what "safe" =
means.

I agree with you. I haven't come up with a better name yet as this one
could be ambiguous.

Best,
Alex

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Globa=
l_Objects/Number/MAX_SAFE_INTEGER#description