Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:128210 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by lists.php.net (Postfix) with ESMTPS id 00F751A00BC for ; Thu, 24 Jul 2025 13:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1753364166; bh=1bMdGlWpbzYqPwOSiPLO+cht3vlFV5QS9vzCOfzx32Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FZGaw2iwKwVhzbBnQNsHN2O3OgbSx2TK81wpH9fDkCu5HvzSdWrNgaaShgMLIsYbv KqFs53S+nOVHl5IBTCk4vAgta2hjxCr+abfh56aYVupL3d3tVaYKJYkm0UiYqXAj9e AYbtCXCTblums8jWCfKzD9W+ITSHiXlZAbLLNg7FvjBmF8uQyY5NvAG948aIDcGlRT 15dMzQm5mUn7rItt8kmy2G/xPKHicoWeppb3qu9/qTSz5C09fM240+f3Wr3JuXxyiF 8DsmT8m0Dx/KJ1SVGbYYh6mxKVT82FiyHZW2RBgeu/WnsMcuxhAVcyYG+LP5+yA0VH zanB/NnJMoT3g== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 570FE180079 for ; Thu, 24 Jul 2025 13:36:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_20,DKIM_SIGNED, DKIM_VALID,DMARC_MISSING,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=4.0.1 X-Spam-Virus: Error (Cannot connect to unix socket '/var/run/clamav/clamd.ctl': connect: Connection refused) X-Envelope-From: Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 24 Jul 2025 13:35:55 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-553d771435fso1065743e87.3 for ; Thu, 24 Jul 2025 06:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beberlei-de.20230601.gappssmtp.com; s=20230601; t=1753364258; x=1753969058; darn=lists.php.net; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/8kcquL/erVgn1w2RcSEJBBI8FzUMV/udik1pLfFC+U=; b=gJhLmawTPDbRPx13PUTFGMZdmKSnBU9wk0SND60MWuDjrE8KthBcndeqPUTgV1ntjQ 4otI5NMJ3bSXw29q+ArML0APIJ3rIav9fOxjfxJLNBrb69baIiHLICua1NLRMymiHQQT zZFJ15x/3R/kVpEp5Es0ZzID7EQsDCdM6XVORTjfNwAnklfu9daoq5tb9dQWVegjRaz7 EQsIqfHIK4anang563PvvydpSM1OjZpsmRpGN/Ztv07CSc4nmh9R5qKL1OtUnMW2lU4a hSelpv9t/COfyOspJifZ2yfZiY5wxZVVpHheBI5j1hQbecRIH+E6VtWeD/QXlAHnu8t8 efFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753364258; x=1753969058; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/8kcquL/erVgn1w2RcSEJBBI8FzUMV/udik1pLfFC+U=; b=nn54Of+NyPpWmRS8KptF5FXJcTtj4DFFYPvs1V1zwUVMyd8bLnyJ4419OpwVLfdcib TtxOt4BRsN+QIw2ZEVRc1Kz18A64JqcyHsM/LM1v8ZQNQCg6w7vR7BF0jXxFhjOvU31L eAWf2gUj1hByz9BTmL0JKrwq5f3CEIOBIeytVMXqkgYff+V8JuyEN1mB+4LK32iRWGbL qXqSBeHul0HmPk0OFXBRMP2RnyQRTPi9vGUtreFxuAUi8LZnG79QoYNQNRo8kdmJnzzB QH7sMCmOgtSk24Oed8g9f1Xz7zn0hWOh2Slc0q0K9P3NFU3QNpm2mdx6B1Z1x/OtkCAm iiCw== X-Gm-Message-State: AOJu0YzYOGNtHoRYPbwrs7JRZ7QNfSqg0ZC4yzyhL4mSoUa8lvmirFQF TOtZ3Gzl/RZLt+z2GVpWDq/Z09o1Lqw/bBVjR7p9ip/GoFXDNPUuIPPj+YYTJ7Yn+zVoA/XPfCb EAamBbrRe2HejsWASb1bnoKM/YrV7fQkvCzmOxIy8Hw== X-Gm-Gg: ASbGncsz8AQAZc6aoCiQEo7ZciSSwoxbEbF9YpuJ+mDrban1wSVBYx88Dk5KNxdc8T0 5WaeF2Ls8ID6NYlBmQ8kQrRV7YtFrniCjN3hmfyuGbwxs/wjdO9q1aK3IgkpNU5hEqHzvekau9G CzKFxAjOPq8jgERwrSU2Q6IcTHFtk+RFuXDk5SgFeihFF3Epib84CIoEsy3/FNUymd+nmajMB5c PZFN9CecF8mA3AqQlOp8gW0cYX0DY0GXnJKpZ0i X-Google-Smtp-Source: AGHT+IE9WtGJChiySlb7joD5+UbHHjCzmXrLXJTkLigX5ZRv9vywB2WgWcM0Cq+WJmtbMxcjHnyQyStpZXr43PEOaCo= X-Received: by 2002:a05:6512:61d6:10b0:553:ccef:e2f4 with SMTP id 2adb3069b0e04-55a513b30d9mr1864754e87.35.1753364257304; Thu, 24 Jul 2025 06:37:37 -0700 (PDT) Received: from 1064022179695 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Jul 2025 06:37:34 -0700 Received: from 1064022179695 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Jul 2025 06:37:31 -0700 Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 (Mimestream 1.7.1) References: In-Reply-To: Date: Thu, 24 Jul 2025 06:37:34 -0700 X-Gm-Features: Ac12FXzCYVdDfcJSd9ivYYfmEGgv6MYMIT4VZAl3MoEt5u7DoUFxKg05_ASvrl0 Message-ID: Subject: Re: [PHP-DEV] [VOTE] RFC: #[\DelayedTargetValidation] attribute To: Daniel Scherzer Cc: php internals Content-Type: multipart/alternative; boundary="000000000000b803bd063aaced17" From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=) --000000000000b803bd063aaced17 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am 17.07.2025, 18:21:10 schrieb Daniel Scherzer : > Hi internals, > > Voting is now open for this RFC. > > * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute > * Discussion thread: https://externals.io/message/127702 > > Voting will end 2025-07-31 at end-of-day UTC. > > -Daniel > As one of the original attributes RFC authors, I have voted yes on this and hope it passes. its unfortunate that we need to do this, because its a bit of a hacky solution, but its entirely the vault of the original implementation, we didn't think of this. And that we didn=E2=80=99t think of it during the Deprecated RFC as well an= d already set the target validation to the max and just not do anyhting with the attribute. I think a better fix could be to delay target validation automatically to the point when the Engine consumes an attribute, but that would change the original behavior and not sure if that would get a majority, so an opt -in approach is the least bad solution to fix this shortcoming. Another solution, since this will work only with new attributes, would be more informal: that we set target=3Dall for compiler attributes from now on, at least for attributes where we think they could expand in targets in the future. greetings Benjamin --000000000000b803bd063aaced17 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Am 17.07.2025, 18:21:10 schrieb D= aniel Scherzer <daniel.e.= scherzer@gmail.com>:
Hi internals,

Voting is now open for this R= FC.

* RFC:=C2=A0https://wiki.php.net/rfc/delayedtargetvalidation_attribu= te
* Discussion thread:=C2=A0https://externals.io/message/127702

Voting will end 20= 25-07-31 at end-of-day UTC.

-Daniel

As one of the original attribu= tes RFC authors, I have voted yes on this and hope it passes.

its unfortunate that we need to do this, because its a bit of a hacky = solution, but its entirely the vault of the original implementation, we did= n't think of this.=C2=A0
And that we didn=E2=80=99t t= hink of it during the Deprecated RFC as well and already set the target val= idation to the max and just not do anyhting with the attribute.=C2=A0
=

I think a better fix could be to delay target validation autom= atically to the point when the Engine consumes an attribute, but that would= change the original behavior and not sure if that would get a majority, so= an opt-in approach is the least bad solution= to fix this shortcoming. Another solution, since this will work only with = new attributes, would be more informal: that we set target=3Dall for compil= er attributes from now on, at least for attributes where we think they coul= d expand in targets in the future.

greetings
Benjamin

--000000000000b803bd063aaced17--